From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org, danielx.t.mrzyglod@intel.com, shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: fix hotplug attach
Date: Mon, 10 Oct 2016 11:52:36 +0200 [thread overview]
Message-ID: <7074047.vLQ6C6IQvl@xps13> (raw)
In-Reply-To: <1475845276-25527-1-git-send-email-david.marchand@6wind.com>
2016-10-07 15:01, David Marchand:
> If a pci probe operation creates a port but, for any reason, fails to
> finish this operation and decides to delete the newly created port, then
> the last created port id can not be trusted anymore and any subsequent
> attach operations will fail.
>
> This problem was noticed while working on a vm that had a virtio-net
> management interface bound to the virtio-net kernel driver and no port
> whitelisted in the commandline:
[...]
> Two solutions:
> - either update the last created port index to something invalid
> (when freeing a ethdev port),
> - or rely on the port count, before and after the eal attach.
>
> The latter solution seems (well not really more robust but at least)
> less fragile than the former.
> We still have some issues with drivers that create multiple ethdev
> ports with a single probe operation, but this was already the case.
>
> Fixes: b0fb26685570 ("ethdev: convert to EAL hotplug")
>
> Reported-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
Series applied, thanks
prev parent reply other threads:[~2016-10-10 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 13:01 David Marchand
2016-10-07 13:01 ` [dpdk-dev] [PATCH 2/2] ethdev: fix vendor id in debug message David Marchand
2016-10-10 9:52 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7074047.vLQ6C6IQvl@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).