From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B8E8C1C00 for ; Tue, 9 May 2017 15:42:49 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 09 May 2017 06:42:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,314,1491289200"; d="scan'208";a="85329940" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 09 May 2017 06:42:47 -0700 To: Hemant Agrawal Cc: dev@dpdk.org References: <1493811091-26226-1-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <707fb30a-1fae-a4bf-8b53-dbf68752034c@intel.com> Date: Tue, 9 May 2017 14:42:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: notice for changes in kni structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 May 2017 13:42:50 -0000 On 5/8/2017 10:46 AM, Hemant Agrawal wrote: > On 5/4/2017 10:20 PM, Ferruh Yigit wrote: >> On 5/3/2017 12:31 PM, Hemant Agrawal wrote: >>> Signed-off-by: Hemant Agrawal >>> --- >>> doc/guides/rel_notes/deprecation.rst | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >>> index a3e7c72..0c1ef2c 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -81,3 +81,10 @@ Deprecation Notices >>> >>> - ``rte_crpytodev_scheduler_mode_get``, replaced by ``rte_cryptodev_scheduler_mode_get`` >>> - ``rte_crpytodev_scheduler_mode_set``, replaced by ``rte_cryptodev_scheduler_mode_set`` >>> + >>> +* kni: additional functionality is planned to be added in kni to support mtu, macaddr, >>> + gso_size, promiscusity configuration. >>> + some of the kni structure will be changed to support additional functionality >>> + e.g ``rte_kni_request`` to support promiscusity`` and mac_addr, >> >> rte_kni_request is between KNI library and KNI kernel module, shouldn't >> be part of API. >> >>> + ``rte_kni_mbu`` to support the configured gso_size, >> >> Again, rte_kni_mbuf should be only concern of KNI kernel module. >> >>> + ``rte_kni_device_info`` and ``rte_kni_conf`` to also support mtu and macaddr. >> >> rte_kni_device_info also between KNI library and KNI kernel module. >> >> I think deprecation notice not required for above ones. >> >> But you KNI patchset updates rte_kni_conf and rte_kni_ops. >> These are part of KNI API and changing them cause ABI breakage, >> but if new fields appended in these structs, this will not cause an ABI >> breakage, and I think that is better to do instead of deprecation >> notice, what do you think? > > I agree. >> >> >> And apart from above ABI issues, >> adding new fields to "rte_kni_ops" means DPDK application that use KNI >> should implement them, right? > > Well, it depend, if the application is interested in this information or > not? > >> So this suggest everyone require to set promiscuity of KNI device should >> implement this. > > yes! > >> Can't we find another way that all can benefit from a common implementation? > > how you want it differently? Any ideas? Can having default implementations in librte_kni work? Would applications be doing something different, lets say to set MTU? > > >> >> Thanks, >> ferruh >> > >