From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f175.google.com (mail-wj0-f175.google.com [209.85.210.175]) by dpdk.org (Postfix) with ESMTP id 307A52A66 for ; Tue, 6 Dec 2016 18:32:39 +0100 (CET) Received: by mail-wj0-f175.google.com with SMTP id v7so330393205wjy.2 for ; Tue, 06 Dec 2016 09:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qx1WcHz0Znh9P0IMe5OU63RCzjjHtPF+S34VM1ggmZ4=; b=dRWb6CyHoeQCT2gE03L/lWHk+h+cGBtr+PxDiZx4txZel7461XDMBtcuriF+hu9Y9c dcZCdrgynTXofhy7v8XY9ehu9yWTbavWwzD0iOGDdZfMYlc0vD1FbXzrHIRK4JgiudPk 8f7Wv0aJsILegU48G7gFjefKjjNVNzljZY0hBT5BiaPZPCCpSo/IW0UQ8A1z0MZJL5PD utvS5jz1mAgJEEwP3Vu065ru4Y4F47AmFxKtsyAxkMcphbU+Hn4EfJfCQrUrN2bEWNPT DVziBseccSemeqCmpjMzyVOWAyoef1/ZBdKYClDa2t+8V64spXgGRhI+slAiQMw9pBiE fDEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Qx1WcHz0Znh9P0IMe5OU63RCzjjHtPF+S34VM1ggmZ4=; b=Cirg5ibfFFk7JzUigv588M5kYathFlwApt/vOHPHrjEF33JVRfCn1UkhxDZscIy6Vb 7IogJZgkB/OQIU7pY68o2xk0TAb2Ni+1HOReJMU78+zRR3nOfxYhbiBvrHUkltmraQD+ 5826rhQramdAaZY3adA1zUk+mveDqkpXmXuAn4IHNEUjknqSKhuXiC5UMIQZ1RnRquVb eLfnxs/uHDvWjymRRTqvCzdPsLC7CdAm1PCBXSdrtR+titGjUEWLG8gn5wtnHVjUK6Sc iH52srorpeHi0Ps5WoffHnoYieHgilZC3Zd9lcqZ5pmIpS1hNMa/4ffWghSlvbtJoItL 1z2A== X-Gm-Message-State: AKaTC03ZNYXn5Pq+4ZNzx7MQ9iBeixwzBOanswHdxiHgwzqSMEnlfWx2L/L5wbQFl72c06UN X-Received: by 10.194.164.226 with SMTP id yt2mr64095028wjb.201.1481045558876; Tue, 06 Dec 2016 09:32:38 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ua15sm26902594wjb.1.2016.12.06.09.32.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 09:32:38 -0800 (PST) From: Thomas Monjalon To: John McNamara Cc: dev@dpdk.org Date: Tue, 06 Dec 2016 18:32:37 +0100 Message-ID: <7087089.fklzjh68XY@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1480697052-21951-1-git-send-email-john.mcnamara@intel.com> References: <1480697052-21951-1-git-send-email-john.mcnamara@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] doc: add details of sub-trees and maintainers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 17:32:39 -0000 Thanks for documenting the process, John. 2016-12-02 16:44, John McNamara: > +The role of the component maintainers is to: > + I would add: * Coordinate how improvements and fixes are done. > +* Review patches for the component or delegate the review. > + This should be done, ideally, within 1-2 weeks of submission to the mailing list. > +* Add an ``acked-by`` to patches, or patchsets, that they agree are ready for committing to a tree. I do not understand "that they agree are ready" > +Component maintainers can be added or removed by submitting a patch to the ``MAINTAINERS`` file. > +Maintainers should have demonstrated a reasonable level of contributions to the component area or to a similar area. I suggest "a reasonable level of contributions or reviews for the component area". > +This should be confirmed by an ``ack`` from an established contributor. > +There can be more than one component maintainer if desired. > + > +The role of the tree maintainers is to: > + > +* Maintain the overall quality of their tree. > + This can entail additional review, compilation checks or other tests deemed necessary by the maintainer. > +* Commit reviewed patches. We need to explain that a tree maintainer rely on component maintainers and also on any contributor doing a review. However he does not give the same credit to everyone. It is a matter of trust. When a not (yet) trusted contributor gives an opinion, it may need more checks or opinions. > +* Prepare the tree for integration. They are responsibles of the pace, giving time for reviews and tests while releasing in time. > +Tree maintainers can be added or removed by submitting a patch to the ``MAINTAINERS`` file. > +The proposer should justify the need for a new sub-tree and should have demonstrated a sufficient level of contributions in the area or to a similar area. > +This should be confirmed by 3 ``acks`` from established contributors. In practice, people do not give acks because it is obvious. I think there is no need to add the 3 acks rule because of the line below. > +Disagreements on trees or maintainers can be brought to the Technical Steering Committee. Its name is still the "Technical Board". > +Tree backup maintainers, when required, can be selected from the active tree maintainers. > +This can be agreed and coordinated by the tree maintainers. OK, thanks