From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) by dpdk.org (Postfix) with ESMTP id 28EAA1B1A5 for ; Fri, 6 Oct 2017 01:43:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1557; q=dns/txt; s=iport; t=1507246981; x=1508456581; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=7E/89UqdGJu4aEbTXwegmIEvNpmDPME5grgXzbdMngg=; b=jOgmtF5F+Tztpj5IeXx0qVaRuMmXUkITSWcAmjqCgSFnNxTevFNckHHV SkJaQxS4VYtO1DkyLeydClZQfl1n9vnZdpGD29TGlkKyrwFqz0IGVAmMl 8FAkjozDbnS3a1C6+a1E0QHWShc5LM4JJ0aR9aiZxpCU8b7l9jy2iEPxs 8=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CRAQCVwtZZ/4ENJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg12BUoQhm1AJIphBCoIBgzoChBtDFAECAQEBAQEBAWsohRkBBSM?= =?us-ascii?q?ECwEFQRALGAICJgICVxMIAQGKLKZLgW06iy0BAQEBAQEBAwEBAQEkgQ6CH4ICg?= =?us-ascii?q?VGBaisLgnOFUIJHgmEFoTMClGOLXYctlVmBOTYhgQ54FYVjHIIDJIZ6LIIVAQE?= =?us-ascii?q?B?= X-IronPort-AV: E=Sophos;i="5.42,482,1500940800"; d="scan'208";a="302298727" Received: from alln-core-9.cisco.com ([173.36.13.129]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 05 Oct 2017 23:42:59 +0000 Received: from [10.116.86.172] (rtp-rmelton-88111.cisco.com [10.116.86.172]) by alln-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id v95Ngxu6032173; Thu, 5 Oct 2017 23:42:59 GMT To: jingjing.wu@intel.com Cc: dev@dpdk.org References: <20171005191111.27557-1-rmelton@cisco.com> From: "Roger B. Melton" Message-ID: <7098ec62-43ed-51c8-6711-a57cb92277d7@cisco.com> Date: Thu, 5 Oct 2017 19:42:53 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005191111.27557-1-rmelton@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 23:43:01 -0000 Hi Everyone, As soon as I submitted the patch, I realized I neglected to signoff.  What's the recommended procedure, resubmit the original signed off, or bump to v1? Thanks, Roger On 10/5/17 3:11 PM, Roger B Melton wrote: > --- > > i40evf tx vector logic frees mbufs, but it does not remove the > mbufs from software rings which leads to double frees. This change > corrects that oversight. We've validated this fix within our application. > > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 39a6da0..fdc6fce 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -127,6 +127,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq) > if (likely(m != NULL)) { > free[0] = m; > nb_free = 1; > + txep[0].mbuf = NULL; > for (i = 1; i < n; i++) { > m = rte_pktmbuf_prefree_seg(txep[i].mbuf); > if (likely(m != NULL)) { > @@ -139,14 +140,17 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq) > free[0] = m; > nb_free = 1; > } > + txep[i].mbuf = NULL; > } > } > rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free); > } else { > + txep[0].mbuf = NULL; > for (i = 1; i < n; i++) { > m = rte_pktmbuf_prefree_seg(txep[i].mbuf); > if (m != NULL) > rte_mempool_put(m->pool, m); > + txep[i].mbuf = NULL; > } > } >