From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 419A0101B for ; Tue, 21 Mar 2017 07:02:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490076167; x=1521612167; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=D6ZO3JHxT3U1aGLOG/xVn+0UYvG2Yskgj5RI/rOcTV0=; b=wzCt0cAgkpNR5dfNXX1GhoKG4BvGCblFVTNwnajPPPbGo8siaq9dUQWE d/iN7CO9C8RopIveGE+AvPAMvqwlPA==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2017 23:02:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="77629128" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 20 Mar 2017 23:02:45 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Mar 2017 23:02:45 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.175]) by FMSMSX154.amr.corp.intel.com ([169.254.6.66]) with mapi id 14.03.0319.002; Mon, 20 Mar 2017 23:02:45 -0700 From: "Wiles, Keith" To: Shreyansh Jain CC: "Hunt, David" , Olivier MATZ , DPDK , Thomas Monjalon , "hemant.agrawal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver Thread-Index: AQHSof6lJFEQ2q6wQkmXE3arM8FFH6GfQt4A Date: Tue, 21 Mar 2017 06:02:44 +0000 Message-ID: <70A6BC7D-3F07-4484-A8E4-ACB14522355B@intel.com> References: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com> <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com> <37546ac7-1c60-5992-5ebf-eef8e905017e@nxp.com> In-Reply-To: <37546ac7-1c60-5992-5ebf-eef8e905017e@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.105] Content-Type: text/plain; charset="us-ascii" Content-ID: <176CB4E6E7F6E64AB57B329B536F921E@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 06:02:47 -0000 > On Mar 20, 2017, at 11:55 PM, Shreyansh Jain wro= te: >=20 > Hello David, >=20 > On Monday 20 March 2017 08:20 PM, Hunt, David wrote: >>=20 >> On 20/3/2017 10:03 AM, Shreyansh Jain wrote: >>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. >>> Stack mempool handler moved from lib/librte_mempool into drivers/mempoo= l. >>>=20 >=20 > <...> >=20 >>> -} >>> - >>> -static struct rte_mempool_ops ops_stack =3D { >>> - .name =3D "stack", >>> - .alloc =3D stack_alloc, >>> - .free =3D stack_free, >>> - .enqueue =3D stack_enqueue, >>> - .dequeue =3D stack_dequeue, >>> - .get_count =3D stack_get_count >>> -}; >>> - >>> -MEMPOOL_REGISTER_OPS(ops_stack); >>=20 >> Shreyansh, >> Could I suggest you add the parameter "--find-renames" when >> generating the patch files, as this will reduce the size of the patches >> significantly, making for easier review. The patch line count in this >> particular case would be reduced by approx 75%. >=20 > Thanks for suggestion. > Yes, I forgot to use this option while creating this patch. If there > are comments and v2 needs to be created, I will keep this in mind. >=20 >> Regards, >> Dave. I guess I missed an email, but what is the advantage of moving the ring/sta= ck files to the drivers directory as they are not drivers in the sense of a= NIC PMD or any other driver. You can still enable/disable them in the conf= ig files right? Regards, Keith