From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] checkpatch.pl inconsistent results
Date: Sun, 26 Feb 2017 16:20:04 +0000 [thread overview]
Message-ID: <70A7408C6E1BFB41B192A929744D85238A75738B@ALA-MBC.corp.ad.wrs.com> (raw)
In-Reply-To: <1625293.rscMPIi6S2@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Sunday, February 26, 2017 4:12 AM
> To: Legacy, Allain
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] checkpatch.pl inconsistent results
> Importance: High
>
> 2017-02-25 11:54, Legacy, Allain:
...
>
> It is a false positive.
> PRIx64 and PRIu64 are obviously allowed.
> The only thing you need to take care is having spaces around.
>
Ok, thanks Thomas. Obviously PRIx64 and PRIu64 are acceptable so I knew that something must have been wrong with my understanding or what I was doing. I'll ignore these and proceed to fixing the other issues missed because of the older version of checkpatch.pl that I was using. Is there a list of acceptable false positives to avoid wasting time trying to figure these out?
> Maybe the difference is because the first one happens in a standard
> printf function and checkpatch would ignore the specifiers.
Just for curiosity sake I copied the line from my change in to the other patch that I mentioned and the checkpath.pl tool did not flag an error so it seems like it may be file path dependent. Since it is a false positive I won't waste any time trying to chase this down any further.
On the subject of using the correct version of checkpath.pl, has there been any discussions around storing a version of this tool in the dpdk tree to avoid developers using one version while the automated tools use another, or even so that all developers are using the same version at any given time? It has always been my experience that it is better to version control as many of the dependent tools as possible to ensure repeatable and predictable results. If storing a version of the script in the dpdk tree is unacceptable then perhaps automatically downloading a copy from kernel.org at runtime would be better?
next prev parent reply other threads:[~2017-02-26 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 11:54 Legacy, Allain
2017-02-26 9:12 ` Thomas Monjalon
2017-02-26 16:20 ` Legacy, Allain [this message]
2017-02-26 16:42 ` Thomas Monjalon
2017-02-26 17:31 ` Legacy, Allain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70A7408C6E1BFB41B192A929744D85238A75738B@ALA-MBC.corp.ad.wrs.com \
--to=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).