DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] checkpatch.pl inconsistent results
Date: Sun, 26 Feb 2017 17:31:59 +0000	[thread overview]
Message-ID: <70A7408C6E1BFB41B192A929744D85238A7573DF@ALA-MBC.corp.ad.wrs.com> (raw)
In-Reply-To: <6716326.UsPtCJtimW@xps13>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Sunday, February 26, 2017 11:42 AM
> To: Legacy, Allain
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] checkpatch.pl inconsistent results
... 
> Yes it has been discussed few times.
> I don't see any issue at having different results, because the main benefit of
> checkpatch is to help in reviews. If a new tool or version helps to have a
> better code, it's fine but it is probably not a big issue.
> I do not like the idea of saving a copy of checkpatch in DPDK (we won't
> maintain it and it could be used by several DPDK repositories).
> I think we can add an automatic download from kernel.org if the script is not
> found. However it won't fix the versioning.

Ok, I guess what I meant was that the automatic download could fetch the tool from a specific commit id (not master), and we could update the commit id that we want to use on a periodic basis.  That way at least everyone is at the same baseline at any given snapshot in time and results would be reproducible if we had to revert back to an earlier stable branch to port a fix.  

      reply	other threads:[~2017-02-26 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 11:54 Legacy, Allain
2017-02-26  9:12 ` Thomas Monjalon
2017-02-26 16:20   ` Legacy, Allain
2017-02-26 16:42     ` Thomas Monjalon
2017-02-26 17:31       ` Legacy, Allain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70A7408C6E1BFB41B192A929744D85238A7573DF@ALA-MBC.corp.ad.wrs.com \
    --to=allain.legacy@windriver.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).