From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by dpdk.org (Postfix) with ESMTP id 001F32BFF for ; Wed, 1 Mar 2017 14:23:15 +0100 (CET) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v21DNENi025777 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Wed, 1 Mar 2017 05:23:14 -0800 Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Wed, 1 Mar 2017 05:23:13 -0800 From: "Legacy, Allain" To: "RICHARDSON, BRUCE" CC: Stephen Hemminger , "YIGIT, FERRUH" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions Thread-Index: AQHSkRkJUdZo+3bKWkqLSeNTIYglCKF9EErAgAGuBYCAATy3oA== Date: Wed, 1 Mar 2017 13:23:12 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com> References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com> <1488136143-116389-1-git-send-email-allain.legacy@windriver.com> <1488136143-116389-12-git-send-email-allain.legacy@windriver.com> <20170227084615.7ff06316@xeon-e3> <70A7408C6E1BFB41B192A929744D85238A757FBC@ALA-MBC.corp.ad.wrs.com> <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.166] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 13:23:16 -0000 > -----Original Message----- > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > In my experience, checkpatch ignores long lines that are due to error > messages. Perhaps you need to put the error message on a separate line, > if other things before the message are of significant size. I have gone through the entire patchset and reverted my previous changes to= reduce line length on any occurrences of debug log strings. I kept the e= rror message on the first line and all input variables on subsequent lines = (and no longer than 80). checkpatches.sh flags most of them as warnings, = but since unbroken strings seems more important I will submit my next patch= set version (v3) like this.=20 WARNING:LONG_LINE_STRING: line over 80 characters #120: FILE: drivers/net/avp/avp_ethdev.c:236: + PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n",