From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Allain.Legacy@windriver.com>
Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13])
 by dpdk.org (Postfix) with ESMTP id 05C1E2B9D
 for <dev@dpdk.org>; Wed,  1 Mar 2017 14:29:22 +0100 (CET)
Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com
 [147.11.189.41])
 by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id v21DTH4j009709
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);
 Wed, 1 Mar 2017 05:29:18 -0800 (PST)
Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by
 ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0294.000; Wed, 1
 Mar 2017 05:29:17 -0800
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
CC: "YIGIT, FERRUH" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 08/15] net/avp: device initialization
Thread-Index: AQHSkbnlg/4VQYtKV0iUToTKTOw/EqF/+/IA
Date: Wed, 1 Mar 2017 13:29:16 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D85238A759477@ALA-MBC.corp.ad.wrs.com>
References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com>
 <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488136143-116389-9-git-send-email-allain.legacy@windriver.com>
 <20170228115711.GB29607@localhost.localdomain>
In-Reply-To: <20170228115711.GB29607@localhost.localdomain>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.224.140.166]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 08/15] net/avp: device initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Mar 2017 13:29:23 -0000

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > +/* Ethernet device validation marker */ #define
> RTE_AVP_ETHDEV_MAGIC
> > +0x92972862
>=20
> I think, we don't need to add RTE_ for internal flags and PMD APIs etc.
Ok, will rename.

> > +/* 32-bit MMIO register read */
> > +#define RTE_AVP_READ32(_addr) (*(uint32_t *)(_addr))
>=20
> Use rte_write32 and rte_read32 API instead.
Ok, will replace with standard API.