From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Allain.Legacy@windriver.com>
Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11])
 by dpdk.org (Postfix) with ESMTP id 67561952
 for <dev@dpdk.org>; Fri,  3 Mar 2017 13:14:11 +0100 (CET)
Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com
 [147.11.189.41])
 by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v23CE91w031383
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK);
 Fri, 3 Mar 2017 04:14:09 -0800
Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by
 ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0294.000; Fri, 3
 Mar 2017 04:14:08 -0800
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "DUMITRESCU, CRISTIAN FLORIN" <cristian.dumitrescu@intel.com>, Yuanhan Liu
 <yuanhan.liu@linux.intel.com>, "RICHARDSON, BRUCE"
 <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Jolliffe, Ian" <Ian.Jolliffe@windriver.com>
Thread-Topic: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character
Thread-Index: AQHSk5lpFVKuCWJbrUeFRCC27PQYOKGC0BiAgACuOYD//3sQMIAAkvmA//96PMA=
Date: Fri, 3 Mar 2017 12:14:08 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D85238A75B2D3@ALA-MBC.corp.ad.wrs.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1488482971-170522-2-git-send-email-allain.legacy@windriver.com>
 <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com>
 <20170303005337.GB18844@yliu-dev.sh.intel.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652758102@IRSMSX108.ger.corp.intel.com>
 <70A7408C6E1BFB41B192A929744D85238A75B22B@ALA-MBC.corp.ad.wrs.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652758220@IRSMSX108.ger.corp.intel.com>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912652758220@IRSMSX108.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.224.140.166]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Mar 2017 12:14:11 -0000


> -----Original Message-----
> From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
 > Both approaches can support this. Therefore, IMO the separator char is n=
ot
> enough to justify approach 1. I would only go for approach 1 if there are
> some other parameters that we could consider adding to the load function
> now or later. Do you see any?

No, I don't have any future parameters in mind but that doesn't mean that n=
one will arise eventually.   IMO, the comment character should be specified=
 as an actual "char" in the rte_cfgfile_params.  Specifying it as a flag is=
 a bit kludgy - I don't like overloading a flag/enum to specify something t=
hat already has a type that can be used (char).   Also, I don't think we ne=
ed to control which comment characters are valid.  If the app wants to use =
a 'X' then that's their choice.