From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by dpdk.org (Postfix) with ESMTP id DF99137AA for ; Fri, 3 Mar 2017 13:17:49 +0100 (CET) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v23CHmKj031468 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Fri, 3 Mar 2017 04:17:48 -0800 Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Fri, 3 Mar 2017 04:17:48 -0800 From: "Legacy, Allain" To: "RICHARDSON, BRUCE" CC: "DUMITRESCU, CRISTIAN FLORIN" , Yuanhan Liu , "dev@dpdk.org" , "Jolliffe, Ian" Thread-Topic: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character Thread-Index: AQHSk5lpFVKuCWJbrUeFRCC27PQYOKGC0BiAgACuOYD//3sQMIAAk8kA//97DBA= Date: Fri, 3 Mar 2017 12:17:47 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D85238A75B2F6@ALA-MBC.corp.ad.wrs.com> References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com> <1488482971-170522-2-git-send-email-allain.legacy@windriver.com> <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com> <20170303005337.GB18844@yliu-dev.sh.intel.com> <3EB4FA525960D640B5BDFFD6A3D8912652758102@IRSMSX108.ger.corp.intel.com> <70A7408C6E1BFB41B192A929744D85238A75B22B@ALA-MBC.corp.ad.wrs.com> <20170303121020.GA193932@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170303121020.GA193932@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.166] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 12:17:50 -0000 > -----Original Message----- > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Also, for a single parameter like a comment char, I don't think we need = to go > creating a separate structure. The current flags parameter is unused, so = just > replace it with the comment char one. With using the structure, any addit= ions In my earlier patch, I proprose using a "global" flag to indicate that an u= nnamed section exists so the flags argument would still be needed. =20 > to the struct would be an ABI change anyway, so I see little point in usi= ng it, > unless we already know of additional parameters we will be adding in futu= re. We already have 2 parameters in mind - flags, and comment char. I don't fe= el that combining the two in a single enum is particularly good since it wo= uld be better to allow the application the freedom to set an arbitrary comm= ent character and not be locked in to any static list that we choose (see m= y previous email response).=20