From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Allain.Legacy@windriver.com>
Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11])
 by dpdk.org (Postfix) with ESMTP id 942301396
 for <dev@dpdk.org>; Thu, 16 Mar 2017 16:37:14 +0100 (CET)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
 [147.11.189.40])
 by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v2GFbBYM011247
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK);
 Thu, 16 Mar 2017 08:37:11 -0700
Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by
 ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Thu,
 16 Mar 2017 08:37:10 -0700
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "YIGIT, FERRUH" <ferruh.yigit@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Jolliffe, Ian"
 <Ian.Jolliffe@windriver.com>, "RICHARDSON, BRUCE"
 <bruce.richardson@intel.com>, "MCNAMARA, JOHN" <john.mcnamara@intel.com>,
 "WILES, ROGER" <roger.k.wiles@intel.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>, "vincent.jardin@6wind.com"
 <vincent.jardin@6wind.com>, "jerin.jacob@caviumnetworks.com"
 <jerin.jacob@caviumnetworks.com>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, "3chas3@gmail.com" <3chas3@gmail.com>
Thread-Topic: [PATCH v4 07/17] net/avp: driver registration
Thread-Index: AQHSnmUCXKxgDBpK60uyPP/PgKg7DKGXmQvA
Date: Thu, 16 Mar 2017 15:37:10 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D8523968F24BC@ALA-MBC.corp.ad.wrs.com>
References: <1488414008-162839-1-git-send-email-allain.legacy@windriver.com>
 <1489432593-32390-1-git-send-email-allain.legacy@windriver.com>
 <1489432593-32390-8-git-send-email-allain.legacy@windriver.com>
 <6571ff47-1b94-bc74-ba0e-14dd8d32c0ed@intel.com>
In-Reply-To: <6571ff47-1b94-bc74-ba0e-14dd8d32c0ed@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.224.140.166]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 07/17] net/avp: driver registration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Mar 2017 15:37:15 -0000

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, March 16, 2017 10:53 AM

<...>

> I am for removing static function declarations by reordering functions, a=
nd
> for this case even reordering not required I think, you can remove them.
Ok.  Will do


> > +	/* Get a mac from device config */
> > +	ether_addr_copy(&avp->ethaddr, &eth_dev->data->mac_addrs[0]);
>=20
> This copies MAC address from avp->ethaddr to eth_dev.
> But at this point avp->ethaddr is all zero, is this the intention?

This is because of the patch splitting.  The avp_dev_create() call sets thi=
s up.  I didn't notice that I had them in separate patches.  I will try to =
fix this up.