From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by dpdk.org (Postfix) with ESMTP id 0CDB1D59A for ; Mon, 27 Mar 2017 13:12:34 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id v2RBCXof007739 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 27 Mar 2017 04:12:33 -0700 (PDT) Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Mon, 27 Mar 2017 04:12:32 -0700 From: "Legacy, Allain" To: "DUMITRESCU, CRISTIAN FLORIN" , "RICHARDSON, BRUCE" CC: "yuanhan.liu@linux.intel.com" , "dev@dpdk.org" Thread-Topic: [PATCH v2 6/6] cfgfile: add support for empty value string Thread-Index: AQHSmNa2lkCJrPvZok+KFh8AUjGBdqGonjcggAAFgVA= Date: Mon, 27 Mar 2017 11:12:32 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D8523968F7D70@ALA-MBC.corp.ad.wrs.com> References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com> <1489065060-98370-1-git-send-email-allain.legacy@windriver.com> <1489065060-98370-7-git-send-email-allain.legacy@windriver.com> <3EB4FA525960D640B5BDFFD6A3D891265277BE82@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891265277BE82@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.166] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] cfgfile: add support for empty value string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 11:12:35 -0000 We have a legacy file format that we need to support. Other parts of our = system are able to handle a "key=3D" entry in the file so we are trying to = gain parity with those parsers.=20 Allain Allain Legacy, Software Developer direct 613.270.2279=A0=A0fax 613.492.7870 skype allain.legacy =A0 > -----Original Message----- > From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com] > Sent: Monday, March 27, 2017 6:55 AM > To: Legacy, Allain; RICHARDSON, BRUCE > Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org > Subject: RE: [PATCH v2 6/6] cfgfile: add support for empty value string >=20 >=20 >=20 > > -----Original Message----- > > From: Allain Legacy [mailto:allain.legacy@windriver.com] > > Sent: Thursday, March 9, 2017 1:11 PM > > To: Richardson, Bruce ; Dumitrescu, > > Cristian > > Cc: yuanhan.liu@linux.intel.com; dev@dpdk.org > > Subject: [PATCH v2 6/6] cfgfile: add support for empty value string > > > > This commit adds support to the cfgfile library for parsing a > > key=3Dvalue line that has no value string specified (e.g., "key=3D"). > > This can be used to override a configuration attribute that has a > > default value or default list of values to set it back to an undefined > > value to disable functionality. > > >=20 > IMO allowing empty string key values is confusing and should not be allow= ed. >=20 > I think there are better alternatives for setting a key to its default va= lue: > key =3D default > key =3D DEFAULT > key =3D >=20 > Any reason not to use these approaches?