From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Allain.Legacy@windriver.com>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
 by dpdk.org (Postfix) with ESMTP id D2D8ECFA2
 for <dev@dpdk.org>; Wed, 29 Mar 2017 13:31:50 +0200 (CEST)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
 [147.11.189.40])
 by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id v2TBVmSJ000492
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);
 Wed, 29 Mar 2017 04:31:48 -0700 (PDT)
Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by
 ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Wed,
 29 Mar 2017 04:31:48 -0700
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "DUMITRESCU, CRISTIAN FLORIN" <cristian.dumitrescu@intel.com>,
 "RICHARDSON, BRUCE" <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "yuanhan.liu@linux.intel.com"
 <yuanhan.liu@linux.intel.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>
Thread-Topic: [PATCH v3 3/6] cfgfile: add support for configurable comment
 character
Thread-Index: AQHSqCYh+cw2DJatSEeWXP64FWPoUqGritRwgAAkdgA=
Date: Wed, 29 Mar 2017 11:31:47 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D8523968F9C26@ALA-MBC.corp.ad.wrs.com>
References: <1489065060-98370-1-git-send-email-allain.legacy@windriver.com>
 <20170329004737.44249-1-allain.legacy@windriver.com>
 <20170329004737.44249-4-allain.legacy@windriver.com>
 <3EB4FA525960D640B5BDFFD6A3D89126527813FE@IRSMSX108.ger.corp.intel.com>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126527813FE@IRSMSX108.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.224.140.166]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 3/6] cfgfile: add support for configurable
 comment character
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2017 11:31:51 -0000

> -----Original Message-----
> From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
> Sent: Wednesday, March 29, 2017 5:23 AM
> >
> > +/** Configuration file operation optional arguments */ struct
> > +rte_cfgfile_parameters {
> > +	char comment_character;
> > +	/**< Config file comment character; one of '!', '#', '%', ';', '@'
> > +*/
>=20
> I think this comment should be placed above the structure field definitio=
n
> (preferable) or on the same line, but not below.

Ok.  I will relocate it in v4 to be above.  The /**< */ construct allows fo=
r putting comments on the following line.=20

> >  /**
> > + * Open config file with specified optional parameters.  Use @see
> > + * rte_cfgfile_init_parameters to setup the default parameters.
> > + *
>=20
> Please update this comment, as there is no rte_cfgfile_init() function
> anymore.


Ok.  Will do.