From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Allain.Legacy@windriver.com>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
 by dpdk.org (Postfix) with ESMTP id 352C5D212
 for <dev@dpdk.org>; Wed, 29 Mar 2017 13:33:48 +0200 (CEST)
Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com
 [147.11.189.41])
 by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id v2TBXkL9000644
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);
 Wed, 29 Mar 2017 04:33:46 -0700 (PDT)
Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by
 ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0294.000; Wed,
 29 Mar 2017 04:33:45 -0700
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "DUMITRESCU, CRISTIAN FLORIN" <cristian.dumitrescu@intel.com>,
 "RICHARDSON, BRUCE" <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "yuanhan.liu@linux.intel.com"
 <yuanhan.liu@linux.intel.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>
Thread-Topic: [PATCH v3 6/6] cfgfile: add support for empty value string
Thread-Index: AQHSqCYdnxMtLzJqXkChBAIm6YxbYqGrjOsQgAAi54A=
Date: Wed, 29 Mar 2017 11:33:44 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D8523968F9C32@ALA-MBC.corp.ad.wrs.com>
References: <1489065060-98370-1-git-send-email-allain.legacy@windriver.com>
 <20170329004737.44249-1-allain.legacy@windriver.com>
 <20170329004737.44249-7-allain.legacy@windriver.com>
 <3EB4FA525960D640B5BDFFD6A3D8912652781438@IRSMSX108.ger.corp.intel.com>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912652781438@IRSMSX108.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.224.140.166]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 6/6] cfgfile: add support for empty value
	string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2017 11:33:48 -0000

> -----Original Message-----
> From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]
> Sent: Wednesday, March 29, 2017 5:31 AM

<...>
> > +#define CFG_FLAG_EMPTY_VALUES (1 << 1)
> >  /**@} */
> >
>=20
> I suggest we group all these flags into an (unnamed?) enum in rte_cfgfile=
.h
> rather than macros.
Ok.  Will do.

>=20
> Can we please add a test to validate that error is triggered for empty ke=
y
> values in the case the CFG_FLAG_EMPTY_VALUES is NOT provided to
> rte_cfgfile_load()?

Already included.  See test_cfgfile_invalid_key_value_pair().