From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id B0F7D2C16 for ; Tue, 25 Apr 2017 15:00:50 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id v3PD0mfF016176 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 25 Apr 2017 06:00:48 -0700 (PDT) Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0294.000; Tue, 25 Apr 2017 06:00:47 -0700 From: "Legacy, Allain" To: Adrien Mazarguil CC: "dev@dpdk.org" , "Peters, Matt" Thread-Topic: [PATCH v2 07/13] net/avp: fix errors in exported headers Thread-Index: AQHSvZ4zHT9dSJIgaE2jmfKEA+6H1qHV+UmwgACFuID//4tCIA== Date: Tue, 25 Apr 2017 13:00:46 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D85239690F322@ALA-MBC.corp.ad.wrs.com> References: <046efd0fda00bfb5253586319fb9cfbf904a8f0a.1493108423.git.adrien.mazarguil@6wind.com> <70A7408C6E1BFB41B192A929744D85239690F2B7@ALA-MBC.corp.ad.wrs.com> <20170425124959.GJ3790@6wind.com> In-Reply-To: <20170425124959.GJ3790@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.166] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 13:00:51 -0000 > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Tuesday, April 25, 2017 8:50 AM <...> > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. >=20 > Missed that one, however I suggest either: >=20 > #ifndef __KERNEL__ around RTE_STD_C11 >=20 > or using __extension__ directly. Which do you prefer? I would prefer if it was done as it is done in rte_kni_common.h to provide = consistency with other similar files. Like this: #ifdef __KERNEL__ #include #define RTE_STD_C11 #else #include #endif ...but if you disagree then I prefer the #ifndef __KERNEL__ option. >=20 > By the way, is the kernel module that depends on rte_avp_common.h > available somewhere to validate compilation against it? There is an older version of the module available on github, but it has not= been updated since the AVP driver has been included in the DPDK. Since t= he AVP directory and files were significantly changed in order to meet the = requirements of the DPDK it won't be much use to you. Until we can updat= e it please make sure both Matt Peters and I are CC'd on the patch requests= and we'll confirm compilation as quickly as possible. > > Would you mind changing the brackets (<>) to quotes ("") since this is = a > local include file? > > > > #include "rte_avp_common.h" >=20 > I will update it. Thank you.