From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Allain.Legacy@windriver.com>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
 by dpdk.org (Postfix) with ESMTP id D40755599
 for <dev@dpdk.org>; Mon,  5 Jun 2017 16:49:12 +0200 (CEST)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
 [147.11.189.40])
 by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id v55EnBB6002193
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL);
 Mon, 5 Jun 2017 07:49:11 -0700 (PDT)
Received: from ALA-MBC.corp.ad.wrs.com ([fe80::fcbe:9b7:1141:89a1]) by
 ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0294.000; Mon, 5
 Jun 2017 07:49:10 -0700
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "ANANYEV, KONSTANTIN" <konstantin.ananyev@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Osman, Dahir" <Dahir.Osman@windriver.com>
Thread-Topic: [PATCH] ip_frag: free mbufs on reassembly table destroy
Thread-Index: AQHSveY26vDZP7+eXEu6uE/0PIX3tqIVHwlggAF6vSA=
Date: Mon, 5 Jun 2017 14:49:09 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D8523969A6AB2@ALA-MBC.corp.ad.wrs.com>
References: <20170425170450.173221-1-allain.legacy@windriver.com>
 <2601191342CEEE43887BDE71AB9772583FB058B4@IRSMSX109.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB9772583FB058B4@IRSMSX109.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [128.224.140.166]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ip_frag: free mbufs on reassembly table
	destroy
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jun 2017 14:49:13 -0000

> -----Original Message-----
> From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com]
> Sent: Sunday, June 04, 2017 12:21 PM
<..>
> >
> > +/* delete fragmentation table */
> > +void
> > +rte_ip_frag_table_destroy(struct rte_ip_frag_tbl *tbl)
> > +{
> > +	uint32_t i;
> > +
> > +	for (i =3D 0; i < tbl->nb_entries; i++)
> > +		ip_frag_free_immediate(&tbl->pkt[i]);
>=20
>=20
> Looks ok, just one thought: wouldn't it be better(faster) in most cases t=
o
> iterate over lru list?
> I suppose usually we wouldn't have nearly all entries filled in.
> Konstantin

Ok, I will send a v2 patch soon.