From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Allain.Legacy@windriver.com> Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id 97C762C18 for <dev@dpdk.org>; Wed, 28 Mar 2018 15:12:33 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id w2SDC5Bl020521 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 28 Mar 2018 06:12:05 -0700 (PDT) Received: from ALA-MBD.corp.ad.wrs.com ([169.254.3.201]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0361.001; Wed, 28 Mar 2018 06:12:00 -0700 From: "Legacy, Allain" <Allain.Legacy@windriver.com> To: "YIGIT, FERRUH" <ferruh.yigit@intel.com>, "LU, WENZHUO" <wenzhuo.lu@intel.com>, "WU, JINGJING" <jingjing.wu@intel.com>, "John W. Linville" <linville@tuxdriver.com>, Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck <ed.czeck@atomicrules.com>, "John Miller" <john.miller@atomicrules.com>, "Peters, Matt" <Matt.Peters@windriver.com>, Harish Patil <harish.patil@cavium.com>, "Rasesh Mody" <rasesh.mody@cavium.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, "Evgeny Schemeilin" <evgenys@amazon.com>, John Daley <johndale@cisco.com>, "Hyong Youb Kim" <hyonkim@cisco.com>, "ZHANG, QI" <qi.z.zhang@intel.com>, "WANG, XIAO" <xiao.w.wang@intel.com>, "XING, BEILEI" <beilei.xing@intel.com>, "ANANYEV, KONSTANTIN" <konstantin.ananyev@intel.com>, Shijith Thotton <shijith.thotton@cavium.com>, Srisivasubramanian Srinivasan <ssrinivasan@cavium.com>, Adrien Mazarguil <adrien.mazarguil@6wind.com>, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, Yongseok Koh <yskoh@mellanox.com>, Jacek Siuda <jck@semihalf.com>, Tomasz Duszynski <tdu@semihalf.com>, Dmitri Epshtein <dima@marvell.com>, Natalie Samsonov <nsamsono@marvell.com>, Jianbo Liu <jianbo.liu@arm.com>, Alejandro Lucero <alejandro.lucero@netronome.com>, Tetsuya Mukawa <mtetsuyah@gmail.com>, Santosh Shukla <santosh.shukla@caviumnetworks.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, Shahed Shaikh <shahed.shaikh@cavium.com>, "RICHARDSON, BRUCE" <bruce.richardson@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Matej Vido <vido@cesnet.cz>, Pascal Mazon <pascal.mazon@6wind.com>, Maciej Czekaj <maciej.czekaj@caviumnetworks.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, "BIE, TIWEI" <tiwei.bie@intel.com>, Shrikrishna Khare <skhare@vmware.com>, "HORTON, REMY" <remy.horton@intel.com>, Ori Kam <orika@mellanox.com>, "DE LARA GUARCH, PABLO" <pablo.de.lara.guarch@intel.com>, "NICOLAU, RADU" <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>, "KANTECKI, TOMASZ" <tomasz.kantecki@intel.com>, "DUMITRESCU, CRISTIAN FLORIN" <cristian.dumitrescu@intel.com>, Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "YIGIT, FERRUH" <ferruh.yigit@intel.com> Thread-Topic: [PATCH] ethdev: replace bus specific struct with generic dev Thread-Index: AQHTxfLbfKisC7iHgkywMgA2eUDjUqPloH4w Date: Wed, 28 Mar 2018 13:11:55 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D8523BA9D1C03@ALA-MBD.corp.ad.wrs.com> References: <20180327174052.266285-1-ferruh.yigit@intel.com> In-Reply-To: <20180327174052.266285-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.231] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 29 Mar 2018 09:59:04 +0200 Subject: Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 28 Mar 2018 13:12:34 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, March 27, 2018 1:41 PM <...> > Subject: [PATCH] ethdev: replace bus specific struct with generic dev >=20 > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. >=20 > Replacing pci specific struct with generic device struct and updating pla= ces > that are using pci device in a way to get this information from generic d= evice. >=20 > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com> >=20 > There is no deprecation notice sent for this update but in this release e= thdev > info already updated and ABI already broken, it can be good opportunity f= or > this update. > --- > app/test-pmd/config.c | 11 ++++++++++- > app/test-pmd/testpmd.h | 24 ++++++++++++++++++------ > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > drivers/net/ark/ark_ethdev.c | 4 +++- > drivers/net/avf/avf_ethdev.c | 2 +- > drivers/net/avp/avp_ethdev.c | 2 +- Acked-by: Allain Legacy <allain.legacy@windriver.com>