From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by dpdk.org (Postfix) with ESMTP id 08C602BF9 for ; Tue, 18 Sep 2018 15:10:29 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id w8ID5xjK005459 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 18 Sep 2018 06:06:14 -0700 Received: from ALA-MBD.corp.ad.wrs.com ([169.254.3.79]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0415.000; Tue, 18 Sep 2018 06:05:52 -0700 From: "Legacy, Allain" To: Jerin Jacob , Ferruh Yigit CC: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , "Qi Zhang" , Xiao Wang , Neil Horman , Remy Horton , Ori Kam , Bruce Richardson , "Pablo de Lara" , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "John W. Linville" , "Peters, Matt" , Ravi Kumar , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , John Daley , Hyong Youb Kim , Gaetan Rivet , Beilei Xing , Konstantin Ananyev , Matan Azrad , "Shahaf Shuler" , Yongseok Koh , "Tomasz Duszynski" , Dmitri Epshtein , "Natalie Samsonov" , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Santosh Shukla , Rasesh Mody , Harish Patil , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Jan Remes , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Amr Mokhtar , Declan Doherty , Chas Williams , David Hunt , Anatoly Burakov , "Harry van Haaren" , Xiaoyun Li , Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [PATCH v2] ethdev: make default behavior CRC strip on Rx Thread-Index: AQHURC+STrSiUr2aXUCLo4LyCrzwdaTp4YYAgAw2dGA= Date: Tue, 18 Sep 2018 13:05:51 +0000 Message-ID: <70A7408C6E1BFB41B192A929744D8523BABE9DB7@ALA-MBD.corp.ad.wrs.com> References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> <20180910113445.GA6418@jerin> In-Reply-To: <20180910113445.GA6418@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.140.227] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 18 Sep 2018 22:08:44 +0200 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 13:10:30 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, September 10, 2018 7:35 AM > To: Ferruh Yigit > Cc: Wenzhuo Lu; Jingjing Wu; Bernard Iremonger; John McNamara; Marko > Kovacevic; Qi Zhang; Xiao Wang; Neil Horman; Remy Horton; Ori Kam; Bruce > Richardson; Pablo de Lara; Radu Nicolau; Akhil Goyal; Tomasz Kantecki; Jo= hn > W. Linville; Legacy, Allain; Peters, Matt; Ravi Kumar; Ajit Khaparde; Som= nath > Kotur; Rahul Lakkireddy; Hemant Agrawal; Shreyansh Jain; John Daley; Hyon= g > Youb Kim; Gaetan Rivet; Beilei Xing; Konstantin Ananyev; Matan Azrad; > Shahaf Shuler; Yongseok Koh; Tomasz Duszynski; Dmitri Epshtein; Natalie > Samsonov; Stephen Hemminger; K. Y. Srinivasan; Haiyang Zhang; Alejandro > Lucero; Tetsuya Mukawa; Santosh Shukla; Rasesh Mody; Harish Patil; Shahed > Shaikh; Andrew Rybchenko; Jasvinder Singh; Cristian Dumitrescu; Jan Remes= ; > Keith Wiles; Maciej Czekaj; Maxime Coquelin; Tiwei Bie; Zhihong Wang; Yon= g > Wang; Amr Mokhtar; Declan Doherty; Chas Williams; David Hunt; Anatoly > Burakov; Harry van Haaren; Xiaoyun Li; Thomas Monjalon; dev@dpdk.org > Subject: Re: [PATCH v2] ethdev: make default behavior CRC strip on Rx >=20 > -----Original Message----- > > > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > > Without any specific Rx offload flag, default behavior by PMDs is to > > strip CRC. > > > > PMDs that support keeping CRC should advertise > DEV_RX_OFFLOAD_KEEP_CRC > > Rx offload capability. > > > > Applications that require keeping CRC should check PMD capability > > first and if it is supported can enable this feature by setting > > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in > rte_eth_dev_configure() > > > > Signed-off-by: Ferruh Yigit > > Acked-by: Tomasz Duszynski > > --- > > v2: > > * fix flag check > > * add KEEP_CRC flag into "show port cap #" > > > > Note "show port cap #" and > > "show port # [r/t]x_offload capabilities/configuration" > > does same thing, in long term I suggest removing "show port cap" one >=20 For AVP devices Acked-by: Allain Legacy