From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D721A0C45; Tue, 21 Sep 2021 17:13:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2BD040DF8; Tue, 21 Sep 2021 17:13:29 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id DD02D4003C for ; Tue, 21 Sep 2021 17:13:27 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="221502096" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="221502096" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 08:11:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="474111648" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2021 08:11:51 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 21 Sep 2021 08:10:46 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 21 Sep 2021 08:10:46 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 21 Sep 2021 08:10:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 21 Sep 2021 08:10:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bwjOQhliDQzG7xgFJr8rBI6Uza2ez3GSJN42/BJ2deCVhmTEXdam735kwVKh+a9ZZRLx7MPSpzSK6Po6+YxbGyWMIBgmP/Ch3SZuinuuRQ/26a34MaImMME/uVnMRvPmI2gzuzijWBMxmTA1ucBwO+9/pm108fu9E0LTTs7MRg8EefA6fNNgk67clF3u5cDpQQF+QFTI4PGUaeKDPs0Txp5ONugMESY7fMJnvIV04fTe2QngJXnr9SHb2wQ2GVD/reYMAKuTEx0rCbM71Hp8u4B0eFqgnq/LHP2NgmXTypO33oGRQjih1X9vifMNxlNJKwT68HR+cKlrdsmotquUSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D+cRp4UA1D7A1D7kcR5ITrXy1z1Oklq+JQ7+l5YV9yw=; b=Cq3s/BvEEI6o1W2Sz8zRMiR3KCIFmyfqkV0QQ2yjYWk0zbc3/dJTIc2JXF9tQU4wC5YtDheVbq2ir2ULFQrPxrMHtUawZhhsnoipmTaBtLtRsr26JnN8lf7Nb7k1O+GQwlWpnnCuSizERp4+ri0MGEpJ5LqCnpClDCBEZOsJSHFdwkMoTR52QUm8JiWuGoofWRmeu83qQiyf8qYHNuD/Xy4SidB4IpWg5PEZNurWiT4ugVg/8oO5bEH+XWJdbzmYB6xiVgMmFke2KuYg02+shNb5omJ1XNcZqTJF4ZDDYuR52yNvzmkfArxlYS9/fRiDDU8ZvTnh/4YSgSS23Z3NYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D+cRp4UA1D7A1D7kcR5ITrXy1z1Oklq+JQ7+l5YV9yw=; b=t/p+rO7Th0qMtKpNd5KUVPWTSUk6aGO3ttHtZ/f4VvcfOJ6TA58vtGo2q0y6UWHeliooCPY1nuEuYw6GsrkNNPi5ydkdtC25OpqzcASgR+uDX9RjkVaYCergcuj7iBB6loVB5ufU7CMl6wzUG6Hr2IUEzxiVG0GhO6kBj0s6NR8= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB4822.namprd11.prod.outlook.com (2603:10b6:510:39::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Tue, 21 Sep 2021 15:10:10 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::a495:76aa:e576:1281]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::a495:76aa:e576:1281%4]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021 15:10:10 +0000 To: David Marchand CC: dev , Bruce Richardson , "Thomas Monjalon" References: <20210915121104.30581-1-david.hunt@intel.com> <20210921115015.36442-1-david.hunt@intel.com> From: David Hunt Message-ID: <70b9fcc3-542d-d405-a4c9-623977258754@intel.com> Date: Tue, 21 Sep 2021 16:10:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB3PR08CA0010.eurprd08.prod.outlook.com (2603:10a6:8::23) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 Received: from [10.4.11.161] (95.45.23.115) by DB3PR08CA0010.eurprd08.prod.outlook.com (2603:10a6:8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Tue, 21 Sep 2021 15:10:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92b9401a-78f8-40b2-ce1b-08d97d11e789 X-MS-TrafficTypeDiagnostic: PH0PR11MB4822: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0jApI1/wA/JRs8O9vzutZCD+0zCWiedwjRS16Galf1xXR6aWBg6/djW0hI67loVMRmtoIHhd4aKc8hWcYBMCcYDDoVMfRbQRueYHUgAQU9gKryeMpP/uQHBhJ6vdVoRL0EDFJX9X1UWvcS88w3JhSuL5/yzRXxQHaDsLCeyBTuD87ZXpleb8x4TaEiMVXUuXqjZkdzGetsWtXAN0jkjNp47zfHF1S/KFWBkU0tAwkReVjSTM2A7VWmst7buxryOhw5CXvcXDhl34ty4yy0ZYognvRd5bHc+6JYZEPPxlVbJxRSYZyEiULBTnRtTUeZ++eSt0qYE6tF7x2ZYQQdtgUviMuN2mHVXAVLranfzQih25r/DSRYvq435dtg/YfTeQTnsB56vcnd3cmXqJYcSo03DwNQ9NYFOc1E1haSi8Q/TbThVmCH7xvDN/6efq8kyh1Ezpl6Zj5UMT2RcYW60Zwu8mpp0yqhzXVAHT2eFs2zLINyAd0+2cOLO149kPwlirE0uEVPXJEC1XWKCLmEMJVYriTN9riE8uLBBVRrioxXMmAdv/PLw0nAwcvl4nNuOV/OJTGnlEhU0/8pDD77ksL+/1hMECimlqa21HCqv+emE1/v3kHCU/VjTpgZJgLg2GOpza2bMgM5UNFn5IyPLMPtul6Yd5nyTciYUcMRWh35M1W12uA+sPRAjh2LF3ZC8F6f3gZN695n7D37cMzy9zu7tpNQ9yVCjx1PRKYzFhkr8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(66476007)(66946007)(508600001)(6916009)(86362001)(6486002)(2906002)(31696002)(66556008)(8676002)(956004)(186003)(83380400001)(5660300002)(38100700002)(2616005)(8936002)(6666004)(26005)(44832011)(4326008)(54906003)(16576012)(316002)(31686004)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TC9jZ0RPNWZzdUYyajR4K1RYdVR6c3ZNRlJFL2xlaGFxQWZnTXNvb09NMGRa?= =?utf-8?B?SnpYa1RJcnA2clNVMSt3NitwTjFZZ1RNb0hMVFhIUVV2R3RlNSsyUzVreHRv?= =?utf-8?B?RFQzVWs2Y05BZC9BY1hzUThHNUJTa1dQMmgyYkNUbkJTYzVyMkxKV3FEd29l?= =?utf-8?B?MGtYRStOVzltTW11RVFHL0pqd2ZnNHF3dzdZeU1VREE2ZmovM1RVSFZTTis1?= =?utf-8?B?bkRENk1iNENGWFBWTURqV0ZxVFFKdEdkVzJLUkJrTktZVWJ3VzdEY295RVN1?= =?utf-8?B?VDJkeWRoQUNyWGdQOU4rNjZJaVdPYkZhNFM2VHNvVHFpNDd4Vm5Za0FqVlNL?= =?utf-8?B?N1NGSUxNdkxrLzBlUjQ1TGI2QVVrbE9MQTh0aTNRZEx4ZFRPd1NzRXRlUUlB?= =?utf-8?B?YmNyTFZyOGdHaWk5UW94WkZ1azU2YnRFU0RuUDVQZjBFck80T21sN0RSaTZr?= =?utf-8?B?MjdhWjlqaU1PaEdiR1FvQTFjeVdaT0lVRlY4VHNZSEs5aWRacldXbFRiWlVh?= =?utf-8?B?Si8xK0R2SEtWUEF2eExwYUpwSGZsOUh3OEQwc0tDTTBXczFCLytsNjVhS0Q5?= =?utf-8?B?RmpsK3Jna2FTdlpRQ1ZWTllGQkh5QkZtU2JZakRRSzZ1RVhvWXVHY3NqcnVE?= =?utf-8?B?V3FxOXM1c1R0R1dUTEFxSFNsVXJwM01XRzN5SzZzMGloN3VSbGJUT2F3Q3ow?= =?utf-8?B?YlczclJ5Tk1uOVFHaDhMandXTGpMcXlld21yUmM1SHF5cUJRL1R3Nkp5eWJx?= =?utf-8?B?bDB6QkJ2UXd0RHhWR1pFcHVPUG05T2RYcTZrcG41SStsOUxvMEs3SEwvSDZF?= =?utf-8?B?YnJ3dEJkSXN4MWJYVFYwSHNXWTlzRGlUYUJSYWZxaEZwMC9TTXNwbnJndFlH?= =?utf-8?B?enNUdlRnbHFKand5a3lPUUhOLzByNzBIYkFRSnZEU2JRalNpWk9CMllLUGV3?= =?utf-8?B?TGlyY2tJTWUvek5kNzNYVG5qN2pMMEl4eXFEQlUzTmRDRkF5WFptZjRZRFNu?= =?utf-8?B?c2FrRHp2VWN0V2hXTCt6ZUp3SXBORkwzVDRWNXpqUWdWKy94bjFMd2pQQ3dM?= =?utf-8?B?eGh6eWhMam9ZVmVXTjR1bkt0Q2RKQWpOVFE4SkRVZ0hpaXlQNlBHQWhWT09w?= =?utf-8?B?b2xDVjgvSWRxV2l0T1gvSWU0TDJ1ZUY1NWZuTi9vKzhuN1UyajJ2Qm44YWZY?= =?utf-8?B?d0ZNSFJyejhuUjhPWUZwUlp5VEdxTXhuS010eVlsdVVJYWsxT0g4K1lVNFhD?= =?utf-8?B?aHVNTlF4YlFYRXY5NHVCcE82WFJZWUpmbUpGdlBaWkFpbVZzaW4yMHVtV2pE?= =?utf-8?B?NFd6SlFrYW9laXJVRDNDeTlCNTNKWmZ3QVdZa1o2SWVnOUE0ZDd3S3lzOVhp?= =?utf-8?B?Q0VPdm5RRmo0Q2lmQjBwNVVqVXkxQ0REZmlheW5aeTFuZG16TFZMbFBtZHFO?= =?utf-8?B?ZzBRUmRieHdXWEdRdjVRYnZRSFlaZERFZjNPQ01zaWZDcHp0SitscGg4S3k2?= =?utf-8?B?MjF2VU9ZQVhnTFN0aDBKbjd4bXc2ejQyUWhxR21tZVN0QXM3MCtrYlNpdEVv?= =?utf-8?B?N1N6Rk9Ea2xBeWVRMUcyWWFhVm8rR2dHWWxIdXVPUmo1MkJtRXZnOEd4bDF6?= =?utf-8?B?Ukp3U2ZxRnZwU2xOWWc1dGlZZlIvcXNCRTZpMnBqbXJFdENFT3ZkRE0xV0d1?= =?utf-8?B?Q3lob2cwTG5Eb2lEZ1o0NUhXSll3aFVIWHk1SUhUaWxpZ1BLeU1KRTlGeGVZ?= =?utf-8?Q?Qb6r+VkuvRXazM4tnOtEBVqdBLd6Wp/ScWTI0pw?= X-MS-Exchange-CrossTenant-Network-Message-Id: 92b9401a-78f8-40b2-ce1b-08d97d11e789 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 15:10:10.3464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wwTGs8ixqMTr0OpZ9YuXT+21XEOEPCfslTQXw2ngDljltJG827nwTvsDAsYmhq1M30ECebsyPaoNCMLLfgrGRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list too long X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/9/2021 2:51 PM, David Marchand wrote: > On Tue, Sep 21, 2021 at 1:50 PM David Hunt wrote: >> static int >> eal_parse_coremask(const char *coremask, int *cores) >> { >> @@ -839,54 +880,89 @@ eal_parse_service_corelist(const char *corelist) >> static int >> eal_parse_corelist(const char *corelist, int *cores) >> { >> - unsigned count = 0; >> + unsigned int count = 0, k; >> char *end = NULL; >> int min, max; >> int idx; >> + int lcores[RTE_MAX_LCORE]; > Static array... > > "-l 0-RTE_MAX_LCORE" / "-c 0x1" / "-l > 0-(RTE_MAX_LCORE-1),0" crash. > > Please set RTE_MAX_LCORE to 4 (or something that is smaller than your > system core count) and run the tests I provided in my previous mail. > Hi David, I did set the lcore_max to 4, and ran the tests you provided, and they all looked OK. However, as you have pointed out, there is a problem with the lcores array, which I have now fixed, I'll push up shortly. I'm not expecting to populate with more than RTE_MAX_LCORE elements, but there was an edge case where one extra was being added. Thanks again, Dave.