From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0BA6F45B04;
	Thu, 10 Oct 2024 16:21:36 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 91AFB409FA;
	Thu, 10 Oct 2024 16:17:59 +0200 (CEST)
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by mails.dpdk.org (Postfix) with ESMTP id 7207B40A80
 for <dev@dpdk.org>; Thu, 10 Oct 2024 16:17:58 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id 39F461F66E
 for <dev@dpdk.org>; Thu, 10 Oct 2024 16:17:58 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 13D601F6C9; Thu, 10 Oct 2024 16:17:58 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on
 hermod.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL,
 T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0
X-Spam-Score: -1.2
Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se
 [62.63.215.114])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id F2F881F71E;
 Thu, 10 Oct 2024 16:17:53 +0200 (CEST)
Message-ID: <70d4090e-aa5e-4e54-8419-34ccbaa7cc17@lysator.liu.se>
Date: Thu, 10 Oct 2024 16:17:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 3/7] eal: add lcore variable performance test
To: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,
 =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
 dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 David Marchand <david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>
References: <20240918080054.725164-2-mattias.ronnblom@ericsson.com>
 <20240918082614.725220-1-mattias.ronnblom@ericsson.com>
 <20240918082614.725220-4-mattias.ronnblom@ericsson.com>
 <98CBD80474FA8B44BF855DF32C47DC35E9F7AC@smartserver.smartshare.dk>
Content-Language: en-US
From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F7AC@smartserver.smartshare.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024-10-09 22:46, Morten Brørup wrote:
>> From: Mattias Rönnblom [mailto:mattias.ronnblom@ericsson.com]
>> Sent: Wednesday, 18 September 2024 10.26
> 
> A few corrections to a comment. Besides that,
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> 
> 
>> +/*
>> + * The potential performance benefit of lcore variables compared to
>> + * the use of statically sized, lcore id-indexed arrays are not
> 
> are not -> is not
> 
>> + * shorter latencies in a scenario with low cache pressure, but rather
>> + * fewer cache misses in a real-world scenario, with extensive cache
>> + * usage. These tests are a crude simulation of such, using <N> dummy
>> + * modules, each wiht a small, per-lcore state. Note however that
> 
> wiht -> with
> 
>> + * these tests has very little non-lcore/thread local state, which is
> 
> has -> have
> 
>> + * unrealistic.
>> + */
> 

All fixed. Thanks.