From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, <dev@dpdk.org>
Cc: <andrew.rybchenko@oktetlabs.ru>, <thomas@monjalon.net>
Subject: Re: [PATCH v2 11/15] net/hns3: remove invalid encapsulation function
Date: Thu, 27 Jan 2022 13:04:26 +0000 [thread overview]
Message-ID: <70ec791b-88c2-8485-b7d7-f70d9111f4cc@intel.com> (raw)
In-Reply-To: <20220122015142.9516-12-humin29@huawei.com>
On 1/22/2022 1:51 AM, Min Hu (Connor) wrote:
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> This patch remove invalid encapsulation functions.
removed functions don't look like encapsulation functions, updating
commit log while merging.
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> drivers/net/hns3/hns3_ethdev.c | 27 ++++++++-------------------
> drivers/net/hns3/hns3_ethdev_vf.c | 13 ++-----------
> 2 files changed, 10 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
> index 9db0cb19f8..491fa41888 100644
> --- a/drivers/net/hns3/hns3_ethdev.c
> +++ b/drivers/net/hns3/hns3_ethdev.c
> @@ -593,22 +593,6 @@ hns3_set_vlan_rx_offload_cfg(struct hns3_adapter *hns,
> return ret;
> }
>
> -static void
> -hns3_update_rx_offload_cfg(struct hns3_adapter *hns,
> - struct hns3_rx_vtag_cfg *vcfg)
> -{
> - struct hns3_pf *pf = &hns->pf;
> - memcpy(&pf->vtag_config.rx_vcfg, vcfg, sizeof(pf->vtag_config.rx_vcfg));
> -}
> -
> -static void
> -hns3_update_tx_offload_cfg(struct hns3_adapter *hns,
> - struct hns3_tx_vtag_cfg *vcfg)
> -{
> - struct hns3_pf *pf = &hns->pf;
> - memcpy(&pf->vtag_config.tx_vcfg, vcfg, sizeof(pf->vtag_config.tx_vcfg));
> -}
> -
> static int
> hns3_en_hw_strip_rxvtag(struct hns3_adapter *hns, bool enable)
> {
> @@ -638,7 +622,8 @@ hns3_en_hw_strip_rxvtag(struct hns3_adapter *hns, bool enable)
> return ret;
> }
>
> - hns3_update_rx_offload_cfg(hns, &rxvlan_cfg);
> + memcpy(&hns->pf.vtag_config.rx_vcfg, &rxvlan_cfg,
> + sizeof(struct hns3_rx_vtag_cfg));
>
> return ret;
> }
> @@ -836,7 +821,9 @@ hns3_vlan_txvlan_cfg(struct hns3_adapter *hns, uint16_t port_base_vlan_state,
> return ret;
> }
>
> - hns3_update_tx_offload_cfg(hns, &txvlan_cfg);
> + memcpy(&hns->pf.vtag_config.tx_vcfg, &txvlan_cfg,
> + sizeof(struct hns3_tx_vtag_cfg));
> +
> return ret;
> }
>
> @@ -962,7 +949,9 @@ hns3_en_pvid_strip(struct hns3_adapter *hns, int on)
> if (ret)
> return ret;
>
> - hns3_update_rx_offload_cfg(hns, &rx_vlan_cfg);
> + memcpy(&hns->pf.vtag_config.rx_vcfg, &rx_vlan_cfg,
> + sizeof(struct hns3_rx_vtag_cfg));
> +
> return ret;
> }
>
> diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
> index a9e129288b..1af2e07e81 100644
> --- a/drivers/net/hns3/hns3_ethdev_vf.c
> +++ b/drivers/net/hns3/hns3_ethdev_vf.c
> @@ -1026,15 +1026,6 @@ hns3vf_get_configuration(struct hns3_hw *hw)
> return hns3vf_get_port_base_vlan_filter_state(hw);
> }
>
> -static int
> -hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q,
> - uint16_t nb_tx_q)
> -{
> - struct hns3_hw *hw = &hns->hw;
> -
> - return hns3_queue_to_tc_mapping(hw, nb_rx_q, nb_tx_q);
> -}
> -
> static void
> hns3vf_request_link_info(struct hns3_hw *hw)
> {
> @@ -1530,7 +1521,7 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
> goto err_set_tc_queue;
> }
>
> - ret = hns3vf_set_tc_queue_mapping(hns, hw->tqps_num, hw->tqps_num);
> + ret = hns3_queue_to_tc_mapping(hw, hw->tqps_num, hw->tqps_num);
> if (ret) {
> PMD_INIT_LOG(ERR, "failed to set tc info, ret = %d.", ret);
> goto err_set_tc_queue;
> @@ -1739,7 +1730,7 @@ hns3vf_do_start(struct hns3_adapter *hns, bool reset_queue)
> uint16_t nb_tx_q = hw->data->nb_tx_queues;
> int ret;
>
> - ret = hns3vf_set_tc_queue_mapping(hns, nb_rx_q, nb_tx_q);
> + ret = hns3_queue_to_tc_mapping(hw, nb_rx_q, nb_tx_q);
> if (ret)
> return ret;
>
next prev parent reply other threads:[~2022-01-27 13:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 10:15 [PATCH 00/15] fix and feature for hns3 PMD Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 01/15] net/hns3: remove unnecessary assignment Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 02/15] net/hns3: fix a misjudgment expression Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 03/15] net/hns3: extract a common API to initialize MAC addrs Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 04/15] net/hns3: remove unnecessary 'inline' Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 05/15] net/hns3: remove unnecessary black lines Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 06/15] net/hns3: extract a function to handle reset fail Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 07/15] net/hns3: extract functions to create RSS and FDIR flow rule Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 08/15] net/hns3: remove unused variables Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 09/15] net/hns3: remove the number of queue descriptors Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 10/15] net/hns3: remove the printing of memory addresses Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 11/15] net/hns3: extract a common interface to obtain revision ID Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 12/15] net/hns3: remove invalid encapsulation function Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 13/15] net/hns3: delete strerror invoke Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 14/15] net/hns3: rename function Min Hu (Connor)
2022-01-07 10:15 ` [PATCH 15/15] net/hns3: support indirect counter action Min Hu (Connor)
2022-01-21 17:29 ` [PATCH 00/15] fix and feature for hns3 PMD Ferruh Yigit
2022-01-22 1:52 ` Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 " Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 01/15] net/hns3: remove unnecessary assignment Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 02/15] net/hns3: fix a misjudgment expression Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 03/15] net/hns3: extract a common API to initialize MAC addrs Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 04/15] net/hns3: remove unnecessary 'inline' Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 05/15] net/hns3: remove unnecessary black lines Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 06/15] net/hns3: extract a function to handle reset fail Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 07/15] net/hns3: remove unused variables Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 08/15] net/hns3: remove the number of queue descriptors Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 09/15] net/hns3: remove the printing of memory addresses Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 10/15] net/hns3: extract a common interface to obtain revision ID Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 11/15] net/hns3: remove invalid encapsulation function Min Hu (Connor)
2022-01-27 13:04 ` Ferruh Yigit [this message]
2022-01-22 1:51 ` [PATCH v2 12/15] net/hns3: delete strerror invoke Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 13/15] net/hns3: rename function Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 14/15] net/hns3: extract functions to create RSS and FDIR flow rule Min Hu (Connor)
2022-01-22 1:51 ` [PATCH v2 15/15] net/hns3: support indirect counter action Min Hu (Connor)
2022-01-27 12:49 ` [PATCH v2 00/15] fix and feature for hns3 PMD Ferruh Yigit
2022-01-27 13:50 ` Ferruh Yigit
2022-01-28 0:40 ` Min Hu (Connor)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70ec791b-88c2-8485-b7d7-f70d9111f4cc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).