From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] nfp: fix mbuf releasing when segments
Date: Wed, 26 Apr 2017 21:07:49 +0100 [thread overview]
Message-ID: <70f8576a-226f-f46c-e2db-de6794915181@intel.com> (raw)
In-Reply-To: <1493202427-25078-1-git-send-email-alejandro.lucero@netronome.com>
On 4/26/2017 11:27 AM, Alejandro Lucero wrote:
> If segments are used, just mbufs previously linked to head descriptor of
> a mbuf chain are released. Other tx descriptor are used for the mbuf chain
> but they keep their linked mbufs without releasing them. It is not a fatal
> issue because sooner or later those descriptors will be head descriptors or
> just used for a single mbuf packet, then those linked mbufs will be released.
> However, this leads to apps needing bigger mbufs pools and some confusion
> about memory requeriments. Indeed, because larget pools, some performance
> impact could also be exptected due to cache misses.
>
> With this patch all tx descriptors will release linked mbufs inside the
> xmit function, and rte_pktmbuf_seg_free is used instead of rte_pktmbuf_free.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-04-26 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 10:27 Alejandro Lucero
2017-04-26 20:07 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f8576a-226f-f46c-e2db-de6794915181@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).