From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com
Subject: Re: [PATCH v2 5/6] vhost: fix and refactor VDUSE reconnect log check
Date: Thu, 24 Oct 2024 11:44:40 +0200 [thread overview]
Message-ID: <70fcea0f-6011-4025-9f95-007f0ba2f7e6@redhat.com> (raw)
In-Reply-To: <CAJFAV8xd7HuO941-q15Q4ypb=ykzFjkU3c9c0Jc9GhR_p6anGQ@mail.gmail.com>
On 10/24/24 10:36, David Marchand wrote:
> On Thu, Oct 24, 2024 at 9:55 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>> - if (reconnect_log->nr_vrings != total_queues) {
>> - VHOST_CONFIG_LOG(name, ERR,
>> - "Queues number mismatch between backend (%u) and reconnection file (%u)",
>> - total_queues, reconnect_log->nr_vrings);
>> - ret = -1;
>> + ret = vduse_reconnect_log_check(reconnect_log, name, features, total_queues);
>> + if (ret < 0) {
>> + VHOST_CONFIG_LOG(name, ERR, "Reconnection log file check failed");
>
> Idem.
> Patch 6 will remove it.
V3 posted addressing both remarks.
Thanks,
Maxime
>
>
>> goto out_log_unmap;
>> }
>> } else if (errno == ENOENT) {
>> --
>> 2.46.2
>>
>
>
next prev parent reply other threads:[~2024-10-24 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 7:54 [PATCH v2 0/6] VDUSE reconnection fixes and cleanup Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 1/6] vhost: fix VDUSE device creation error handling Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 2/6] vhost: fix possible TOCTOU in VDUSE dev creation Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 3/6] vhost: fix VDUSE reconnect device start failure Maxime Coquelin
2024-10-24 7:54 ` [PATCH v2 4/6] vhost: refactor VDUSE reconnection log mapping Maxime Coquelin
2024-10-24 8:34 ` David Marchand
2024-10-24 7:54 ` [PATCH v2 5/6] vhost: fix and refactor VDUSE reconnect log check Maxime Coquelin
2024-10-24 8:36 ` David Marchand
2024-10-24 9:44 ` Maxime Coquelin [this message]
2024-10-24 7:54 ` [PATCH v2 6/6] vhost: move VDUSE reconnection after device is created Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70fcea0f-6011-4025-9f95-007f0ba2f7e6@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).