From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 2BA79558C for ; Sat, 16 Jul 2016 00:09:26 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id f126so40836467wma.1 for ; Fri, 15 Jul 2016 15:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=86h/bKzy1Hb/mclPdvgtwX/VxWORrkYSBSU//laTpxY=; b=Cu9caXNjfUxFP0mHHomcyfRc/cn0mFc5BGUHSuuNrA3WcH7+spUMxSSooBItO1MOZP yWaovUajZXAt6xvv38qwW0BUXtTIlkBJ4Pg8Sj66ik2FeA/coH+rMP9ghWBPYF5lwzcJ OuX+mddR2Nd2esB7/OtA/MGH3Z7aKB2D6ioeO5NkeLuwS7IxeMCsowAKQWb3xe/N8DgJ lD2lNMDqU+SirZoqj2imAgq0jkwnSlXwTE2tgJVKTIKKjorQAYa/cfhHyBvhPIb04Izd HKOoA4nJvReOKHxBzA0LBCFzuk/7yg1nBaSpGihDvMKkrXDSTVyw5Fnpj9AAKK1bhDXT EwOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=86h/bKzy1Hb/mclPdvgtwX/VxWORrkYSBSU//laTpxY=; b=j6/9W0VxuGYEO7oD7E+wdlrrPIn+2luOtks61rozRIDpzi3KmrXJ2YRjqM/EbrinaH J1vP8af//cA+36QIk/kE1o6eY09EfM5Cs98KOIgrGYBDYh+4XHTKXegrg+dZo9iC9YJd 147wm1ThrVUVU2aRJSPAJaKKMPRC/N8KCQfoPyE8NqN+kl2z+A5C9oBbGDYXyrkVobCX V3uk/Yjb8Wkqi8KC40mHV4kj+ajhUYtzsNkZcAgnOwAOnPTMhemSAMTgKsoCqigm9GPy y3DzRfqvcN+A0P4PEVjUQLQINckzUH0tniZt5di4zLHrzjNDLunFPGwqIID7yUvSGeFv nqSw== X-Gm-Message-State: ALyK8tKWZJuaJOMeO3tYnJp/OZ5IwcOkT56AU0YPYKw960xaAoHzR/xMudH5JvHrHCWEDNHb X-Received: by 10.194.71.137 with SMTP id v9mr2773063wju.83.1468620565960; Fri, 15 Jul 2016 15:09:25 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i195sm1075119wmg.1.2016.07.15.15.09.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 15:09:24 -0700 (PDT) From: Thomas Monjalon To: Piotr Azarewicz Cc: dev@dpdk.org, Declan Doherty Date: Sat, 16 Jul 2016 00:09:24 +0200 Message-ID: <7101230.lS75CnBRjb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <592ce77e-576f-d17d-d0b6-c9caed081c3c@intel.com> References: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com> <592ce77e-576f-d17d-d0b6-c9caed081c3c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 22:09:26 -0000 2016-07-13 16:55, Declan Doherty: > On 05/25/2016 02:34 PM, Piotr Azarewicz wrote: > > This patch improve generate_random_key() function by replacing rand() > > function with reading from /dev/urandom. > > > > CID 120136 : Calling risky function (DC.WEAK_CRYPTO) > > dont_call: rand should not be used for security related applications, as > > linear congruential algorithms are too easy to break > > > > Coverity issue: 120136 > > > > Signed-off-by: Piotr Azarewicz > > Acked-by: Declan Doherty Applied, thanks