From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id AAE4B2BB0 for ; Fri, 7 Apr 2017 14:15:49 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id o21so76708143wrb.2 for ; Fri, 07 Apr 2017 05:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=DpDEss2QaMajx1wvBT8K09AiZh3SRMc+0743Ohj+9kI=; b=ReoC/OYXfSn+fhvi/BqOHE5dQNdq/0Bue7O4yKsGNp6rEm0FN1t17UlHo9hES6m+d5 yA/sUCfx2zgPIh2+eysZnrkBhnkJPpRstP1Z/GBjWl2M9/pTxA1Z3RZBxXUh9FnnCXSY +vMFmglFTSHfkPflHSKWzGxTdBRrD/J/kY84QVADMGiVFpA9l8oSxm/cAy9NjTYJGhob WC4d0b/RqWVxSkahgjMQU444AcWr3Cbmt/X/uPd5Gj6wn9xxrYj8apN5R8IVoQY9fKHi LAzipIL2V/XGgsCYnriN22gAmG2h2RlVRxe+zbv+ywW7iwntsbEcMlIqZoSlAJ0GUrCQ DO9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=DpDEss2QaMajx1wvBT8K09AiZh3SRMc+0743Ohj+9kI=; b=f1EdmHC9jn/23EAjnMB6gAYop4qx7lNV6jFLkeGWOEB/JNu+LxUi6yDhEDHBl4lYqu n891l9KTh5/8kG5/0e85SnewSXDyhNCrGzCJH4nLoVUxXXUYFJFP2BDX2PwfWTpYNPvI PLi4l12H+aLUj2BKrlz8mDX78f43GHVJtH5HvFy2wP2O1xEM6FF0VIa3GYJMp7FXPp/k LXoqHqGLACSmEEuRsIJ1JOBr8nsZ8DrD7Cd2oq+2jhim+lR73yAbTwoBSvuZg6JNGpqN vZ091w80MSsl90iaU3puiUEV0nuOkfHK3wYkGVIi2GgootNLzzR5uhF/zb3ngwa+FPsi Lz/w== X-Gm-Message-State: AFeK/H3we0i5DVv0FZ92enhOSvW8P3N+Wns2BHsMulUIBomnXS1JXRYkDexvISLGBk3jG0os X-Received: by 10.223.153.18 with SMTP id x18mr12398298wrb.55.1491567349202; Fri, 07 Apr 2017 05:15:49 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id e21sm6118620wma.5.2017.04.07.05.15.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 05:15:48 -0700 (PDT) From: Thomas Monjalon To: Andriy Berestovskyy Cc: dev@dpdk.org Date: Fri, 07 Apr 2017 14:15:47 +0200 Message-ID: <7103767.xpENpphzvJ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 12:15:49 -0000 2017-04-07 13:02, Andriy Berestovskyy: > At the moment rte_eth_dev_configure() behaves inconsistent: > - for normal frames: zero max_rx_pkt_len uses a default > - for jumbo frames: zero max_rx_pkt_len gives an error > > This patch fixes this inconsistency by using a default value > if max_rx_pkt_len is zero both for normal and jumbo frames. > > Signed-off-by: Andriy Berestovskyy > --- > > Notes: > v3 changes: > - use a default only if max_rx_pkt_len is zero Looks good. Acked-by: Thomas Monjalon It is a small API change but it is fixing an inconsistency, so I think it can be integrated in 17.05-rc2 as is. Any different opinion?