From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C08F6A0562; Wed, 14 Apr 2021 15:07:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52776161AB3; Wed, 14 Apr 2021 15:07:18 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E429A4013F for ; Wed, 14 Apr 2021 15:07:16 +0200 (CEST) IronPort-SDR: Eg/zb3jMwDBa0c2aOKM3Y9uzRFN4TRhMbciSHFso1wRDDc6HsutKfn2PIdXw+/oMuTQ+8O8Jmr lnkfjTFoonCw== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="279945627" X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="279945627" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 06:07:03 -0700 IronPort-SDR: YI7sqDnQi7f+teD5XstRi3COpptXAT9vBfajMpqq6WvqExkHw+aL1c1hwKXHvgADl18Nggcuzp 7O72i7IX6QMg== X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="461205899" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.205.34]) ([10.213.205.34]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 06:07:02 -0700 To: Suanming Mou , Ori Kam , Andrew Rybchenko , Thomas Monjalon References: <20210315192722.35490-1-stephen@networkplumber.org> <20210315192722.35490-2-stephen@networkplumber.org> From: Ferruh Yigit Cc: "dev@dpdk.org" , Stephen Hemminger X-User: ferruhy Message-ID: <7106da73-95a1-30ae-f949-87ecca05b24d@intel.com> Date: Wed, 14 Apr 2021 14:06:58 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 11:48 PM, Suanming Mou wrote: > Hi Stephen, > >> -----Original Message----- >> From: Stephen Hemminger >> Sent: Tuesday, March 16, 2021 3:27 AM >> To: dev@dpdk.org >> Cc: Stephen Hemminger ; Suanming Mou >> >> Subject: [PATCH 1/2] ethdev: make flow API primary/secondary process safe >> >> Posix mutex are not by default safe for protecting for usage from multiple >> processes. The flow ops mutex could be used by both primary and secondary >> processes. > > Process safe is something more widely scope. I assume it should be another feature but not a bugfix for thread-safe? > And the fag RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE we have added is just thread safe. > Hi Suanming, I think 'RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE' flag and what this patch address are different issues. 'RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE' is to add/remove synchronization support for flow APIs, that is for thread safety as flag name suggests. This patch is to solve the problem for multi process, where commit log describes as posix mutex is not safe for multiple process. Stephen, Are you aware of any downside setting 'PTHREAD_PROCESS_SHARED' attribute to the mutex? Any possible performance implications? Ori, Since mlx is heavily using the flow API, is it possible to test this patch? If there is no negative impact, I think we can get this patch, what do you think? >> >> Bugzilla ID: 662 >> Signed-off-by: Stephen Hemminger >> Fixes: 80d1a9aff7f6 ("ethdev: make flow API thread safe") >> Cc: suanmingm@nvidia.com >> --- >> lib/librte_ethdev/rte_ethdev.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index >> 6f514c388b4e..d1024df408a5 100644 >> --- a/lib/librte_ethdev/rte_ethdev.c >> +++ b/lib/librte_ethdev/rte_ethdev.c >> @@ -470,6 +470,7 @@ rte_eth_dev_allocate(const char *name) { >> uint16_t port_id; >> struct rte_eth_dev *eth_dev = NULL; >> + pthread_mutexattr_t attr; >> size_t name_len; >> >> name_len = strnlen(name, RTE_ETH_NAME_MAX_LEN); @@ -506,7 >> +507,10 @@ rte_eth_dev_allocate(const char *name) >> strlcpy(eth_dev->data->name, name, sizeof(eth_dev->data->name)); >> eth_dev->data->port_id = port_id; >> eth_dev->data->mtu = RTE_ETHER_MTU; >> - pthread_mutex_init(ð_dev->data->flow_ops_mutex, NULL); >> + >> + pthread_mutexattr_init(&attr); >> + pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED); >> >> + pthread_mutex_init(ð_dev->data->flow_ops_mutex, &attr); >> >> unlock: >> rte_spinlock_unlock(ð_dev_shared_data->ownership_lock); >> -- >> 2.30.2 >