From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E54BD433E8; Tue, 28 Nov 2023 12:53:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8404F40E54; Tue, 28 Nov 2023 12:53:04 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id 88C18402C2 for ; Tue, 28 Nov 2023 12:53:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j9xlemYkz3fBE375O55Xo6lP+P8wBlQPoM+sWt0d/GzCV0oC9JrtLiHcbyDsMKbk7T+L7UO8sBK6rAxp5nGJLoMLFJTKrSrvjFLc5EzA5aTbh0wTB6sjPs6hQDW7qd3ZKAjimShroV4av4CHXILZK21aqWo6Z7s5AUA1ti4Dg5UNIa5DAcYlyPEcJnkhC/F5hSjZ5IHtEM5G+gWOOwDPIBsjNJQKokAE4RRYS3kIC7RrIJd+WwOo3ZHWXKZGwnHWv1aDPx2aB1kyUKFPO6nBdG0meRmBHQl/uTxstjYHQCVYU2t3dbI6LCxRqjD22HvsnC39qmjJLAmSQ0uaJssL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5gxxSRGsAIZIySZt7KjmuAO4WZeGakUX3X6BLJh4WLQ=; b=LOcTIDnN81wB9UMO7eysInQjfA076B6pBeYLT/v5/ysYSWjAJSDOHPfaLieMvJavHerUHUmfJtO6sqTfSAnuj/+7x6BT9ra7paVNcdq23f32wDX7sa0fHciFhuoNoULeuVJalSVghbzuA7orBkadxNhTsfBXXrhHdLBtG629gH++brzJ7O0RLkDcBMjgUgthZhBBnlxsiNd+bYCo1Nm2ByRXbbCD3Wfdsl2Ohq9s12aOkTXmAG87jxtUmiUNcGHownxXrfUXjvwxASs5twW1+zJ5lpxDYn/ojMW0MjTSxPJwid0dASuaX8+0AYZ/6jrJiICwokBhbYh2SMBBe+LhvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5gxxSRGsAIZIySZt7KjmuAO4WZeGakUX3X6BLJh4WLQ=; b=FVfi5TNmJ6acrU5l6toC1mEG1+z25iIUDVMowGyuiqqxpsNFMHfoGOasq9KvDxgScKQK29H+XZO5/7pmBBzIG4aaPVgLFpNPvj8Xt/quB/Ox0oqSH2aaAjjFRGryEBUqa5SZqZcrKrNmtLNEGDrfwIpnmSSmqkGKBNqCUo9pDFI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5052.namprd12.prod.outlook.com (2603:10b6:408:135::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.22; Tue, 28 Nov 2023 11:52:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 11:52:58 +0000 Message-ID: <711da56d-cf6b-4bba-896f-c6df9e069d1e@amd.com> Date: Tue, 28 Nov 2023 11:52:52 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org Cc: liuyonglong@huawei.com, thomas@monjalon.net, Chengwen Feng , Dongdong Liu , Jie Hai References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-2-lihuisong@huawei.com> <89b73632-8a7a-e54c-2957-04c347027c2e@huawei.com> <8968ac41-bf19-40ac-a057-aad7b46b7ca8@amd.com> <93239148-8a4d-7b3a-9e39-6659566c64dc@huawei.com> <7c165606-8064-41c0-82c2-51453f545577@amd.com> <659676fa-fce3-1f93-b893-e5f0d0f55ec9@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <659676fa-fce3-1f93-b893-e5f0d0f55ec9@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cb::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5052:EE_ X-MS-Office365-Filtering-Correlation-Id: a943ae58-b5e2-496a-3c8b-08dbf008907b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eEkk+N/DWs+wIlxkm6K28JPygWbgd7SXHn9q28hhaM4F5dFIobJQVonndHQFLiJU8zpyGF5zQXASqVxiomhYnOteY2zu2F8ysngT06BvIH5hmHsQYcgQdTlzZwyjITCgwqnKiiKkBa3u4CSJGEhsuqRdNmRcHQLkVYv7p06JUZDpVuNfycrkdFaxxdfAilFV4msgEhE4JwJjz77a/jKUoGoIkfz7pu3tTm/fvi0x6QPP34Cmj7Ri3yeYLtp8/cvhyt2ZDFxdZ/14OMIR7CLPik83T2K04ottIaKCgpJ3xd4bWIQjY1UHdaHpJZzsc5BCJq96evY7Opm2Am5PUXSoWQbhKQiEJbOpsz/4Q92cF/SUfdSktVxypeobAhDvd/bLcUm3By5xi5DIA97vZHeX7co2Hy11/4cmSag2Gpfom609wygi3qFf52ROMlRaROtQRzoAd4ZfkoPB3xd6Gg38uXMHYojQe+5mfa3IBhF3kumhm3iiUTvb/ki5gVBDhNXccFh7Kw6VqH3CWTOBVmaV+j+9KunxIq1YaJVB6ieTs8AIp6HGHknxkutkdL3uZX6P+7ivyA+GQHCL8m/Wg2bKe83DNgbghTBwY2ZHy5NSP9VhspGQ7u2Pq3NqrS/5YbFPTiX4Zni+oViHY8dsY7W8Bg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39860400002)(376002)(346002)(366004)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(5660300002)(44832011)(41300700001)(8936002)(4326008)(8676002)(31686004)(2906002)(316002)(66556008)(66476007)(66946007)(54906003)(2616005)(6486002)(478600001)(6506007)(36756003)(53546011)(6512007)(26005)(6666004)(83380400001)(86362001)(31696002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2I3WklYd2VqNXBoenAxTXJrS1pDd0xGbHg4YjlKMEpINzdHc0RzK2QwREVs?= =?utf-8?B?UlRGbTd1ZnhSamdtWHcyTU1YN1NhM2tVck5NQjVIWndhalgyZm9MSjhadjFS?= =?utf-8?B?akhuZzEzMWpZaFBsUXdwMHFvUGNmWENmWWJON2plbTJsVWxmTUQrUXJnc05j?= =?utf-8?B?VUVIczhNYVNubFJnZXJ5cE53UGpMcDRzSVl2YVQxOTNqRVFCclUyNU16bkh1?= =?utf-8?B?akxadVgxNmh2cEF2L1c4Q1BYS01hQm9pWXkzVE4vWjhoak9hQXY1ZHhEdjFU?= =?utf-8?B?WE45Q0txOGRNZmVrR2ptZDhNNC9GempEZ0E5ajVsdWZyQU1wTDN1Zk95ZnFp?= =?utf-8?B?amJHblIwUG9vNDFKMDE4OEJVcTJ5L1RsaGVDSWUzcTFGcXp2SWdtRVhYaTJp?= =?utf-8?B?YUdJMXpmSks1M1pndkVaSTRXajFOcjNQdlI0RXpvNC9DTjFwRDk3LzJUdDE4?= =?utf-8?B?YitYdnlJK0xDWEdUMmlBSFdmQS9ibWhvdFFOaWJMMHZiRWFwL095MHltTHJB?= =?utf-8?B?bXo3NFRXUmU2aitmTFF1NnlRelZsRjR3Z2Q2bkpzbzhCQm94RXNpZGhPNWpX?= =?utf-8?B?OXJVWmkwUHZZRC9INm9pQytUOEdrRmNZSXVVSUVIWW54L1ZHdTdMZTRvZUJX?= =?utf-8?B?NEFMT2djMEVZRFpzOWJScjVKREoxQ1VYWWphV3lldlhmcDJIRUNmb0FNUGIx?= =?utf-8?B?QzJLa2lsSElvOGNSdWVNZ3NVb2pja1pUMUh5a1B3QUIvdmtleitpV2RQclcr?= =?utf-8?B?TWhUUzBFa2pJN2FWTjFoWGl4MkZRQXFLc3ZhNkxJQWpQbzFtdFZLTXBQKzk1?= =?utf-8?B?amtHWDVFYUFZMVhhVTQ0VGZMc0RtT29wU0NuSVlHV1F4N25PS2pySXBDclgx?= =?utf-8?B?QlVnU1p6U1h0M3N3SWg5NGNtQ2VjenJqbExhQWRFRUxxRGtnSFBwT3Z1UnlM?= =?utf-8?B?Z3Iwei90dDdDdUFHSFZaVlU0VGtNMFdnWVhmVjlMc2FLQ0VwOHpCOEdGZ2Q1?= =?utf-8?B?Yi9qc3FJazJRTjA3QnhPOU5PVWc0c0cvU3ZHdlN5ZXQxZ0F0UzN3cHBKQVlm?= =?utf-8?B?QUoxYnR4dXNqdHl1eEJ3dlVEREszcDlMSUVJeVdtTVpSSUVKd2dWRDQxYy91?= =?utf-8?B?c2pEVTVJMGNReGRsb0dseXZuZCtIZ1ZQUlVrcjNsRlVERnZ3UVhaanNOay9n?= =?utf-8?B?YnR4N0FZb0VQY3VLS3ZMV24zZ1lPeHFZVVcyaE5QZVozQ0cxalBRU2pjTzFT?= =?utf-8?B?elBoTjREQ1VJbS9CQ1dGeTlaRW9YRDBzQTRYZGpTSlNFVnNmYXFqRmdhM1Rl?= =?utf-8?B?WDVEcnhCYzBiMFpLSk5vT09QeGJ2UmhSQ2hnTm9NVm5aelI3Q3lmS1RZaWxF?= =?utf-8?B?S01hTWdIU0JuVmdrM0xmTzVadGZ2TklaVTk4b3VtYlRrTjJaSUtjdXZvM0Zz?= =?utf-8?B?SGY5SWZPZ1NYaDdBbFZnSXpuMEZNRFROUzEyUWlRWkNwdWxSOGhCc3NmOVhm?= =?utf-8?B?VzcxU1ZKc0t1UHByTURxRWwyTldtcTcxUC9MYkNwanlacTcvcFF3dGZXeDJU?= =?utf-8?B?OWpIQmdTcm5oUitnSUErd1VUUDZFQkhkcy9pUEtzUHFINk9NQTRxQXM4RmlN?= =?utf-8?B?bE9oZEUyR29HOHozU2huckQrcXVKaTU2TUozekQyMFBNdmRxZHdFaW5qYzZr?= =?utf-8?B?UFpBb1o5NlpVSUFvUjYxNVh1Y3craUdYMGRrdm5CZ1VaTER0dkZOa2JPRTJM?= =?utf-8?B?c0szRU8xRExNY3R1bGtKYlpKZDdZMHdkNDU1NjY5UGRtRWdPODQwSW9iSXps?= =?utf-8?B?aVJEaDZxVzBCdFNWV0o3cGNsMUR4NzRzT1k2a0JmRjgwSURRdDc3dSs5QnJM?= =?utf-8?B?eWhtbE1yVWppLzJBUGUyd25meU90MnBiRkFmc1dWZ1g5ZzFtVTRCOFdWeFVT?= =?utf-8?B?UTZZWERWVDVyZkdSZDJub2wvTFk0V2NHQWM2OWlkTHhpdDFTN3lGaEpxenFh?= =?utf-8?B?UWMvMlNuU0ZLQk80cUhzdFJvS0hOQ2U1YndScTlXSnhKb1UweDNQTmMyaTNk?= =?utf-8?B?SDFJREdOQ0U4cGpIdWRhQ0xXV3MvNGlPMktrc1VoSEVXd1JjU29ZRlVoRmp5?= =?utf-8?Q?JfQHAw/YKgGJuCurXONrdSuGB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a943ae58-b5e2-496a-3c8b-08dbf008907b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 11:52:57.9678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rJGpyCzhSjIwd3b1lJn8GnQFDZzZQ3cM6PhNWp45ELnZsRYh6cjnxi0o12UoWUp4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5052 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/28/2023 11:29 AM, lihuisong (C) wrote: > > 在 2023/11/28 18:09, Ferruh Yigit 写道: >> On 11/28/2023 1:21 AM, lihuisong (C) wrote: >>> 在 2023/11/27 23:43, Ferruh Yigit 写道: >>>> On 11/27/2023 1:12 PM, lihuisong (C) wrote: >>>>> 在 2023/11/27 20:19, Ferruh Yigit 写道: >>>>>> On 11/25/2023 1:47 AM, Huisong Li wrote: >>>>>>> Add hash algorithm feature introduced by 23.11 and fix some RSS >>>>>>> features >>>>>>> description. >>>>>>> >>>>>>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") >>>>>>> >>>>>>> Signed-off-by: Huisong Li >>>>>>> Acked-by: Chengwen Feng >>>>>>> --- >>>>>>>     doc/guides/nics/features.rst | 26 ++++++++++++++++++++++---- >>>>>>>     1 file changed, 22 insertions(+), 4 deletions(-) >>>>>>> >>>>>>> diff --git a/doc/guides/nics/features.rst >>>>>>> b/doc/guides/nics/features.rst >>>>>>> index 1a1dc16c1e..0d38c5c525 100644 >>>>>>> --- a/doc/guides/nics/features.rst >>>>>>> +++ b/doc/guides/nics/features.rst >>>>>>> @@ -277,10 +277,12 @@ RSS hash >>>>>>>     Supports RSS hashing on RX. >>>>>>>       * **[uses]     user config**: ``dev_conf.rxmode.mq_mode`` = >>>>>>> ``RTE_ETH_MQ_RX_RSS_FLAG``. >>>>>>> -* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf``. >>>>>>> +* **[uses]     user config**: ``rss_conf.rss_hf``. >>>>>>> >>>>>> Feature title is "RSS hash", it can be two things, >>>>>> 1. "Receive Side Scaling" support >>>>>> 2. Provide RSS hash to application >>>>>> >>>>>> When this document first prepared RSS hash value was always >>>>>> provided to >>>>>> the application when RSS enabled. >>>>>> So intention with this feature was "Receive Side Scaling" support, >>>>>> hence >>>>>> 'RTE_ETH_MQ_RX_RSS_FLAG' added. >>>>>> >>>>>> Later providing RSS has to the application separated as optimization, >>>>>> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for >>>>>> this >>>>>> support. >>>>> What should I do for above two comments？ >>>>> To tell application how to use it? >>>>> >>>> Just tried to give some context. >>> got it. >>>>   >>>>>> As the intention of this feature is "Receive Side Scaling" >>>>>> support, we >>>>>> shouldn't reduce configuration struct to 'rss_conf.rss_hf'. >>>>>> >>>>>> Instead perhaps can expand to: >>>>>> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf' >>>>>    I just pick their common part.😁 >>>>> >>>>> ok, will fix it. >>>>> >>>>>>>     * **[uses]     rte_eth_rxconf,rte_eth_rxmode**: >>>>>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>>>>     * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. >>>>>>>     * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, >>>>>>> ``mbuf.rss``. >>>>>>> +* **[related]  API**: ``rte_eth_dev_configure``, >>>>>>> ``rte_eth_dev_rss_hash_update`` >>>>>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>>>>     >>>>>> ack >>>>>> >>>>>>>       .. _nic_features_inner_rss: >>>>>>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX. >>>>>>>     Inner RSS >>>>>>>     --------- >>>>>>>     -Supports RX RSS hashing on Inner headers. >>>>>>> +Supports RX RSS hashing on Inner headers by rte_flow API. >>>>>>>     >>>>>> This should be clarified with details below, not sure if it >>>>>> required to >>>>>> limit description to rte_flow. >>>>> But this block like rte_flow_action_rss is from rte_flow. >>>>> And ethdev ops doesn't support inner RSS. >>>>> So I think it is ok. >>>>> >>>> Yes it is supported by rte_flow, and '[uses]' information should >>>> already >>>> clarify it. >>> Should we remove the 'rte_flow API' wrods I added in above description? >>> >> I think it can be removed. > The latest version(V5, only three fix doc patch) has been sent out. > Do we I need to send V6 for this?😂 > Nope, no new version needed for this, I already acked the one with it, but if there will be a new version this can be updated. Thanks Huisong for improving the documentation. >> >> >>>>>> And I guess similar confusion exist with the providing hash to user. >>>>>> Need to check if rte_flow implementation puts hash to mbuf along with >>>>>> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload, >>>>>> and update below items accordingly. >>>>> Do we need to tell user how to use it here? >>>>> I feel this document is a little simple and main to list interface for >>>>> user. >>>>> In addition, it is better that the more detail about RSS should be >>>>> presented  in rte_flow features. >>>>> >>>> No, I am not suggesting to add more detail. >>>> >>>> My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be >>>> correct, ethdev APIs checks offload flags, but does rte_flow >>>> implementation check it? >>> As far as I know, It is possibly verified in PMD if have or required. >>>> My suggestion is double check that piece of information and fix it if >>>> required. >>>> >>>> >>>>>>>     * **[uses]    rte_flow_action_rss**: ``level``. >>>>>>>     * **[uses]    rte_eth_rxconf,rte_eth_rxmode**: >>>>>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>>>> @@ -303,9 +305,25 @@ RSS key update >>>>>>>     Supports configuration of Receive Side Scaling (RSS) hash >>>>>>> computation. Updating >>>>>>>     Receive Side Scaling (RSS) hash key. >>>>>>>     -* **[implements] eth_dev_ops**: ``rss_hash_update``, >>>>>>> ``rss_hash_conf_get``. >>>>>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>>>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>>>>> +* **[uses]     user config**: ``rss_conf.rss_key``, >>>>>>> ``rss_conf.rss_key_len`` >>>>>>>     * **[provides]   rte_eth_dev_info**: ``hash_key_size``. >>>>>>> -* **[related]    API**: ``rte_eth_dev_rss_hash_update()``, >>>>>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>>>>> ``rte_eth_dev_rss_hash_update()``, >>>>>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>>>> + >>>>>> ack >>>>>> >>>>>> There is an inconsistency in the documentation but I think it is >>>>>> good to >>>>>> use '()' when documenting API, like: 'rte_eth_dev_configure()' >>>>> +1 will fix it. >>>>>>> + >>>>>>> +.. _nic_features_rss_hash_algo_update: >>>>>>> + >>>>>>> +RSS hash algorithm update >>>>>>> +------------------------- >>>>>>> + >>>>>>> +Supports configuration of Receive Side Scaling (RSS) hash >>>>>>> algorithm. >>>>>>> Updating >>>>>>> +RSS hash algorithm. >>>>>>> + >>>>>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>>>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>>>>> +* **[uses]     user config**: ``rss_conf.algorithm`` >>>>>>> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``. >>>>>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>>>>> ``rte_eth_dev_rss_hash_update()``, >>>>>>>       ``rte_eth_dev_rss_hash_conf_get()``. >>>>>>>       >>>>>> This document describes features listed in the 'default.ini', so we >>>>>> shouldn't have above. >>>>>> >>>>>> And I don't think RSS hash algorithm update is a big enough >>>>>> feature to >>>>>> list in the feature list, perhaps it can be embedded in the RSS >>>>>> support >>>>>> block, what do you think? >>>>> Yes it is not a bit feature. >>>>> so put it to RSS hash, right? >>>>> >>>> Yes please. >>>> >>>> . >> .