From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 353B3432E4; Thu, 9 Nov 2023 13:26:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CF12402E5; Thu, 9 Nov 2023 13:26:23 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id BA91740267 for ; Thu, 9 Nov 2023 13:26:21 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SR1KT50HczMmPq; Thu, 9 Nov 2023 20:21:49 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 9 Nov 2023 20:26:18 +0800 Message-ID: <71243145-ec23-feea-5a32-d514a3dce60e@huawei.com> Date: Thu, 9 Nov 2023 20:26:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [RESEND v7 1/3] ring: fix unmatched type definition and usage To: Jie Hai , , , , , , , CC: , References: <20230117091049.20194-1-haijie1@huawei.com> <20231109102046.1277893-1-haijie1@huawei.com> <20231109102046.1277893-2-haijie1@huawei.com> From: "lihuisong (C)" In-Reply-To: <20231109102046.1277893-2-haijie1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2023/11/9 18:20, Jie Hai 写道: > Field 'flags' of struct rte_ring is defined as int type. However, > it is used as unsigned int. To ensure consistency, change the > type of flags to unsigned int. Since these two types has the > same byte size, this change is not an ABI change. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Jie Hai > Acked-by: Konstantin Ananyev > Acked-by: Chengwen Feng > Acked-by: Morten Brørup > --- > lib/ring/rte_ring_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h > index b7708730658a..14dac6495d83 100644 > --- a/lib/ring/rte_ring_core.h > +++ b/lib/ring/rte_ring_core.h > @@ -119,7 +119,7 @@ struct rte_ring_hts_headtail { > struct rte_ring { > char name[RTE_RING_NAMESIZE] __rte_cache_aligned; > /**< Name of the ring. */ > - int flags; /**< Flags supplied at creation. */ > + uint32_t flags; /**< Flags supplied at creation. */ > const struct rte_memzone *memzone; > /**< Memzone, if any, containing the rte_ring */ > uint32_t size; /**< Size of ring. */