From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 822745424 for ; Thu, 21 Mar 2019 15:59:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 07:59:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,253,1549958400"; d="scan'208";a="309156285" Received: from istokes-mobl1.ger.corp.intel.com (HELO [10.252.18.62]) ([10.252.18.62]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2019 07:59:32 -0700 To: Ferruh Yigit , dev@dpdk.org Cc: stephen@networkplumber.org References: <1551303948-19746-1-git-send-email-ian.stokes@intel.com> <1551303948-19746-2-git-send-email-ian.stokes@intel.com> <5ebcac70-5581-163d-6a13-163d6684eb5e@intel.com> From: Ian Stokes Message-ID: <712baf16-d144-1866-7623-b9b5720025db@intel.com> Date: Thu, 21 Mar 2019 14:59:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <5ebcac70-5581-163d-6a13-163d6684eb5e@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/6] ethdev: add min/max MTU to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 14:59:34 -0000 On 3/21/2019 2:06 PM, Ferruh Yigit wrote: > On 3/21/2019 12:50 PM, Ian Stokes wrote: >> On 3/19/2019 4:15 PM, Ferruh Yigit wrote: >>> On 2/27/2019 9:45 PM, Ian Stokes wrote: >>>> From: Stephen Hemminger >>>> >>>> This addresses the usability issue raised by OVS at DPDK Userspace >>>> summit. It adds general min/max mtu into device info. For compatiablity, >>>> and to save space, it fits in a hole in existing structure. >>>> >>>> The initial version sets max mtu to normal Ethernet, it is up to >>>> PMD to set larger value if it supports Jumbo frames. >>>> >>>> Also remove the deprecation notice introduced in 18.11 regarding this >>>> change and bump ethdev ABI version. >>>> >>>> Signed-off-by: Stephen Hemminger >>>> Signed-off-by: Ian Stokes >>>> Acked-by: Andrew Rybchenko >>> >>>> @@ -2524,6 +2524,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) >>>> dev_info->rx_desc_lim = lim; >>>> dev_info->tx_desc_lim = lim; >>>> dev_info->device = dev->device; >>>> + dev_info->min_mtu = ETHER_MIN_MTU; >>>> + dev_info->max_mtu = UINT16_MAX; >>> >>> Not only mtu but do you think should we document in 'rte_eth_dev_info_get()' >>> doxygen documentation, the default values that API sets? >>> >> >> Sure, that would be useful, I can include it in the v2 of this patch. >> What would you document the values under? They are not @params and not >> @return, is there a particular label/format that should be used for >> values set within a function? > > In the description paragraph of the function perhaps? I am not aware of a label > for this. > Perfect, thanks for the clarification. Ian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 86350A00E6 for ; Thu, 21 Mar 2019 15:59:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDB8A1B4FF; Thu, 21 Mar 2019 15:59:35 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 822745424 for ; Thu, 21 Mar 2019 15:59:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2019 07:59:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,253,1549958400"; d="scan'208";a="309156285" Received: from istokes-mobl1.ger.corp.intel.com (HELO [10.252.18.62]) ([10.252.18.62]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2019 07:59:32 -0700 To: Ferruh Yigit , dev@dpdk.org Cc: stephen@networkplumber.org References: <1551303948-19746-1-git-send-email-ian.stokes@intel.com> <1551303948-19746-2-git-send-email-ian.stokes@intel.com> <5ebcac70-5581-163d-6a13-163d6684eb5e@intel.com> From: Ian Stokes Message-ID: <712baf16-d144-1866-7623-b9b5720025db@intel.com> Date: Thu, 21 Mar 2019 14:59:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <5ebcac70-5581-163d-6a13-163d6684eb5e@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/6] ethdev: add min/max MTU to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321145931.x4uIoWmoz9Ipw9lVL7iU2ZGv1kj8YGhtyHL-yPZAs-g@z> On 3/21/2019 2:06 PM, Ferruh Yigit wrote: > On 3/21/2019 12:50 PM, Ian Stokes wrote: >> On 3/19/2019 4:15 PM, Ferruh Yigit wrote: >>> On 2/27/2019 9:45 PM, Ian Stokes wrote: >>>> From: Stephen Hemminger >>>> >>>> This addresses the usability issue raised by OVS at DPDK Userspace >>>> summit. It adds general min/max mtu into device info. For compatiablity, >>>> and to save space, it fits in a hole in existing structure. >>>> >>>> The initial version sets max mtu to normal Ethernet, it is up to >>>> PMD to set larger value if it supports Jumbo frames. >>>> >>>> Also remove the deprecation notice introduced in 18.11 regarding this >>>> change and bump ethdev ABI version. >>>> >>>> Signed-off-by: Stephen Hemminger >>>> Signed-off-by: Ian Stokes >>>> Acked-by: Andrew Rybchenko >>> >>>> @@ -2524,6 +2524,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) >>>> dev_info->rx_desc_lim = lim; >>>> dev_info->tx_desc_lim = lim; >>>> dev_info->device = dev->device; >>>> + dev_info->min_mtu = ETHER_MIN_MTU; >>>> + dev_info->max_mtu = UINT16_MAX; >>> >>> Not only mtu but do you think should we document in 'rte_eth_dev_info_get()' >>> doxygen documentation, the default values that API sets? >>> >> >> Sure, that would be useful, I can include it in the v2 of this patch. >> What would you document the values under? They are not @params and not >> @return, is there a particular label/format that should be used for >> values set within a function? > > In the description paragraph of the function perhaps? I am not aware of a label > for this. > Perfect, thanks for the clarification. Ian