From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 2AF0356B7 for ; Wed, 27 Jul 2016 12:42:57 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id o80so55776106wme.1 for ; Wed, 27 Jul 2016 03:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=uAo9RdD6l/SnEfxdO6C5YF+GEmPt89RidR7uZpl1yCE=; b=af49Pv5Uu8z/MZvrTs9a04YXpr/fJpt1XgpYmWITEylLSuJsyB//HjQI28iR4IoKO3 YUyEoI0sIyxgeFGjDQFjl2xKQ7u8btTOlaNLLBV/aUIwHjRXumi82ck7kA7Z3uFXvAqn 6prKK/N+6z+UcXwjXYyynybCVcmeHjVPfe7wFNvOZoJ/VY8w1Dhaa7PxFT4+RiqvYuho 4vuduFWBwtyaBlN71ZiqfnKRprKsNp9KbKqMGl/IE/Or5lpCE0G4HOJIwbKSUK8RgiLg G+TmSg1IRkN+Zx6QxE++eG4knmAh71J62q2FHb9IWLNVJpQO+1LqeoNKPX98F6uCvHRq fOkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=uAo9RdD6l/SnEfxdO6C5YF+GEmPt89RidR7uZpl1yCE=; b=jEgfP2Balq7EMDnMGrNLSZ6WcVz1Vlk5HKNV6P4pfu7DgwQIXV/Dd8R4uL78gaRTDX N5XkiyzT70JhqQNHAHvG4w6dsW+KlI8A1cBrKMekQB6tRMqgbPAztD7LYgXCxQnoybcQ xwkAmolrShDJC/0bpXLBfUM9/UmObe+n/Fn2IDK71Iev8D2ptSTzOHJ2YAoXfUvKLqOL 4A2lNgE1xVHPshEewMUZbi/QaIGMOmiXbNov/f2T/ds5VCbVrNtpv76O4UWX6d4a9llb cF3EdjI368IUczN/O3hVfc4a0h6kT5bJdcpcZJHVjCr+zf7LrvjampXsXpRQuLVBmdBF +u+g== X-Gm-Message-State: AEkoouvW/IfpfzNphoyhv3Zffdibs5XCSW7oHaV2QiveghXUCHOy94DVwgRUtIC9x9YutGQl X-Received: by 10.194.192.195 with SMTP id hi3mr26057308wjc.108.1469616176802; Wed, 27 Jul 2016 03:42:56 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i3sm5698115wjd.31.2016.07.27.03.42.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jul 2016 03:42:56 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , "Zhang, Roy Fan" Cc: dev@dpdk.org, Panu Matilainen , "Singh, Jasvinder" Date: Wed, 27 Jul 2016 12:42:55 +0200 Message-ID: <7134797.PeUvHm5xl4@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A3BBB9@IRSMSX108.ger.corp.intel.com> References: <1463404710-25146-1-git-send-email-roy.fan.zhang@intel.com> <1463667515-11766-1-git-send-email-roy.fan.zhang@intel.com> <3EB4FA525960D640B5BDFFD6A3D8912647A3BBB9@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change of struct rte_port_source_params and rte_port_sink_params X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 10:42:57 -0000 2016-07-27 10:08, Dumitrescu, Cristian: > As Thomas mentioned, today is probably the last day to discuss ABI changes. This one is pretty small and straightforward, any issues with it? > > Panu had a concern that the change from "char *" to "const char *" is too small to be regarded as ABI breakage and we should simply go ahead and do it. My conservative proposal was to put a notice anyway. > > Nonetheless, what I would like to get from Thomas and Panu is a path forward for this now: > a) If we agree to consider this an ABI change, please merge the notice for 16.7; Panu was noticing 3 things (and I agree with them): - it is an API change - they can be grouped in only one list item - it is better to wait having more changes to break an API About the third point, in this specific case, I think it is acceptable because: - it should not break the ABI - the impact of the API change is really small - I'm not sure the packet framework should be considered as a DPDK API. > b) If we agree this is too small for an ABI change, please let us agree now > to accept our quick patch for 16.11 for this change. For an API deprecation notice (reworded), Acked-by: Thomas Monjalon > > -----Original Message----- > > The ABI changes are planned for rte_port_source_params and > > rte_port_sink_params, which will be supported from release 16.11. Here > > announces that ABI changes in detail. > > > > Signed-off-by: Fan Zhang > > Acked-by: Cristian Dumitrescu > > --- > > +* ABI will change for rte_port_source_params struct. The member > > file_name > > + data type will be changed from char * to const char *. This change targets > > + release 16.11 > > + > > +* ABI will change for rte_port_sink_params struct. The member file_name > > + data type will be changed from char * to const char *. This change targets > > + release 16.11