From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A936A054A; Thu, 18 Feb 2021 21:38:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DC3740040; Thu, 18 Feb 2021 21:38:03 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 3F2F64003D for ; Thu, 18 Feb 2021 21:38:02 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6288C5C004F; Thu, 18 Feb 2021 15:38:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 18 Feb 2021 15:38:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= /hdLJIJlrTDqwYtwBeJ+8RSd30nLT6GMO8jCDHe2bEE=; b=cqk3IFNjI+feGiiu pfSmLEZ8WDRrjdVr92SOp+rRrkcGiNdvo7VKNmzeKjelxgEeoSjfXE/XeqZcQkyJ RYssOhDnmmJSjMNFz1J9ZWL8dii6l+IxQup4zo3YxqfhiOgg1CHnp9oMRzeArsUD eXwVxgUATaYOL7umRetomLX43ilMqGuYNzzDN8q6oNJ96FkzG+prQtg5wtgU+1HC CJV3ayx7M+a/bRu4ufatRZRZNhBumRkMPzqrKdQAtSU3Jsp9NBS+cPh9UQRr8lky Rg0QUqe7mG2T0CkCIXOfu3mpEisRg1Rk41Qa3UaGv8fsZ2j3Vfqs1z2S7GCWNpkG MjPiHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/hdLJIJlrTDqwYtwBeJ+8RSd30nLT6GMO8jCDHe2b EE=; b=eeuXeZZI6svSlZQNcm/odu7WphFVlXJisQj1dhiImkztD5xe4yfvIcQxY Cu1IdQuCNnUit3LhdF5pET7ADRj0gyBYx5mRKHfRGR7npOD3iS3k5bHCWQPv/pRp 5PwXxJ53PectcTujmCnafIFICD8/EfUe18MdA0T0thH+iGCS0JSP7Ogc6DzZqis3 bTrCPOh6wa3ccsGYPfBn8gqPUSG+F4e5CouGP+SQ3NaYRUUTczjf7WVU1zXTVrAD YjrvH2+bhXCTqaO3KyhVu5gbCqzaOIenAUkYiEuiczMWGgCrKvXNPSskCM4F3uJA jDQ8/nUk8piE2MXEp+Bz3e63tUOdg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeeggddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A1A6A108005F; Thu, 18 Feb 2021 15:37:59 -0500 (EST) From: Thomas Monjalon To: nipun.gupta@nxp.com, Ferruh Yigit Cc: dev@dpdk.org, arybchenko@solarflare.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, rohit.raj@nxp.com, jerinjacobk@gmail.com, stephen@networkplumber.org, asafp@nvidia.com Date: Thu, 18 Feb 2021 21:37:57 +0100 Message-ID: <7134832.kB0gn7W8D5@thomas> In-Reply-To: <4c3aeb4a-262e-6959-25cc-320bfa490774@intel.com> References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201015132343.4050-1-nipun.gupta@nxp.com> <4c3aeb4a-262e-6959-25cc-320bfa490774@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/02/2021 21:32, Ferruh Yigit: > On 10/15/2020 2:23 PM, nipun.gupta@nxp.com wrote: > > From: Nipun Gupta > > > > This change adds a Rx offload capability and configuration to > > enable hardware to drop the packets in case of any error in the > > packets such as L3 checksum error or L4 checksum. > > > > Signed-off-by: Nipun Gupta > > Signed-off-by: Rohit Raj > > Reviewed-by: Asaf Penso > > --- > > This feature touches many main parts, > - new config item for 'rte_eth_dev_configure()' > - a new offload flag > - new capability reporting for 'rte_eth_dev_info_get()' > > The feature doesn't look very mainstream to touch all these main parts and add > complexity to them, which will affect almost all users. > > And has some inconsistencies, like configuration is done via config struct, but > capability is returned as bit-wise. > Or I think config option taken into account only if offload is requested has a > chance to confuse people in both app and driver end. > > What do you think having two specific APIs to get_capabilities and set drop config? > The responsibility of those APIs will be clear and narrowed down, which makes it > harder to make it wrong. I agree. In general, it is better adding new functions instead of adding everything in rte_eth_dev_configure().