* Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls
@ 2017-12-12 1:00 Prashant Bhole
2018-01-15 11:11 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Prashant Bhole @ 2017-12-12 1:00 UTC (permalink / raw)
To: 'Ferruh Yigit'; +Cc: dev, 'Pablo de Lara'
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>
> On 12/10/2017 11:31 PM, Prashant Bhole wrote:
> > Removed rte_eth_dev_info_get() calls and declaration of struct
> > rte_eth_dev_info where info is not used anymore
> >
> > Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
>
> At any point in the history were they used? If so, can you please add the commit
> making them unnecessary with "Fixes" tag?
Ferruh,
Thanks for reviewing. Adding tag in reply. Let me know if v2 needed with the tag.
Fixes: 81f7ecd934372fc9f592d1322f8eff86350fa4f5
-Prashant
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls
2017-12-12 1:00 [dpdk-dev] [PATCH] examples: remove unnecessary function calls Prashant Bhole
@ 2018-01-15 11:11 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-01-15 11:11 UTC (permalink / raw)
To: Prashant Bhole; +Cc: dev, 'Ferruh Yigit', 'Pablo de Lara'
12/12/2017 02:00, Prashant Bhole:
>
> > -----Original Message-----
> > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> >
> > On 12/10/2017 11:31 PM, Prashant Bhole wrote:
> > > Removed rte_eth_dev_info_get() calls and declaration of struct
> > > rte_eth_dev_info where info is not used anymore
> > >
> > > Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> >
> > At any point in the history were they used? If so, can you please add the commit
> > making them unnecessary with "Fixes" tag?
>
> Ferruh,
> Thanks for reviewing. Adding tag in reply. Let me know if v2 needed with the tag.
>
> Fixes: 81f7ecd934372fc9f592d1322f8eff86350fa4f5
Prashant, this is not the commit making them unnecessary.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls
2017-12-11 18:12 ` Ferruh Yigit
@ 2018-01-15 11:14 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-01-15 11:14 UTC (permalink / raw)
To: Prashant Bhole; +Cc: dev, Ferruh Yigit, Pablo de Lara
11/12/2017 19:12, Ferruh Yigit:
> On 12/10/2017 11:31 PM, Prashant Bhole wrote:
> > Removed rte_eth_dev_info_get() calls and declaration of struct rte_eth_dev_info
> > where info is not used anymore
> >
> > Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> At any point in the history were they used? If so, can you please add the commit
> making them unnecessary with "Fixes" tag?
Maybe some were used. The first one I've checked was never used.
Not worth spending time on it in my opinion.
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls
2017-12-11 7:31 Prashant Bhole
@ 2017-12-11 18:12 ` Ferruh Yigit
2018-01-15 11:14 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2017-12-11 18:12 UTC (permalink / raw)
To: Prashant Bhole, Pablo de Lara; +Cc: dev
On 12/10/2017 11:31 PM, Prashant Bhole wrote:
> Removed rte_eth_dev_info_get() calls and declaration of struct rte_eth_dev_info
> where info is not used anymore
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
At any point in the history were they used? If so, can you please add the commit
making them unnecessary with "Fixes" tag?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] examples: remove unnecessary function calls
@ 2017-12-11 7:31 Prashant Bhole
2017-12-11 18:12 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Prashant Bhole @ 2017-12-11 7:31 UTC (permalink / raw)
To: Pablo de Lara; +Cc: Prashant Bhole, dev
Removed rte_eth_dev_info_get() calls and declaration of struct rte_eth_dev_info
where info is not used anymore
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
examples/l2fwd-jobstats/main.c | 3 ---
examples/l2fwd-keepalive/main.c | 3 ---
examples/l2fwd/main.c | 3 ---
examples/link_status_interrupt/main.c | 3 ---
examples/multi_process/l2fwd_fork/main.c | 3 ---
5 files changed, 15 deletions(-)
diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c
index 485370de6..1a8346f5d 100644
--- a/examples/l2fwd-jobstats/main.c
+++ b/examples/l2fwd-jobstats/main.c
@@ -769,7 +769,6 @@ int
main(int argc, char **argv)
{
struct lcore_queue_conf *qconf;
- struct rte_eth_dev_info dev_info;
unsigned lcore_id, rx_lcore_id;
unsigned nb_ports_in_mask = 0;
int ret;
@@ -827,8 +826,6 @@ main(int argc, char **argv)
last_port = portid;
nb_ports_in_mask++;
-
- rte_eth_dev_info_get(portid, &dev_info);
}
if (nb_ports_in_mask % 2) {
printf("Notice: odd number of ports in portmask.\n");
diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c
index 358ca5ec7..745ddc1a6 100644
--- a/examples/l2fwd-keepalive/main.c
+++ b/examples/l2fwd-keepalive/main.c
@@ -556,7 +556,6 @@ int
main(int argc, char **argv)
{
struct lcore_queue_conf *qconf;
- struct rte_eth_dev_info dev_info;
int ret;
uint16_t nb_ports;
uint16_t nb_ports_available;
@@ -618,8 +617,6 @@ main(int argc, char **argv)
last_port = portid;
nb_ports_in_mask++;
-
- rte_eth_dev_info_get(portid, &dev_info);
}
if (nb_ports_in_mask % 2) {
printf("Notice: odd number of ports in portmask.\n");
diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
index e89e2e1bf..f7b364fb0 100644
--- a/examples/l2fwd/main.c
+++ b/examples/l2fwd/main.c
@@ -549,7 +549,6 @@ int
main(int argc, char **argv)
{
struct lcore_queue_conf *qconf;
- struct rte_eth_dev_info dev_info;
int ret;
uint16_t nb_ports;
uint16_t nb_ports_available;
@@ -610,8 +609,6 @@ main(int argc, char **argv)
last_port = portid;
nb_ports_in_mask++;
-
- rte_eth_dev_info_get(portid, &dev_info);
}
if (nb_ports_in_mask % 2) {
printf("Notice: odd number of ports in portmask.\n");
diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c
index bc47dcce3..8fa5d59fa 100644
--- a/examples/link_status_interrupt/main.c
+++ b/examples/link_status_interrupt/main.c
@@ -549,7 +549,6 @@ int
main(int argc, char **argv)
{
struct lcore_queue_conf *qconf;
- struct rte_eth_dev_info dev_info;
int ret;
uint16_t nb_ports;
uint16_t portid, portid_last = 0;
@@ -596,8 +595,6 @@ main(int argc, char **argv)
portid_last = portid;
nb_ports_in_mask++;
-
- rte_eth_dev_info_get(portid, &dev_info);
}
if (nb_ports_in_mask < 2 || nb_ports_in_mask % 2)
rte_exit(EXIT_FAILURE, "Current enabled port number is %u, "
diff --git a/examples/multi_process/l2fwd_fork/main.c b/examples/multi_process/l2fwd_fork/main.c
index deace2739..608dd5f83 100644
--- a/examples/multi_process/l2fwd_fork/main.c
+++ b/examples/multi_process/l2fwd_fork/main.c
@@ -927,7 +927,6 @@ int
main(int argc, char **argv)
{
struct lcore_queue_conf *qconf;
- struct rte_eth_dev_info dev_info;
int ret;
uint16_t nb_ports;
uint16_t nb_ports_available;
@@ -1015,8 +1014,6 @@ main(int argc, char **argv)
last_port = portid;
nb_ports_in_mask++;
-
- rte_eth_dev_info_get(portid, &dev_info);
}
if (nb_ports_in_mask % 2) {
printf("Notice: odd number of ports in portmask.\n");
--
2.13.6
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-15 11:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 1:00 [dpdk-dev] [PATCH] examples: remove unnecessary function calls Prashant Bhole
2018-01-15 11:11 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 7:31 Prashant Bhole
2017-12-11 18:12 ` Ferruh Yigit
2018-01-15 11:14 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).