From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3F7242DCC; Wed, 5 Jul 2023 10:07:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9703440ED8; Wed, 5 Jul 2023 10:07:55 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2083.outbound.protection.outlook.com [40.107.100.83]) by mails.dpdk.org (Postfix) with ESMTP id 3B457406BC for ; Wed, 5 Jul 2023 10:07:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DvovYPSuaoWpN+wuEwJxshtUfiKQcc8fB8OBUfLEYpcsXTnXZ/r8x3tBj8ZKtMb7s501zfHTZE00Kr4lZKmwVs/DJo5nEk9OjJkuPE9uUSR/NwhNuxZcaO8WSS4G/6XuRUU/bsj4q68UjDK5pS39ze+u6FYl56kks0GU/TM+sTkw2wZN9Py9T5pAm7OrKc/QTob5A9/BOYPuaBZw+VejGJw7SotsR5aI1MBgdtdJHAsHRGhXGZUErduTeuA/1F3B1XW/SvsrGw+0MzoqfdM6gUJ2qEWN/eR7XRuJYzcnvAXvllzJvwFZ7ebNYcqSymuZ1M013/95PGns7pBLldV3tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jeff23A0cVlojAwCbHk1OXLj88J+Bdb/JOxYUQAHBsA=; b=atICYwcDzDviIOnZIVSxCLFcASPotOsK3jlomYIPd7XLuEay2W9iJdNln+XQyPt5VvFc2pErCrlR8osRPTeV8IvnGgvfoZMFj9Zl20vAvIOdTokDxeHf2O5LdEmYJia6tvrkGj0irmYOY5vn9svlb+EfwLFKXidp9B0PcposeV6M5qXcLYrmW+W5rqUF76/qYdO8V07BFktMrt9SHo17v1rjJ1oqNG5rONYrhgiju/Gy3adaFH2mTtUZoHZ+PHFC7TKyeZ9eehR1R1xbOSjlgBlM0bilBi15ZJCrdIMsl+z1RRhQwxC4EMqL0tzd54fTEZvfId479VJqT1T4YLlmnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jeff23A0cVlojAwCbHk1OXLj88J+Bdb/JOxYUQAHBsA=; b=4pNWnJ2QVJoxSC2LHKbKJEbsXodRoC7HUTnzrEw9LfimeuxVWCThT4KMYo0lriGpUDZFsH4tGWLuTSvMLrnphQ/FZPxKIP8vA5BiAoBGfMAKpo0EWdjeAeOtObJ7FIU7JXY1fATzlJMDEWZ8V7bcoSvWcWP5Zt7Mig6PagqC31M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB8493.namprd12.prod.outlook.com (2603:10b6:208:447::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Wed, 5 Jul 2023 08:07:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.016; Wed, 5 Jul 2023 08:07:51 +0000 Message-ID: <716f8b73-617a-76a9-7898-2072ca980913@amd.com> Date: Wed, 5 Jul 2023 09:07:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port Content-Language: en-US From: Ferruh Yigit To: "lihuisong (C)" , Jie Hai , Aman Singh , Yuying Zhang , Shiyang He , "Jiale, SongX" Cc: dev@dpdk.org, liudongdong3@huawei.com, alialnu@nvidia.com, "Mcnamara, John" , Qi Z Zhang , Thomas Monjalon , David Marchand References: <20230703110232.28494-1-haijie1@huawei.com> <20230704084507.12788-1-haijie1@huawei.com> <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com> <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> In-Reply-To: <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PA7P264CA0124.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:36e::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB8493:EE_ X-MS-Office365-Filtering-Correlation-Id: 274a65a3-1dc6-4b5d-8625-08db7d2eed66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m0LMexkhnQ1+r/7z1KvRrGqW1KWqyw2qYLCg8vkfioHqOAWVcp+eUW4wJlrFhpfyHbXwM2kZXg+3QymohEcUXpUvIzAGWdu4lRiTRyKr75L7VSD7FMw1NjXj9KTgYh1ctOz0y5FXTtRhg5jCleokgDweQ5BuMKVSo9PZr5fCK7dHYggqhWhqhX7Cz98qtd42t4Lt2C9HcK1eIqPimAUwE3jsOezhB7HxBKODphaYA24NgqwFL/6olXCuTUI9SzGWnMe50VSgH8mfdbNN/uxiL9EIB2FUIV8r/OuSe0e2XbeT6PSRmSmwxxCnQLMS9OHSeu6UuJNUAmGU6YwnD/2lZe8evIBuGeNOisC24IhLelCBGz6HaujgZjll1qpqgTS9/5m5rHGJt3BPWNzr8t8fMUpSP/DC9KQApXJx/tnk3JoPtUFBqDaBS9jCfNHwQKubPf3cqNHXVELRUSvm1QioyIDqU+0nSsonfmGEW29JN8DxZTah2w+NNB4zmlJ0oeDVPsFk2k85ol+RdeGDBkZgUMuAHFfXLsGDZYrjMAEjD58mI9hTbp8oW7TRYvJYOMa8eiYIv/LFrIUywtlkFtWu223Gqxpoum+AC6VsmQ2Tg4Vbq/uSEpaB0x3HTGDUOURUtGXvGQSbSemxadFcrhmY7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(451199021)(186003)(7416002)(44832011)(31686004)(66556008)(4326008)(66946007)(316002)(478600001)(66476007)(36756003)(8676002)(8936002)(5660300002)(2906002)(86362001)(41300700001)(31696002)(6512007)(110136005)(54906003)(6666004)(6486002)(38100700002)(53546011)(6506007)(26005)(2616005)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGZsa2V6UzUrVTF3K2ZTWjI5ck5HZnkycDRqU2dvSjVTMG93TmpWVk5FUzBw?= =?utf-8?B?M29wZHpxZytTY05PRHVEdjVlNU4xZHVtQ05IVXRKeC9Xd0h0NzBFdzUzNmZ5?= =?utf-8?B?THlCS3k1bUY1ek5OQnJUTTZFamVObGRXUzZ1ZFpFM04xTm9mVDNRVEV1NkJM?= =?utf-8?B?REt4YWhKWlJyVkdkeTJXRHRkWCtLZWE4Y2dOMTBrMm1JZkdDbTZPeVJVRjJk?= =?utf-8?B?QVZpd0w1QXAvUmlWaytlbWRUVnQ1cjBPQzQ5aEpycFFyc1l5ZUc1RHdNb3Y0?= =?utf-8?B?T1UwU0hCa0Q3SG1FSzlRS285T29MNHA3SmFTM2R5eDRzOERITjQ2NnNFdHBK?= =?utf-8?B?Nkk1OFhuYUhiTHp0Zm9RVTF2SUlUdTZ6RTJTdjFYd0pwWTVEVVpVWks0K1lm?= =?utf-8?B?dHIyQ3ZGaXd3VTRBTjVCcEo0WlVvTUhzM3dqalNuQkp1WG1NeHRJNjVoaWNk?= =?utf-8?B?Mjg4TXJEdW5oVXlBSU5PVjhhSTF2M0dQQVAvUytZc0ZRdlZzSEtjU0p3UC9J?= =?utf-8?B?bm5vTTh0VUtsRHpTalRVYWpSNE5kdGRGOXR4b0FPVUlOSTd5Rkh5aUJFZi9r?= =?utf-8?B?Y3JsVUFnM05FV2FlZmdEaDZGR0ZYaEZCdllSQzJYTWg5SnZBUWZ2VFk1eTFw?= =?utf-8?B?aFMzaFliRDkraEZxQmJ1Q3JtdU5NRGp0MlltR1dlS1A2SWd6bkpnVFFMU3BE?= =?utf-8?B?TklvYmVYRU1IMjZHU3RNWXNHUFc1eEowakM5MndqZlFqL3Q1Q2trTHJJcFRF?= =?utf-8?B?ZmRnN2d5ckpGUlY0TjQ4czJRU3lQZTRtQVgzK1hMWG9QOHM3M1lWcDFEcjhI?= =?utf-8?B?bjU0MlJveWMyaG12UnZUWlZKbFg4RjN1M3F3YStFazdPcnMrUE1iWlFsYStL?= =?utf-8?B?NDdtVldYb0ZLZzc0VzdkOHVKajY3N2xUR1pNbWNucTBucUdkbFdmREhkbWdV?= =?utf-8?B?eXpNZE42RWs4VTdhMVJEMHhTM282aldMOU4vU24wcSszRnZKd2pIMmExSVN4?= =?utf-8?B?UXJNZ3FRTGNUYlN2UGZrMmtNblBEQXBuVHdwYmlERW5lOC94NWN3V3NpQU9G?= =?utf-8?B?T1Y3aXRWV1dQMUxseUV2UTQ4bUtEbHZvNHNQMmp5SFRmYjliUHQ0QWl6MUVj?= =?utf-8?B?RWJMT0puTE1oeUtRc2lkdFB2ZGVidjVpR21FUHFydFYybEo3ajFtQ1ZNM1E3?= =?utf-8?B?WFpRR1ZveUJmaXQ1QjdGTXdyTTUrK2UxRU14NXliRmtZTE5RTlBCemI5Ujhk?= =?utf-8?B?UnRscUNQS1RZUW1QaVpFUkFLZ0xNU1JSZ3JwT2k4c0pUa2xqZ3ZDdkNaeWxP?= =?utf-8?B?MlFia3ZZNzV1c2kxY3dFRk9nZU9UL29UZjFoR3VHbEltN0pKTDJWam50OWFF?= =?utf-8?B?cHFiV0JlRmFxYmhEeDlrWWhmQWFEUUZTd3lhdUdnMzlsSHBwS3BGNDFoL0Mw?= =?utf-8?B?elNOQ3MyRHpQdG9jekVNLzFDa0pyTElkRnB1RVBERWNLWCtnREdEVm9hcEpD?= =?utf-8?B?N1lobFFPUGs1cHp2Tzd6WTJpRUFmcVREL0VOSDRZTXowRCtSdlVZMUFmYTht?= =?utf-8?B?YzUzZlRGUXdFQ0ZiZnFXSEFKU1NUV1hPNjZVaDJ5Z2xIU0FRZVBKUTA5cUVs?= =?utf-8?B?aEdtY0lQWXlsd0s5NU1EZnNKd09TWkxGL0ZIWDF6cjVVSDlYcU16MVpVOHRL?= =?utf-8?B?L3dJNkZGbkdVUGx0OGovaVp4a0RxemVOdnE0ZEUvVlI2Z3pvQTdDNXN3OHQw?= =?utf-8?B?L0tYay8vK3pEdjhuTVRKMURpM2VEcldwb1lWTngxZFBOeUExeUhEVHhTb3A2?= =?utf-8?B?VlNHTjNROXAxM3k0Y2QwUXlIRHdOdHkwbVRxTVBWSG5QVmR5WURyYkprd1Bj?= =?utf-8?B?TWtqaDh4L1J1dUwvWFdDdEJpRGUrbmkwa0VrMGdqU3piamxKSTdNQTFxbDJr?= =?utf-8?B?TFFNOC9ZRE5hVkVSTzh2T21tL0tmQlBNZHZPckd3OGk4djNlcktOZ2lkNlJi?= =?utf-8?B?dWl0RXJqOUpwNHB4Slp0aUt1SHQ4bGMrb0Z0SXdVTE9WbURqVGFEZVZDbGJK?= =?utf-8?B?cTNvejRDYnhOWkJFU01yNFZvSGxjMjVRSUNZU2RhL2pPczNvU3hISTB3VThM?= =?utf-8?Q?bNc7ygA0CcG6lvjcUitFVLBco?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 274a65a3-1dc6-4b5d-8625-08db7d2eed66 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 08:07:51.0295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a1qlpEd45u0JG/FUnXCCBrjfrljtK8Qu88t+0g7aEIqwQ4CoCLarfKdTNYE9vV0X X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8493 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/5/2023 9:02 AM, Ferruh Yigit wrote: > On 7/5/2023 4:16 AM, lihuisong (C) wrote: >> >> 在 2023/7/4 18:59, Ferruh Yigit 写道: >>> On 7/4/2023 9:45 AM, Jie Hai wrote: >>>> Function update_queue_state updates queue state of all queues >>>> of all ports, using the queue num nb_rxq|nb_txq stored locally >>>> by testpmd. An error on the invalid queue ID occurs if we run >>>> testpmd with two ports and detach-attach one of them and start >>>> the other port first. This is because the attached port has not >>>> been configured and has no queues, which differs from nb_rxq|nb_txq. >>>> The similar error happens in multi-process senoris if secondary >>>> process attaches a port and starts it. >>>> >>>> This patch updates queue state of the specified port, which has >>>> been configured by primary process. As the secondary process >>>> cannot configure the ports, make sure that the secondary process >>>> starts the port only after the primary process has done so. >> Now look good to me. >> Acked-by: Huisong Li >>>> >>>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling >>>> all queues") >>>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet >>>> forwarding") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Jie Hai >>>> >>> The problem description and solution looks reasonable to me, but Intel >>> testing still reporting the issue. >>> >>> There is a chance that the issue Intel side observing is different, >>> waiting for more information from Intel test team. >>> >>> . > > Hi Song, > > As far as I understand this patch works with an update from ixgbevf > driver, can you please confirm? > And can we have the ixgbevf fix soon, to not block the -rc3? > > To record, the problem is testpmd change was to get queue status from ethdev but ixgbe is not setting queue status correctly.