From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A6AE1160 for ; Mon, 15 Oct 2018 12:01:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 468F222012; Mon, 15 Oct 2018 06:01:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 06:01:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=f/xVvPf6KhT5UZfl87KvhIN3XUP7djTcF6x1QTa8i68=; b=Aq6GzzdvHL+d 7/wVTa9boyAZ+5wOFUmwKnsbzGTMyDL+MDkvHBeVRkEGjHnWvIQiuFrNUfBOZpHU GHk6HdKn1GsdZp8Ijc/zXdGn3qz7X88izzKFDcni78auplcmdSripxNIKjmy1uPz 6z7X4g8Zr3n58+RLtyBwN2ZvXIGyqdo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=f/xVvPf6KhT5UZfl87KvhIN3XUP7djTcF6x1QTa8i 68=; b=rvwDHbGhRUt515HU6qj+NKTZ2LHqPQRiQfbjC8MrW6ST7f6TDV+nKHa8K PnLt5QPxTXtHLV8LaTlQZn+GbWaA8k5NQusonA1Qeek/+AiKErys86SHbzyysI78 qdmlsc6V/q/5J0i50lotOTjI6HY8THMlMa5I/KhTKNcF0vo8PFqNFA5FSVixqJs5 c0b5qK65pHOfLq7N93IArOL8iehwKGAC6BH+ozORxP24wAaAh5kjTE7o+//+cqCJ ZVMrWvVtb/JMS64fWKrTqm82el6YHtOdqhd7uhEBN0Tdk05f9Xf5GxEJ2IUt3yZv v9c6BpmkFpTcWi/W+eo9ff/bBBbvQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A42C9E455F; Mon, 15 Oct 2018 06:01:09 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, anatoly.burakov@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com Date: Mon, 15 Oct 2018 12:01:10 +0200 Message-ID: <7174153.WpdsCtqFOP@xps> In-Reply-To: <2017914.N0vOHbfrR3@xps> References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1538635483-92222-4-git-send-email-jia.guo@intel.com> <2017914.N0vOHbfrR3@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/4] pci: add req handler field to generic pci device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 10:01:14 -0000 15/10/2018 11:12, Thomas Monjalon: > 04/10/2018 08:44, Jeff Guo: > > There are some extended interrupt types in vfio pci device except from the > > existing interrupts, such as err and req notifier, they could be useful for > > device error monitoring. And these corresponding interrupt handler is > > different from the other interrupt handler that register in PMDs, so a new > > interrupt handler should be added. This patch will add specific req handler > > in generic pci device. > > > > Signed-off-by: Jeff Guo > > > --- a/drivers/bus/pci/rte_bus_pci.h > > +++ b/drivers/bus/pci/rte_bus_pci.h > > @@ -66,6 +66,7 @@ struct rte_pci_device { > > uint16_t max_vfs; /**< sriov enable if not zero */ > > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > > char name[PCI_PRI_STR_SIZE+1]; /**< PCI location (ASCII) */ > > + struct rte_intr_handle req_notifier_handler;/**< Req notifier handle */ > > We had intr_handle, should we name this one req_notifier_handle? > May we improve the comment to better explain? (and add a space before) On IRC, we agreed on this name/comment: struct rte_intr_handle vfio_req_intr_handle; /**< Handler of VFIO request interrupt */ > Maybe we need to update the comment of the other handle? > struct rte_intr_handle intr_handle; /**< Interrupt handle */ OK to keep this one as-is.