From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E32E45655; Fri, 19 Jul 2024 15:37:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55EAC40E0F; Fri, 19 Jul 2024 15:37:16 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id BDB394026A for ; Fri, 19 Jul 2024 15:37:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 619821042 for ; Fri, 19 Jul 2024 06:37:39 -0700 (PDT) Received: from [10.1.34.187] (e132843.arm.com [10.1.34.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A197E3F762 for ; Fri, 19 Jul 2024 06:37:13 -0700 (PDT) Message-ID: <7178392f-bb8a-4ea0-b389-ab28003c8ac3@foss.arm.com> Date: Fri, 19 Jul 2024 14:37:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] doc: remove use of -n 4 option in documentation To: dev@dpdk.org References: <20240718184326.21375-1-stephen@networkplumber.org> <20240718184326.21375-2-stephen@networkplumber.org> Content-Language: en-GB From: Jack Bond-Preston In-Reply-To: <20240718184326.21375-2-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/07/2024 19:43, Stephen Hemminger wrote: > Many places in the documentation are using -n 4 to set > the number of memory channels. This should not be recommended > since it is not always right and the default should be used > instead. > > Signed-off-by: Stephen Hemminger Acked-by: Jack Bond-Preston > diff --git a/doc/guides/linux_gsg/build_sample_apps.rst b/doc/guides/linux_gsg/build_sample_apps.rst > index 4f99617233..f07e7a4fb5 100644 > --- a/doc/guides/linux_gsg/build_sample_apps.rst > +++ b/doc/guides/linux_gsg/build_sample_apps.rst > @@ -114,7 +114,7 @@ Copy·the·DPDK·application·binary·to·your·target,·then·run·the·application·as·fol > (assuming·the·platform·has·four·memory·channels·per·processor·socket, > and·that·cores·0-3·are·present·and·are·to·be·used·for·running·the·application):: > > -····./dpdk-helloworld·-l·0-3·-n·4 > +····./dpdk-helloworld·-l·0-3 The comment above about assuming the platform has four memory channels is still correct I guess (since the default is 4), but it feels out of place now without the -n option specified in the command line. > diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst > index a4c0712bd9..523d2ef718 100644 > --- a/doc/guides/sample_app_ug/link_status_intr.rst > +++ b/doc/guides/sample_app_ug/link_status_intr.rst > @@ -54,7 +54,7 @@ issue·the·command: > > ..·code-block::·console > > -····$·.//examples/dpdk-link_status_interrupt·-l·0-3·-n·4--·-q·8·-p·ffff > +····$·.//examples/dpdk-link_status_interrupt·-l·0-3--·-q·8·-p·ffff Same comment applies here. Also, whilst this patch isn't the cause, should there not be a space before --? > diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst > index e0af729e66..d2ef3636eb 100644 > --- a/doc/guides/sample_app_ug/vm_power_management.rst > +++ b/doc/guides/sample_app_ug/vm_power_management.rst > @@ -279,7 +279,7 @@ cores·0·and·1·on·a·system·with·four·memory·channels,·issue·the·command: > > ..·code-block::·console > > -···.//examples/dpdk-vm_power_mgr·-l·0-1·-n·4 > +···.//examples/dpdk-vm_power_mgr·-l·0-1 Same comment. Should we also remove the note saying "The command line must always have the number of memory channels specified for the processor." from the mempool library programmer's guide?