From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Aman Singh <aman.deep.singh@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net: macro for MAC address print
Date: Thu, 12 Aug 2021 16:59:32 +0100 [thread overview]
Message-ID: <7178a2c1-4da7-7807-8d11-e68373476293@intel.com> (raw)
In-Reply-To: <20210810073541.60975-2-aman.deep.singh@intel.com>
On 8/10/2021 8:35 AM, Aman Singh wrote:
> Added macro to print six bytes of MAC address.
> The MAC addresses will be printed in lower case
> hexdecimal format.
s/hexdecimal/hexadecimal
> In case there is a specific check for upper case
> MAC address, the user may need to make a change in
> such test case after this patch.
>
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
For the patch title we have a convention to start with a word, something like:
"net: add MAC address print format macro"
Except from above issues,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
If you will send a new version to fix above minor issues, please keep the tag.
next prev parent reply other threads:[~2021-08-12 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 7:35 [dpdk-dev] [PATCH v3 0/2] Use macro to print MAC address Aman Singh
2021-08-10 7:35 ` [dpdk-dev] [PATCH v3 1/2] net: macro for MAC address print Aman Singh
2021-08-12 15:59 ` Ferruh Yigit [this message]
2021-08-10 7:35 ` [dpdk-dev] [PATCH v3 2/2] net: macro to extract MAC address bytes Aman Singh
2021-08-12 15:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7178a2c1-4da7-7807-8d11-e68373476293@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).