From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, helin.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] kni: fix use of undefined comma variable in makefile
Date: Tue, 07 Jun 2016 10:32:36 +0200 [thread overview]
Message-ID: <7183463.xOdGnD08m0@xps13> (raw)
In-Reply-To: <574D933C.2080507@intel.com>
2016-05-31 14:35, Ferruh Yigit:
> On 5/30/2016 5:46 PM, Ferruh Yigit wrote:
> > On 5/30/2016 5:21 PM, Olivier Matz wrote:
> >> Hi Ferruh,
> >>
> >> On 05/30/2016 05:49 PM, Ferruh Yigit wrote:
> >>> On 5/30/2016 12:56 PM, Olivier Matz wrote:
> >>>> The $(comma) variable is not defined in this Makefile, nor in
> >>>> any included Makefile. Seen while doing a "make clean" on ubuntu:
> >>>>
> >>>> $ make clean
> >>>> == Clean lib
> >>>> == Clean lib/librte_compat
> >>>> == Clean lib/librte_eal
> >>>> == Clean lib/librte_eal/common
> >>>> == Clean lib/librte_eal/linuxapp
> >>>> == Clean lib/librte_eal/linuxapp/eal
> >>>> == Clean lib/librte_eal/linuxapp/igb_uio
> >>>> == Clean lib/librte_eal/linuxapp/kni
> >>>> tr: missing operand after ‘.-’
> >>>> Two strings must be given when translating.
> >>>> Try 'tr --help' for more information.
>
> Error is related to the kernel version, in second call "comma"
> definition comes from kernel makefiles.
>
> Following commit causes comma to be defined:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=371fdc77af44f4cb32475fd499e1d912ccc30890
>
> So this is valid issue for old kernels, and using "," directly looks OK.
>
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-06-07 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 11:56 Olivier Matz
2016-05-30 15:49 ` Ferruh Yigit
2016-05-30 16:21 ` Olivier Matz
2016-05-30 16:46 ` Ferruh Yigit
2016-05-31 13:35 ` Ferruh Yigit
2016-05-31 19:12 ` Olivier MATZ
2016-06-07 8:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7183463.xOdGnD08m0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).