From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0BDF995D3 for ; Tue, 7 Jun 2016 10:32:38 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id n184so125645714wmn.1 for ; Tue, 07 Jun 2016 01:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=xNrtQk4tKEezqNaj6WpsVHL2M8hMrAOcFXW3tRC0MDk=; b=JktSvLUGuEbLRSCfkNUFi+Uy5MH/dghvZ/2uJl790yr2cfVUxMyGw60UcJrTToEWTN e1Zd8yCBIyqla2EHTsMylKsmuf2pxlU0RI4Mm9TOgYNmn2nTTP/xGp79jkDMnWEF7itG U2lsexSjgqSvR/o00EwPy/btNfG3SKcgd34jdKLk+mCFbioJ6PSlCfk/EVe4dT+kfEOG sLoNaLTTJkE6bS+TMvHp+UjVLW4zvTQYmvtT4m3JieTGgihMqyGtrwWeqalC3wfEq/te VuylwYuLvmJS0cnv9QAOymOgj+hf5UqHdlpxVyFfgveADDe+KyXCAOvextzODxBfLj+e xSWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=xNrtQk4tKEezqNaj6WpsVHL2M8hMrAOcFXW3tRC0MDk=; b=Qu5ZNLuC39al65H4b54kbYHD1EJAabefHg6Xx7mWpdpwsj64f746sZ7w2I28OFrG5i Z7pYEDNttQjopBE0STTbjZPOdawaL/VHlKJBbJrt1OJ7yyoK/z9k7lwrJeiktzeGQMFx iVrt9iAGZee0B0cdf3V/lkzFe3y1NN1Zkc8va5Lz5vQG181zvcy8K0GzTqZErFIRCpOe 1RqmgrAkiB7/1jj8Ar9rq4k8BUty7nMFcnIv0eYlwtDUZAHQm5wyTaONdJeZ8ehm/tLy l7YCpk5/8YY8+HqNT0KIJykeizs/7zLq2BQSV1EcI/Uhj7EmjludT4b+yPvgVVO8FvF6 hI0g== X-Gm-Message-State: ALyK8tJNPNSRS7BinvWjx37dECqyURfFiKBp58FN2+sPqK9qTqpvCk9AW9G11n6hlzFPn80N X-Received: by 10.28.52.193 with SMTP id b184mr1335940wma.38.1465288357791; Tue, 07 Jun 2016 01:32:37 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id lf7sm24220645wjb.23.2016.06.07.01.32.36 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Jun 2016 01:32:37 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: Ferruh Yigit , dev@dpdk.org, helin.zhang@intel.com Date: Tue, 07 Jun 2016 10:32:36 +0200 Message-ID: <7183463.xOdGnD08m0@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <574D933C.2080507@intel.com> References: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com> <574C6E71.3090601@intel.com> <574D933C.2080507@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH] kni: fix use of undefined comma variable in makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 08:32:38 -0000 2016-05-31 14:35, Ferruh Yigit: > On 5/30/2016 5:46 PM, Ferruh Yigit wrote: > > On 5/30/2016 5:21 PM, Olivier Matz wrote: > >> Hi Ferruh, > >> > >> On 05/30/2016 05:49 PM, Ferruh Yigit wrote: > >>> On 5/30/2016 12:56 PM, Olivier Matz wrote: > >>>> The $(comma) variable is not defined in this Makefile, nor in > >>>> any included Makefile. Seen while doing a "make clean" on ubuntu= : > >>>> > >>>> $ make clean > >>>> =3D=3D Clean lib > >>>> =3D=3D Clean lib/librte_compat > >>>> =3D=3D Clean lib/librte_eal > >>>> =3D=3D Clean lib/librte_eal/common > >>>> =3D=3D Clean lib/librte_eal/linuxapp > >>>> =3D=3D Clean lib/librte_eal/linuxapp/eal > >>>> =3D=3D Clean lib/librte_eal/linuxapp/igb_uio > >>>> =3D=3D Clean lib/librte_eal/linuxapp/kni > >>>> tr: missing operand after =E2=80=98.-=E2=80=99 > >>>> Two strings must be given when translating. > >>>> Try 'tr --help' for more information. >=20 > Error is related to the kernel version, in second call "comma" > definition comes from kernel makefiles. >=20 > Following commit causes comma to be defined: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi= t/?id=3D371fdc77af44f4cb32475fd499e1d912ccc30890 >=20 > So this is valid issue for old kernels, and using "," directly looks = OK. >=20 > > Signed-off-by: Olivier Matz > Acked-by Ferruh Yigit Applied, thanks