From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 76FF641BAB;
	Thu,  2 Feb 2023 10:55:52 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5EDF6406A2;
	Thu,  2 Feb 2023 10:55:52 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 4CF5040689
 for <dev@dpdk.org>; Thu,  2 Feb 2023 10:55:51 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 85BE35D;
 Thu,  2 Feb 2023 12:55:50 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 85BE35D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1675331750;
 bh=AwuFnjX/UQfzbzS/Xv9qz7430NnyBy1HBa1jTu5iqRA=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=CK4cFPZlKATttlsDAGXR50idkdIF2a4DBz6jWielm06WT7cCl5CnZbFuf57y3VKTu
 cL6PhVg3cZrWP2W/Io+2vq1wMPy5lMoZb8F0jhsManAkb4HxSMwGdgVdqbpgQ1RzY9
 hJVolhlvF6c4gtYKZPFPMuFBvBy/cCOzfWkbMG8A=
Message-ID: <7185560d-f881-b2e4-a831-05e62b751a69@oktetlabs.ru>
Date: Thu, 2 Feb 2023 12:55:50 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v5 6/8] ethdev: use ARP protocol struct for flow matching
Content-Language: en-US
To: Ferruh Yigit <ferruh.yigit@amd.com>, Thomas Monjalon
 <thomas@monjalon.net>, Ori Kam <orika@nvidia.com>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
References: <20221025214410.715864-1-thomas@monjalon.net>
 <20230126161904.864517-1-ferruh.yigit@amd.com>
 <20230126161904.864517-7-ferruh.yigit@amd.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20230126161904.864517-7-ferruh.yigit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 1/26/23 19:19, Ferruh Yigit wrote:
> From: Thomas Monjalon <thomas@monjalon.net>
> 
> As announced in the deprecation notice, flow item structures
> should re-use the protocol header definitions from the directory lib/net/.
> 
> The protocol struct is added in an unnamed union, keeping old field names.
> 
> The ARP header struct members are used in testpmd
> instead of the redundant fields in the flow items.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>