From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F60CA0C41; Wed, 15 Sep 2021 16:07:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8E3B4068F; Wed, 15 Sep 2021 16:07:09 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 116AE4014F for ; Wed, 15 Sep 2021 16:07:09 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 04D663200A0B; Wed, 15 Sep 2021 10:07:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 15 Sep 2021 10:07:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= B0cWd/MBRcVUO8HRhIOih0Xv93P4ufeHOW8vBHX0248=; b=QC0x58wn5fL+tUIU uZDyXoq+YSM30hqIqJrIWNGkK2an8PHfGciyMPac/Ww8qUkdNeKg8w48JOFVy1a7 tfLJMJboXHbTXSkE5HVeeLCDE8glto8E0cFFR7Agu7ccYmb1Y7/r1/3P+LdzJ9TW PxKijixtDF727KM6kg+Yjv8dgTlU8UfaoY++eCUc3ByQVGrCaj3vc03wXHr3F9Ik ZIIBwBQe2D40YGYpAwGKHCMpMhH91HNoBx1ZJoqK8ZU0EjtIWUDE0tUtfONJJkWf +oWgvPB3py02oI8FaQp6H+lcH9IvUYnTe3kIVCcecpFhUdpQEuNXE3VDy9BJJNfx qIfj3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=B0cWd/MBRcVUO8HRhIOih0Xv93P4ufeHOW8vBHX02 48=; b=hjhnps7ALKN5eZ6C1o0QNqr9+uXEiIpkArUcig54HjEI4+Ch5s4Lsc3sG JH1rs5UYxizLrI0sDeJjJoAk/lgKDryWEUtiUJxdDGj4DNOo8dBb0sZBBTcRTxqc 45HSLOlpeuqdtHotGSxS0kWmt1XLpZjgtycYOrojkwzPaBsvqWxUoaIakmEYmSgK +eSpLIZsuXCBiYl8DjeTALibnFUisiPIimrUCp/Y2HZvIhnKrb29vm2s+NdOxn1o EBaLPTN4FbcOAy6NuyUoNSJkBk/D+yLcn1c+X16G+VORXx9xHNgFkuCnvkG6HmMF lJvwAfhOSLLU4/7aM9pSfSCORuejQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehuddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Sep 2021 10:07:06 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, juraj.linkes@pantheon.tech, "Nicolau, Radu" Date: Wed, 15 Sep 2021 16:07:04 +0200 Message-ID: <7190342.YE9iyrVemj@thomas> In-Reply-To: <86926243-d64d-9c13-492a-5984f29d43ea@intel.com> References: <20210818134240.480605-1-bruce.richardson@intel.com> <86926243-d64d-9c13-492a-5984f29d43ea@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: fix building when essential drivers in disable list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/09/2021 15:38, Nicolau, Radu: > On 8/18/2021 2:42 PM, Bruce Richardson wrote: > > The PCI and vdev bus drivers cannot be disabled for DPDK builds and > > special logic is put in place to not skip them when they are specified > > in the disable list. This logic is broken though, as the inclusion of > > the driver-specific meson.build file is only included in the "else" leg > > of the condition check. This means that when they are specified as > > disabled the PCI and vdev buses are not disabled, but neither are their > > source files compiled. > > > > Fix this by moving the "subdir()" call into the next "if build" block, > > ensuring that if not disabled the sources are always included. To take > > account of the fact that the subdir call could itself disable the > > driver, we add a break call into the following loop to ensure we quickly > > fall through to the following block which stops processing appropriately > > if the driver is disabled. > > > > Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds") > > Cc: juraj.linkes@pantheon.tech > > > > Signed-off-by: Bruce Richardson > > --- > Tested-by: Radu Nicolau > Acked-by: Radu Nicolau Applied, thanks