From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 9EA34ADC2
 for <dev@dpdk.org>; Fri, 13 Feb 2015 10:20:41 +0100 (CET)
Received: by mail-wg0-f46.google.com with SMTP id a1so15413128wgh.5
 for <dev@dpdk.org>; Fri, 13 Feb 2015 01:20:41 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LhqcNGXcEMBYChPGw/OEEb9JEhzpsR+vGbycnp+Hd4g=;
 b=Q/paj18VIGNaND6sjOF/6pBg19LLDwdIkAJdjG5CUN/N5BOXulooQFt6aBSf4BPVok
 W2QPND9UMx1FbDBfYQDbSrduMXo7wVO9/Fn56BLh5PMzEnrq7Y638IHD3ElhWBviJ3j3
 ekJLFQrUG1L8v2hk9x42jNvGOqCvsK3tlkdlgnwxd6hYE4NrpYRjLehYZn1z/TQDM3Kb
 BW/yRKp9PaWLEBjbUJVLnlQL2rir0BF7pzbievKJuyxwbft8g3gpjO4aTTujzWkLdS3Y
 oaCOZiIvkPZIZsARkwyer7cusHdi/Ff7iAIA5nyRj5Rh4hVt4djL23M9Gif6/0zs+stl
 s07Q==
X-Gm-Message-State: ALoCoQngWJtZEeQaLSORI1N3oj/EUkFbqkQZYyXWsY/FcLYFx6p5tDC7KNl7NbQjrb7ZvAJ8UN14
X-Received: by 10.194.133.101 with SMTP id pb5mr16901966wjb.40.1423819241459; 
 Fri, 13 Feb 2015 01:20:41 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id eg10sm5224905wib.5.2015.02.13.01.20.40
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 13 Feb 2015 01:20:40 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Date: Fri, 13 Feb 2015 10:20:11 +0100
Message-ID: <7191659.yLKdrT87cL@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CE8F2C@SHSMSX101.ccr.corp.intel.com>
References: <1423653001-11660-1-git-send-email-michael.qiu@intel.com>
 <1893948.saDpN2FujX@xps13>
 <533710CFB86FA344BFBF2D6802E60286CE8F2C@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none
	igb_uio driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Feb 2015 09:20:41 -0000

2015-02-13 02:56, Qiu, Michael:
> On 2/13/2015 12:26 AM, Thomas Monjalon wrote:
> > 2015-02-11 21:25, Michael Qiu:
> >> max_vfs will only be created by igb_uio driver, for other
> >> drivers like vfio or pci_uio_generic, max_vfs will miss.
> >>
> >> But sriov_numvfs is not driver related, just get the vf numbers
> >> from that field.
> >>
> >> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > [...]
> >>  	snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);
> >>  	if (!access(filename, F_OK) &&
> >> -	    eal_parse_sysfs_value(filename, &tmp) == 0) {
> >> +	    eal_parse_sysfs_value(filename, &tmp) == 0)
> >>  		dev->max_vfs = (uint16_t)tmp;
> >> +	else {
> >> +		/* for none igb_uio driver, need kernel
> > I think it's a typo. Do you mean "for non igb_uio driver"?
> 
> Hi, Thomas
> 
> Yes, you are right.
> 
> Did I need to send out V3 patch for this typo?

No, thanks. Your agreement is enough. I'll fix it.