From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 37900376D for ; Wed, 15 Jul 2015 08:19:05 +0200 (CEST) Received: by widjy10 with SMTP id jy10so118514415wid.1 for ; Tue, 14 Jul 2015 23:19:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=qpJKa885jA9FolRm74Fu2t02WdF2iI8qit0k482lDVg=; b=e8huQXEw63SGlABdoCgd11f4wma8V6xJ3lBobY5mVF+mr56P20Iyr6BE16YVbpSGGP dNTBJ/NVpUBwwzVWb6QL4BrsIPqVrIPtT9LqWyvD3Mk5ExjzVc2/HLnrFXCY/9wu04xz vPME1hsctAvk30jDdolUF5EdUHlflxK2WCXu5aberBWRh/PCoDW3a1ZsLm3gRjVPF5JW dz4zdEyGp1Byj0MGMQRK1eIo99hflRxk79MkU65+h68tpnEuiDr+cBjn8PcplQtCnrVD ztoiDQJDAOsQyS/VtjUCUKJYh+Sv7Rflc94BOLgSs135QqPIITUGPVoLgNL4FzeRu/3O H33Q== X-Gm-Message-State: ALoCoQnKwzOi4lGd/trhmgI/yWke20ZzYgCtndDnCP9ZVIqQVpZImy/8/Dbt9e4pQyoGGsntwoMY X-Received: by 10.180.73.145 with SMTP id l17mr12995254wiv.39.1436941144273; Tue, 14 Jul 2015 23:19:04 -0700 (PDT) Received: from xps13.localnet (153.16.90.92.rev.sfr.net. [92.90.16.153]) by smtp.gmail.com with ESMTPSA id l6sm24915387wib.18.2015.07.14.23.19.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2015 23:19:03 -0700 (PDT) From: Thomas Monjalon To: Liang-Min Larry Wang Date: Wed, 15 Jul 2015 08:16:06 +0200 Message-ID: <7196644.zbOgvuZnbg@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436840331-13112-2-git-send-email-liang-min.wang@intel.com> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1436840331-13112-1-git-send-email-liang-min.wang@intel.com> <1436840331-13112-2-git-send-email-liang-min.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 06:19:05 -0000 2015-07-13 22:18, Liang-Min Larry Wang: > --- a/lib/librte_ether/Makefile > +++ b/lib/librte_ether/Makefile > @@ -51,6 +51,7 @@ SRCS-y += rte_ethdev.c > SYMLINK-y-include += rte_ether.h > SYMLINK-y-include += rte_ethdev.h > SYMLINK-y-include += rte_eth_ctrl.h > +SYMLINK-y-include += rte_eth_dev_info.h This file is not related to ethernet so it could be named rte_dev_info.h > +struct rte_dev_reg_info { > + void *buf; /**< Buffer for register */ Maybe data would be more accurate. > + uint32_t offset; /**< Offset for 1st register to fetch */ Please precise offset from which point? Why offset is needed? > + uint32_t leng; /**< Number of registers to fetch */ 2 more characters for free: length > +struct rte_dev_eeprom_info { > + void *buf; /**< Buffer for eeprom */ > + uint32_t offset; /**< Offset for 1st eeprom location to access */ > + uint32_t leng; /**< Length of eeprom region to access */ Same as above for these 3 fields. > + uint32_t magic; /**< Device ID */ What means magic? Is it always a device id? > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -114,5 +114,11 @@ DPDK_2.1 { > rte_eth_timesync_enable; > rte_eth_timesync_read_rx_timestamp; > rte_eth_timesync_read_tx_timestamp; > + rte_eth_dev_default_mac_addr_set; > + rte_eth_dev_reg_length; > + rte_eth_dev_reg_info; > + rte_eth_dev_eeprom_length; > + rte_eth_dev_get_eeprom; > + rte_eth_dev_set_eeprom; It is not in alphabetical order.