[dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Anatoly Burakov]

Due to the upcoming external memory support [1], some API and ABI
changes will be required. In addition, although the changes called
out in the deprecation notice are not yet present in form of code
in the published RFC itself, they are based on consensus on the
mailing list [2] on how to best implement this feature.

[1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
[2] https://mails.dpdk.org/archives/dev/2018-July/108002.html

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 14714fe94..629154711 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -8,6 +8,21 @@ API and ABI deprecation notices are to be posted here.
 Deprecation Notices
 -------------------
 
+* eal: certain structures will change in EAL on account of upcoming external
+  memory support. Aside from internal changes leading to an ABI break, the
+  following externally visible changes will also be implemented:
+
+  - ``rte_memseg_list`` will change to include a boolean flag indicating
+    whether a particular memseg list is externally allocated. This will have
+    implications for any users of memseg-walk-related functions, as they will
+    now have to skip externally allocated segments in most cases if the intent
+    is to only iterate over internal DPDK memory.
+  - ``socket_id`` parameter across the entire DPDK will gain additional meaning,
+    as some socket ID's will now be representing externally allocated memory. No
+    changes will be required for existing code as backwards compatibility will
+    be kept, and those who do not use this feature will not see these extra
+    socket ID's.
+
 * eal: both declaring and identifying devices will be streamlined in v18.08.
   New functions will appear to query a specific port from buses, classes of
   device and device drivers. Device declaration will be made coherent with the
-- 
2.17.1

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Wiles, Keith]

> On Aug 1, 2018, at 7:07 AM, Burakov, Anatoly <anatoly.burakov@intel.com> wrote:
> 
> Due to the upcoming external memory support [1], some API and ABI
> changes will be required. In addition, although the changes called
> out in the deprecation notice are not yet present in form of code
> in the published RFC itself, they are based on consensus on the
> mailing list [2] on how to best implement this feature.
> 
> [1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
> [2] https://mails.dpdk.org/archives/dev/2018-July/108002.html
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 14714fe94..629154711 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -8,6 +8,21 @@ API and ABI deprecation notices are to be posted here.
> Deprecation Notices
> -------------------
> 
> +* eal: certain structures will change in EAL on account of upcoming external
> +  memory support. Aside from internal changes leading to an ABI break, the
> +  following externally visible changes will also be implemented:
> +
> +  - ``rte_memseg_list`` will change to include a boolean flag indicating
> +    whether a particular memseg list is externally allocated. This will have
> +    implications for any users of memseg-walk-related functions, as they will
> +    now have to skip externally allocated segments in most cases if the intent
> +    is to only iterate over internal DPDK memory.
> +  - ``socket_id`` parameter across the entire DPDK will gain additional meaning,
> +    as some socket ID's will now be representing externally allocated memory. No
> +    changes will be required for existing code as backwards compatibility will
> +    be kept, and those who do not use this feature will not see these extra
> +    socket ID's.
> +
> * eal: both declaring and identifying devices will be streamlined in v18.08.
>   New functions will appear to query a specific port from buses, classes of
>   device and device drivers. Device declaration will be made coherent with the

Acked-by: Keith Wiles <keith.wiles@intel.com>

> -- 
> 2.17.1

Regards,
Keith

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Wang, Zhihong]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Wednesday, August 1, 2018 8:07 PM
> To: dev@dpdk.org
> Cc: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; thomas@monjalon.net; Wiles, Keith
> <keith.wiles@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add deprecation notice on external
> memory support
> 
> Due to the upcoming external memory support [1], some API and ABI
> changes will be required. In addition, although the changes called
> out in the deprecation notice are not yet present in form of code
> in the published RFC itself, they are based on consensus on the
> mailing list [2] on how to best implement this feature.
> 
> [1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
> [2] https://mails.dpdk.org/archives/dev/2018-July/108002.html
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 14714fe94..629154711 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -8,6 +8,21 @@ API and ABI deprecation notices are to be posted here.
>  Deprecation Notices
>  -------------------
> 
> +* eal: certain structures will change in EAL on account of upcoming external
> +  memory support. Aside from internal changes leading to an ABI break, the
> +  following externally visible changes will also be implemented:
> +
> +  - ``rte_memseg_list`` will change to include a boolean flag indicating
> +    whether a particular memseg list is externally allocated. This will have
> +    implications for any users of memseg-walk-related functions, as they will
> +    now have to skip externally allocated segments in most cases if the intent
> +    is to only iterate over internal DPDK memory.
> +  - ``socket_id`` parameter across the entire DPDK will gain additional
> meaning,
> +    as some socket ID's will now be representing externally allocated memory.
> No
> +    changes will be required for existing code as backwards compatibility will
> +    be kept, and those who do not use this feature will not see these extra
> +    socket ID's.
> +
>  * eal: both declaring and identifying devices will be streamlined in v18.08.
>    New functions will appear to query a specific port from buses, classes of
>    device and device drivers. Device declaration will be made coherent with
> the
> --
> 2.17.1

Acked-by: Wang, Zhihong <zhihong.wang@intel.com>

Thanks

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Jerin Jacob]

-----Original Message-----
> Date: Wed, 1 Aug 2018 13:07:16 +0100
> From: Anatoly Burakov <anatoly.burakov@intel.com>
> To: dev@dpdk.org
> CC: Neil Horman <nhorman@tuxdriver.com>, John McNamara
>  <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
>  thomas@monjalon.net, keith.wiles@intel.com
> Subject: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory
>  support
> X-Mailer: git-send-email 1.7.0.7
> 
> External Email
> 
> Due to the upcoming external memory support [1], some API and ABI
> changes will be required. In addition, although the changes called
> out in the deprecation notice are not yet present in form of code
> in the published RFC itself, they are based on consensus on the
> mailing list [2] on how to best implement this feature.
> 
> [1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
> [2] https://mails.dpdk.org/archives/dev/2018-July/108002.html
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>


Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 14714fe94..629154711 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -8,6 +8,21 @@ API and ABI deprecation notices are to be posted here.
>  Deprecation Notices
>  -------------------
> 
> +* eal: certain structures will change in EAL on account of upcoming external
> +  memory support. Aside from internal changes leading to an ABI break, the
> +  following externally visible changes will also be implemented:
> +
> +  - ``rte_memseg_list`` will change to include a boolean flag indicating
> +    whether a particular memseg list is externally allocated. This will have
> +    implications for any users of memseg-walk-related functions, as they will
> +    now have to skip externally allocated segments in most cases if the intent
> +    is to only iterate over internal DPDK memory.
> +  - ``socket_id`` parameter across the entire DPDK will gain additional meaning,
> +    as some socket ID's will now be representing externally allocated memory. No
> +    changes will be required for existing code as backwards compatibility will
> +    be kept, and those who do not use this feature will not see these extra
> +    socket ID's.
> +
>  * eal: both declaring and identifying devices will be streamlined in v18.08.
>    New functions will appear to query a specific port from buses, classes of
>    device and device drivers. Device declaration will be made coherent with the
> --
> 2.17.1

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Yongseok Koh]

> On Aug 1, 2018, at 5:07 AM, Anatoly Burakov <anatoly.burakov@intel.com> wrote:
> 
> Due to the upcoming external memory support [1], some API and ABI
> changes will be required. In addition, although the changes called
> out in the deprecation notice are not yet present in form of code
> in the published RFC itself, they are based on consensus on the
> mailing list [2] on how to best implement this feature.
> 
> [1] https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D453%26state%3D*&amp;data=02%7C01%7Cyskoh%40mellanox.com%7Cc4caf7979dd943bb48c508d5f7a7661f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636687220727753880&amp;sdata=9yDGZf21ImYOUzM85n92cs%2BsgeafrrhG%2FlmJpWVpcWA%3D&amp;reserved=0
> [2] https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpdk.org%2Farchives%2Fdev%2F2018-July%2F108002.html&amp;data=02%7C01%7Cyskoh%40mellanox.com%7Cc4caf7979dd943bb48c508d5f7a7661f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636687220727753880&amp;sdata=zn4ZfXModNRgnSp649JFWd4Byr7RxH8mgcM6IKJTGWk%3D&amp;reserved=0
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 14714fe94..629154711 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -8,6 +8,21 @@ API and ABI deprecation notices are to be posted here.
> Deprecation Notices
> -------------------
> 
> +* eal: certain structures will change in EAL on account of upcoming external
> +  memory support. Aside from internal changes leading to an ABI break, the
> +  following externally visible changes will also be implemented:
> +
> +  - ``rte_memseg_list`` will change to include a boolean flag indicating
> +    whether a particular memseg list is externally allocated. This will have
> +    implications for any users of memseg-walk-related functions, as they will
> +    now have to skip externally allocated segments in most cases if the intent
> +    is to only iterate over internal DPDK memory.
> +  - ``socket_id`` parameter across the entire DPDK will gain additional meaning,
> +    as some socket ID's will now be representing externally allocated memory. No
> +    changes will be required for existing code as backwards compatibility will
> +    be kept, and those who do not use this feature will not see these extra
> +    socket ID's.
> +
> * eal: both declaring and identifying devices will be streamlined in v18.08.
>   New functions will appear to query a specific port from buses, classes of
>   device and device drivers. Device declaration will be made coherent with the
> -- 
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Maxime Coquelin]

On 08/01/2018 02:07 PM, Anatoly Burakov wrote:
> Due to the upcoming external memory support [1], some API and ABI
> changes will be required. In addition, although the changes called
> out in the deprecation notice are not yet present in form of code
> in the published RFC itself, they are based on consensus on the
> mailing list [2] on how to best implement this feature.
> 
> [1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
> [2] https://mails.dpdk.org/archives/dev/2018-July/108002.html
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 14714fe94..629154711 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -8,6 +8,21 @@ API and ABI deprecation notices are to be posted here.
>   Deprecation Notices
>   -------------------
>   
> +* eal: certain structures will change in EAL on account of upcoming external
> +  memory support. Aside from internal changes leading to an ABI break, the
> +  following externally visible changes will also be implemented:
> +
> +  - ``rte_memseg_list`` will change to include a boolean flag indicating
> +    whether a particular memseg list is externally allocated. This will have
> +    implications for any users of memseg-walk-related functions, as they will
> +    now have to skip externally allocated segments in most cases if the intent
> +    is to only iterate over internal DPDK memory.
> +  - ``socket_id`` parameter across the entire DPDK will gain additional meaning,
> +    as some socket ID's will now be representing externally allocated memory. No
> +    changes will be required for existing code as backwards compatibility will
> +    be kept, and those who do not use this feature will not see these extra
> +    socket ID's.
> +
>   * eal: both declaring and identifying devices will be streamlined in v18.08.
>     New functions will appear to query a specific port from buses, classes of
>     device and device drivers. Device declaration will be made coherent with the
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Shreyansh Jain]

On Wednesday 01 August 2018 05:37 PM, Anatoly Burakov wrote:
> Due to the upcoming external memory support [1], some API and ABI
> changes will be required. In addition, although the changes called
> out in the deprecation notice are not yet present in form of code
> in the published RFC itself, they are based on consensus on the
> mailing list [2] on how to best implement this feature.
> 
> [1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
> [2] https://mails.dpdk.org/archives/dev/2018-July/108002.html
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

[Thomas Monjalon]

02/08/2018 11:25, Shreyansh Jain:
> On Wednesday 01 August 2018 05:37 PM, Anatoly Burakov wrote:
> > Due to the upcoming external memory support [1], some API and ABI
> > changes will be required. In addition, although the changes called
> > out in the deprecation notice are not yet present in form of code
> > in the published RFC itself, they are based on consensus on the
> > mailing list [2] on how to best implement this feature.
> > 
> > [1] http://patches.dpdk.org/project/dpdk/list/?series=453&state=*
> > [2] https://mails.dpdk.org/archives/dev/2018-July/108002.html
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied, thanks