From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE23CA0487 for ; Tue, 2 Jul 2019 12:37:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 177A81B995; Tue, 2 Jul 2019 12:37:04 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2C0B01B965 for ; Tue, 2 Jul 2019 12:37:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 02:49:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,442,1557212400"; d="scan'208";a="157581913" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.126]) ([10.237.220.126]) by orsmga008.jf.intel.com with ESMTP; 02 Jul 2019 02:49:43 -0700 To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net, jerinj@marvell.com, jiayu.hu@intel.com, Harry van Haaren References: <20190530212525.40370-1-bruce.richardson@intel.com> <20190701155600.43695-1-bruce.richardson@intel.com> <20190701155600.43695-8-bruce.richardson@intel.com> From: "Burakov, Anatoly" Message-ID: <71ac9f22-b9df-bc04-6069-af59689a8c01@intel.com> Date: Tue, 2 Jul 2019 10:49:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190701155600.43695-8-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 7/9] raw/ioat: add configure, start and stop functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jul-19 4:55 PM, Bruce Richardson wrote: > Allow initializing a driver instance. Include selftest to validate these > functions. > > Signed-off-by: Bruce Richardson > Tested-by: Harry van Haaren > --- > > V4: Guarantee correct SUCCESS/FAILURE return values from test function > Use memzone rather than malloc for ring allocation so we can guarantee > contiguous memory. > V3: don't add a new descriptor format struct, reuse from rte_ioat_spec.h > V2: test cases placed in self-test routine > --- > static void > ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info) > { > @@ -44,11 +119,17 @@ ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info) > cfg->ring_size = ioat->ring_size; > } > > +int ioat_rawdev_test(uint16_t dev_id); > + > static int > ioat_rawdev_create(const char *name, struct rte_pci_device *dev) ...and... > + > +int ioat_rawdev_test(uint16_t dev_id); /* pre-define to keep compiler happy */ > + This looks like you're trying to avoid introducing a header file? (to my great shame, i don't quite get how would that even work...) Otherwise, Acked-by: Anatoly Burakov -- Thanks, Anatoly