From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F40B9A046B for ; Mon, 24 Jun 2019 09:53:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F00D61BF38; Mon, 24 Jun 2019 09:53:47 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0A2831BF36 for ; Mon, 24 Jun 2019 09:53:47 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 3FEA5BC005A; Mon, 24 Jun 2019 07:53:45 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 24 Jun 2019 08:53:40 +0100 To: Thomas Monjalon CC: , Ferruh Yigit References: <1560152324-20538-1-git-send-email-arybchenko@solarflare.com> <2b5ce1ae-0157-f1e6-6bad-eac1306675b7@intel.com> <8008291.hctuhiT9KT@xps> From: Andrew Rybchenko Message-ID: <71e7890d-585a-6bf7-8112-9fe4d400143e@solarflare.com> Date: Mon, 24 Jun 2019 10:53:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <8008291.hctuhiT9KT@xps> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24708.003 X-TM-AS-Result: No-11.130800-8.000000-10 X-TMASE-MatchedRID: xcONGPdDH5oeimh1YYHcKPZvT2zYoYOwC/ExpXrHizzIPbn2oQhptRko LV384ybquW76JsuTd2UcPMPBmVk68N25rEkhfi3quwdUMMznEA96QyBM5BtUWwL+e4+Xk/QWSHg UVMoIv2HQoxMQaKNYvkfiFVGXDcguhIwkxxTu9kKiVU7u7I4INUpFpc3bJiMe1R/ptYWR8C4yE2 y3AedkX/aIYH7ldXWi5IUyRgxW1cHKGz6CdByMAkkDDCs/T+AZOxd2XHUJjCshWXegEF7wb7bE3 ByWTBPiMGzEutgo6Po7kb6XgPMXH98Io8bMptYdCfEIlU0KzNi7vCrRHziT3weLCIX046iBzEVD Gnc+EfJ5QYjFiDClc9AAI+C3I6/FI2DLDezBgxjhYA5szVVSqCXdp9l6EkRZaTyOjZopjNRiDZ9 grTDMlTU3HPhRrRy9/76CM4Z/MGblRxm3A2wKujl/1fD/GopdcmfM3DjaQLFsZUSYh+N/e0RAGa NKMWk9H8dHyYlaykhALzOjdG5+0e3j90QO/O6IFNg8jviFkJ9QNhwOMEM82yOyoH+oLbrt67K98 WDCePYBPGZk7N91cw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.130800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24708.003 X-MDID: 1561362826-p3F9iubMHu2e Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/29] net/sfc/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 6/24/19 1:37 AM, Thomas Monjalon wrote: > 18/06/2019 09:52, Ferruh Yigit: >> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote: >>> checkpatches.sh generates warnings/errors because of a bit different >>> coding style in base driver. > [...] >> Series applied to dpdk-next-net/master, thanks. >> >> Fixed following checkpatch warnings while merging: > There are a lot more checkpatch warnings in this code. > Is it possible to fix the style of the code in the sfc/base directory? > Or we prefer to continue with so many checkpatch warnings? In short: I'm trying to minimize a number of warnings, but it is not always possible. I'll pay even more attention to it in the future. The base driver is used for other OS drivers and coding style in the base driver is a common denominator of their coding styles plus some kind of established practices. Unfortunately some points in coding style in FreeBSD and GLD (Solaris) contradict to DPDK coding style. Of course, there is a grey area and we're trying to avoid checkpatches.sh warning there. Sometimes even changing existing practices, but anyway major changes of coding style in existing sources is not a good idea.