From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3D2145C0A; Tue, 29 Oct 2024 13:56:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A1BA42E10; Tue, 29 Oct 2024 13:56:13 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 4EE3342E10 for ; Tue, 29 Oct 2024 13:56:12 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 539D7113E; Tue, 29 Oct 2024 05:56:41 -0700 (PDT) Received: from [10.57.58.134] (unknown [10.57.58.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DBB2C3F528; Tue, 29 Oct 2024 05:56:10 -0700 (PDT) Message-ID: <71e85b15-b277-4d97-a875-74ab36c11eef@arm.com> Date: Tue, 29 Oct 2024 12:56:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] dts: use TestSuiteSpec class imports Content-Language: en-GB To: Nicholas Pratte Cc: dev@dpdk.org, Honnappa Nagarahalli , =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek References: <20240822163941.1390326-1-luca.vizzarro@arm.com> <20240822163941.1390326-5-luca.vizzarro@arm.com> From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 01/10/2024 21:45, Nicholas Pratte wrote: > The code you have here makes sense, and I like the implementation as > it removes a lot of fluff in DTSRunner. I know Jurja mentioned in an > earlier patch in this series that this functionality intersects with > the capabilities series, but I'm missing a lot of context to > understand that fully. Maybe you could provide some insight? I'll make > sure to analyse this deeper in my own time as well. Beyond that: Most of the intersection comes from the fact that this series adds auto discovery of test suites and test cases, therefore treating the test cases as objects with labels for processing and filtering. In his capability patches Juraj also needed to turn test cases into objects to add runtime metadata to them, such as required capabilities.