From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0048.outbound.protection.outlook.com [104.47.40.48]) by dpdk.org (Postfix) with ESMTP id 178782C48 for ; Wed, 5 Jul 2017 16:03:37 +0200 (CEST) Received: from BN6PR03CA0035.namprd03.prod.outlook.com (2603:10b6:404:10c::21) by DM2PR0301MB0608.namprd03.prod.outlook.com (2a01:111:e400:3c08::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Wed, 5 Jul 2017 14:03:35 +0000 Received: from BY2FFO11OLC001.protection.gbl (2a01:111:f400:7c0c::116) by BN6PR03CA0035.outlook.office365.com (2603:10b6:404:10c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11 via Frontend Transport; Wed, 5 Jul 2017 14:03:35 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC001.mail.protection.outlook.com (10.1.15.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1220.9 via Frontend Transport; Wed, 5 Jul 2017 14:03:34 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v65E3VpB006369; Wed, 5 Jul 2017 07:03:32 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= CC: References: <3cedddd79f0f518e412431526c9e2b3058d3220b.1499211317.git.gaetan.rivet@6wind.com> <20170705134521.GI11154@bidouze.vm.6wind.com> From: Shreyansh Jain Message-ID: <71fa0d7b-a140-5d1b-f0e7-a6e87eebf85d@nxp.com> Date: Wed, 5 Jul 2017 19:42:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170705134521.GI11154@bidouze.vm.6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131437370146951297; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39840400002)(39450400003)(39400400002)(39410400002)(39850400002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(377454003)(199003)(9170700003)(626005)(8936002)(83506001)(31696002)(64126003)(356003)(4001350100001)(47776003)(65806001)(81166006)(8676002)(2870700001)(575784001)(33646002)(65956001)(106466001)(5660300001)(77096006)(4326008)(498600001)(229853002)(86362001)(85426001)(53376002)(53936002)(93886004)(5890100001)(104016004)(76176999)(54356999)(31686004)(110136004)(6306002)(65826007)(305945005)(105606002)(50466002)(189998001)(23676002)(38730400002)(6666003)(50986999)(2906002)(6916009)(36756003)(6246003)(2950100002)(966005)(37363001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0301MB0608; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC001; 1:xMB4u3ChQr3GFfvS6ivdYNAXRE4b9QMr3hWvnd9p9FBZhgJjnImXbn/ZgH7KAFgFBH62InA5y1pWQRdNwZSkxAlZUVveMFJx0faVwLM/ZFoX9IJVaYIFuzslX5pDqUsB41Oz/AUEb8VP72RPYte0IoaPJP9skYywj2NhvMvEaYc8SeZLP4lPNOhQRuGVr9i5l0jV52HocKN0UFsTCD4d2LPjRnk0D3FNGcocuJf0rPhuNyHMP77HnH/RcGJYYWYMmqOuQHT/deafWVvj4AOknZrhsf6C71dWC09W6M9qibwVcdEs6P0/jQtFDw+sI3Im6kHQJHqVhybZYOCOYIlzAmjvMZHlpL2d92KhmtlQJg4ZgKQaueOh7yGEI4yDtpnH77/AXJzpjntEw0Uzlb4rtYT4zGJZdmqgibWanMif2sLQJdmTWbgsF+NuIKdkXaR5x4vPpgnRn+Z9aMmyRzciOzb1OfavduY1Aj9U4pugSkWYOUmlgfZ8GymVr73Yjr2v9DlRCIwTP9reEwEtMKihKIRb3SA3bNK5mkP5pdA4C5E434YFDP/XWsUBxoxKPeuiPHNsdT55HUVlrXcQCCJKha8nT7W/ikfLa+1Y8iGGVpvr2mCAhCo48HZC2ao4L0Zyf1eQzcaA1rSqB0nXaYej23e/yx5BzyECBlWnF4D3A6YNtVZQv04cJBGjTQY6aI2dsztHtKPTEKP5+f/wV1oYyND0KtRO81oo02j7jUVNGuyrwl5DvNFiF+N9N7D+lD+C5HWkPwT4WkVOjQ052qWz5SDH3gEHtoYssisiyf9g1tkShPH2TyATwz09jHxvvI68q/jeojymQBIeDGnGBJ/zLb11gzjo9Ew8shcGgXkowGZDER+rFQaDeA7VEUUhvi7Z X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1d0be44-2433-44b7-4dc5-08d4c3aea044 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM2PR0301MB0608; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0608; 3:JUAu9r7v10jY+4yQKMYuL9rVnpEHsbOvttRT4afE7VyanbQrkUlW8wbm92bGk92Taptfs+kkZ1T92zTXf5V+b+9tzDeiqk/K6qCbYDBr/4IgM/8v0lCwpVIUnss9FoVc7ZSgsQUgZCPnXOtdxjFao7B5AbDOxi+7KzNZkte5GtlrAfFRzviBmhD5LmiRxUpmfpkhDZjXHz2OMZ39jm23MU/g24bvcflbCcbpp8SF9rVsj4DGf++bKH83CsPucaRHRlm09JC1ciFoyXXAy1sHP0CQzYp/SFy9DKsgMYen3x+iDEf9Z9lyz/RJE22m4gC9biraIGRtZ6k2mxjIzTgW/KvpUlLaPF8v1dvP21rzK0ZZGmeBc8AEqFLrSaXHni+tDqlVqtjvchdBr4TCiZVIEpwXoCS3BHn1COyRRFVWTeIUo/lh/nNiTFsLXC2um1O0dcGGFKkLwHMxs4j/gsfzH5VpD38/eRldgMfLn22x8ExVIBrotrxmTDTSG6gb9on1bDLUACz69TJux4M0hZxq3q9gcNeN2SOZ/MEysSxpTP/KvnuwofV8decNmrIxxiGeRfhOa4sdDDmU3nSU9k6RjTziiLpOY1wxGUw3S0QH9ZTykN8+5yK6SZYI3Rg5ZsnfoA1uTYex5NBGOvPA4FiatWt8x4pVBqbNX0UeaIvX20VJdDeq5TTikizyIHntLgERm48AM+unZ46QEK0JF3a1f/6/q2Fufu+OZO+1gaHdDm9wn79Pi8B4hCs01cmRmCjF3gyKoZcwXq5+7bXzETS5zqSmSs70ukUhnIyAI05Z0HDUaTaThFDJjlcbhlRkyCWNC/w2Mx/wlyFtm8V1nVXnCABYsn0DIisGrh73kBpY1yg32sXEK1g3kdE3FAniSJbp X-MS-TrafficTypeDiagnostic: DM2PR0301MB0608: X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0608; 25:eNTx/KKyOT9+1ugmjPXLoEHanhwjjEH7B7DsaAnko/HATpm9EYQun4vzMR3ANMKBrqVz207Sn8Kawg5OkowbgmXcXmOjkIUePSSgcOrd19wfUZ8cVGW5MVjU9C37GX6iGB+2/yesCO4RHTPwgL+jY+GnFbOYDdkMtXMdahWtYvAr1wyW9w+SNBquLDMM1tlyzsSmmh2/jwwdfLhDANo6lMzLuuJNr8klyeZ3PEwnJIbKh7zqQDA0PIxowiRCldsdg38WUJYXzsYOTpM13TSIJWvmi5hmfgmnO1hty8lScl1m5JHrXEvMWFUSaCmhyZZtET5cuEiCndaAnUmEFVuCjAygKXYyMLcFb04cDUASVqFoNq/0QBU0cSv93mX+aaQVn3+4ic2wTuhUHWNzTxzu2anTc9wZYtAk3yJEJG31uzjtne5H53FM15KCZKAxTbUb97YM/zehILE2fJnWVqrD8774jdAjUilB84kpY2AgZbtTPtzr8hYUp/cHnnuGhIbHgRFxqAXaqb4s7pdGntcJ57g2vyW5FTm9XVKfK7ojXOJN7LrXl7S7Q5bNPdcZgvYLtIJT9dBlSf/6Ru/IWB+qAlvPuLqoF1atcJGlmcNGM4U46Fq5AypThFOC+9VYpuN21Nv9dY9VMJg3NA//fKnSeqEyedlRiEmnMx7UCikq+xl5gryVVuU7CxPrqyEKVEQnTpzwtpdGa1fAEwONOBEGBHEM/phZpuWkgXMjSWi88EG+O47dABxCAnkmC5DDG61hilq49Wtpk+g100JN8i5Gz6H6aJTwhy2D6ctLeWnm1VwsdLUGb3NqHWrNy+EcUejsJHSsAyJMKPsBHoESJwuQFNIgE2o6vC7XrPvOxwDym6LurGU4y0GIenjBIx+n5Mj4YTLEJI3DVtoR6nDpsBX3GDP4hiFoXJRSJ3OORN45SN4= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0608; 31:nHJFDrcKHsI+eBgD6xYqtFwypvo2621YIo0aLeJy1YHqB5abxvTA70wg7R9070XDsflDRedauiUMRVyvwV0JeaoPPoJuZU3Rh6dyDXmbCpfk3n1Aep5GxiuinbxU4/XH6BiLVfBAZTpSOYYo9+Cve7mFs+OmTScI0YtRkjGaL8sRVffNPWLSYZvcZgtnckhn7RI1AB9ttZIeRdWzIZ1rzO3DAl0EmamGRsggrSwC3sJNZupOiYGVznnXybzDAENksFAwj7tg7TWmARuUmb2HZ/THR7BsCvp39OSisX9FurzXMTQZMPdmkuL0/9rZ5l05hn89Zi58HbiytPm53QEGGofndgLDbiJu3Ogbii1qikPPuHt95jYGIff8HiCe4jOnbbM+2VwHR9nzPxe2oLEl0g/bUHxWvjABOQXbaDd+w1yr6Fz77s2XmrTUUD9Za6mhUnjRW3Hiutc50VquK0vvkPgVNHRLqSMq1FXLUGVAfLhz7szRwVLAhDJVIfZyckU1RrYDWInO3LOibr9C2iHzq3zbcCjmPaNDVKj/GRI0Mg3EAuRvo7B9QPXamdGslfRQ1PPUA8liqwO8SoYEjCJ94BF32vagjxWO7mBjcqqdIeN7Drq/nIGULwg5yb0okNrVaa5KvsW0kK9MKHonlEN5qT1JnKvER7pNpeFwgsC7fU+Ef0iPKqJOV3j0m1VqJkUzzBwuBxEKkX/rQqP061PWbA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(185117386973197)(48057245064654)(148574349560750)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(5005006)(2017060910033)(13016025)(8121501046)(13018025)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123565025)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(20161123556025)(20161123563025)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM2PR0301MB0608; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM2PR0301MB0608; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA2MDg7NDp3Q0xzVTdPWklLd0RxUE1Fd05oalliL3NV?= =?utf-8?B?SGZrczBabmN2SnpYRFg4YkJSQkE3TkwxQUllWUZFV1BBeDhXTkIvbHRZeVBO?= =?utf-8?B?cENUS1hZLzVKN3g3K3pGZVZoNGZIaTJBZVRaSVV4dnFRUFkzWkI4a1VQWlFH?= =?utf-8?B?K25qVXM3STBWR1I4ak8yTGJpMXh4Qy9VdXBtQktzSGhzd2ZXaXJxdFg5NERQ?= =?utf-8?B?MTRWQU04b2NsWG1Sdm5MRVJBdE5CRGt1bStRd0ppVlJ6Z1JNa0dQOFU0Qlcz?= =?utf-8?B?NFhZQzNDSFA5Qlc3a1RuQWhVYnVIK3YvU3VyUFMyRjVVekNUNXowUTViRUda?= =?utf-8?B?MENLLzNFeWtWME5RRFcrSXNCeWpzSmY1YkU5bGZjOEZsNGE5bllDRTZySTR0?= =?utf-8?B?ZTRrTkRmalZVejRDRytaWUwxRTJqcVVFUXNsNHJKZEUzaU44cGF2OGlqMndr?= =?utf-8?B?cTBwVTI0QVJQb2VhVngrYWtmeVlGbktyVWU5Mlc2aVRJbkhSLzJqdmcycHlt?= =?utf-8?B?SXBCSUh4L1RFMlZXRENKS1owRXEzVkVJMVdOYTFkcVpTVFBYbTBCdTNTNzRE?= =?utf-8?B?Tk1vLzArSk1CY1BXOCs3NTBwQWpKM0lCYnBQY08wOFZVd21qNTBpcGd0Y2lV?= =?utf-8?B?ODZxL09DdHlFd2dyWXBFZERMWERTQklSeWwvT1orbC85UW5JR0dtVmJQVGVN?= =?utf-8?B?bXFCRS95Z044dGg2WU1hajRXYUlWOFJzeTJCMUxQbjZmVkN4cmhhU3JBYk9U?= =?utf-8?B?UVYvMlI0U1VoT3BPMUw3RnNhOVVUQVBaSTJxNHhtdjF3UW9IMlk1dS9hWmhV?= =?utf-8?B?TW8xSjIyRGdHRUE0bjNHZFdZa2pSUDhURnU1VlhMeldiWlhOMXVTNG1EdWR3?= =?utf-8?B?cU1wZ3FRbTZOK3dhUVZ4YzQvVDh3eWlJcHJLQ3pkYkdGcCtsYUo0RStjL1R6?= =?utf-8?B?dEthd1hoVXlpV1ZsMVpsbzZNUGhZMGJPZ3dUWjROVWNVVyt0cVZrR3ZtVmI5?= =?utf-8?B?RXpuaHgvNE5qd3cxMVNJZEhhUXpaN0hmZEpFS1R0TDFMMGJYaTFYam9qb0pl?= =?utf-8?B?VVhOR1RraUdBaExpZnoxeit4eFp2akZMd0Q1WDlhTHJ4QVQzRndCTTBkSjZu?= =?utf-8?B?aVhHS2grT1Rna2ZySzFoNWU1NVMvVkVVZnB4Q1J0Wjlqd0FKeHRlRDJyVnFO?= =?utf-8?B?d0NkSi9sMzNaT1ArZGd6VDJsMjNoSXJYQ1NyUGJkOUIzTFRLY2liMzhLbXVT?= =?utf-8?B?K3huajErR0RUdm1NTUI1QmJYc3lnaTdpYTFwTW5VR3ZudE54V3p3UVkrUitx?= =?utf-8?B?MWlBdUhGRU5Ib2paQjJPK1AySHlUTzNKVDN1Z3l6aHRQVDFLbGMvK3h5UzQv?= =?utf-8?B?dUN6eVo5VlI3bVdlc0UrU2E2eStYUVRIaDF6UjhEM1hDOHh2akJQUXczWEQw?= =?utf-8?B?Q3FZcnQyTVp0eG5mOWREVER4dmhMUEVtZVZtanowY0xEU3FlRkI2M0I4TDNn?= =?utf-8?B?YWxqalJwMCt0QXhEaHdxcWYyQ3RBcUNGQkdGYlEvS1B5cjg2cE83M0hlaUVC?= =?utf-8?B?VlIxVnR1UWFHcXYwdUo4cjI0Ty94R09MemlhYjNnVmxYVHdCQ25OMkU3dENy?= =?utf-8?B?amhrYTNRQ2QwYWUvOHEwMVpZZjJKTVRrcjB5Z2dEVkdUYU53ZWJGbmpNUEo2?= =?utf-8?B?ZDNhZ296MG1FZG5kZWxIcFZwenlaczZEYXNydVZKaGV6M0JaQktkQUl5UWxu?= =?utf-8?B?Y0FmeWZpenQ5T2g5SkgyUXNVTUNHdjdVOS9PcXdVTnNCR1RFVGg4Z0RJYnlR?= =?utf-8?B?OFpibGRFS05kTlNheUJTY2l5eWI3c24yT3BYZEVQSGE0K0NjU0RSUUpMZTVD?= =?utf-8?B?K0NjNjYwSURKR2FTbWxKaS9hNGYwMWdUUjBNZnhWQUh6UkRKR3J2M2NmNW1k?= =?utf-8?Q?wMVQcaQXhKLKRMdqZSrDJfqnJIKljU4=3D?= X-Forefront-PRVS: 0359162B6D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA2MDg7MjM6TmFDVUtBcVozNGlDekFaZWpPN1VlV2la?= =?utf-8?B?UmczTkYvMnU1dG5SWUcyWnRPbEJ4K2lTeGZtZFM2eVRuN3BLcEE3NmVPY0hw?= =?utf-8?B?SGFlcFZISnFla3U4QzIwMFRLQU9rTG03am1YbHQ2QnNkNURNK3g2WSs0WmlE?= =?utf-8?B?Z3cvM0hidmVWbUR6N0lWbFRVWlFPZHJEMDk1dE93bWhhY1UrYXVsNDhIU29D?= =?utf-8?B?cU1neGdRVTEvRHAxYUVTSDdVK2hXZXFKaDFyckh3SlVsdkFDKzJMamJZY3N6?= =?utf-8?B?eXl5QXRPOUd4T0RIb21wKzdDNTFJaDMxNFMzOCtWSUhiemt4Y0locFhSUWlC?= =?utf-8?B?ZkloWHJkQ0dhdWFNbmszM1FqcmtUZkRRSmR0WHR1VHYrb0p2czhjWGlHYWZC?= =?utf-8?B?bDRzQ1ZIeFcyRnUvRGtDajJoMThTTnRpVUNlQW5KVHJzK250WC9pTWEzdEVQ?= =?utf-8?B?bFJTMytjYXRrNXlLWXFjekFNNm1XZG04U1RmdmhaeUJ4VDRDckMxTVM1QjV1?= =?utf-8?B?Uk04M0gvSXh3SDdCN1VGZ3Z0aWdEMmFpS0RPdUhaNXZyWFZLM3ZrNEVvV1Ux?= =?utf-8?B?Ny9waW80OVo2WUZtRXRNUzRCZTJKQ0dYd1lMbE5CRVRROTVwbGRVNVhCM1hI?= =?utf-8?B?RU5tREZtL1BTWlhKUEJXbStsaU1Lc3hMVHVnNzFhRmxNcUltTDhocHo5QWhY?= =?utf-8?B?TFlkQTl6cjJVWlpUNUxSdmU0dnNJQWk1Zkwya2RWTGFWbml2ejVYRjVEZndm?= =?utf-8?B?RS91Z2ZXQnFuSXNKMDArcEQzWU5wYndOZ2RIcWtES0cyd1JvU0g3eXpGY1lN?= =?utf-8?B?bWxqNC83aUJLN2hmb1liU1ZIb1FZajE2MFIwdG9zVWFtM1ovRFdUL0VlQURj?= =?utf-8?B?S0tGNE5YSUwwblZwZ3h0dzdJeU81R2tSYitUOTZYMW42ZzZiUXk2bUZESHVR?= =?utf-8?B?SERDN0xOTUh2ZUFYWUJxRkE1dnNqanlXZTRpNE9maUE5d0d4VFpYamVOZUJ0?= =?utf-8?B?dHpBYnNSS2RhYlpNZGwzV0R4MUErcGl2VHl5aUd3Qjl4bW5CUVZ1d2o2WTAv?= =?utf-8?B?cWd3WmRSM1dMTUlaTDRuZzkyTG1Wb3k0QWhIODdZUGFFdU5hbXpRMGdldUxo?= =?utf-8?B?MTdtenNTTzNNaDhWQzBUbHhEWHlBYmVwYWJHY3QxNnJ6N21UVFVvUDFrNisv?= =?utf-8?B?cklOYjdvdGR2Y1pLbVA1dXhDMks5UkVIbnRkYXdxZzBEandYTDJ4MmdjMncy?= =?utf-8?B?S0ptZ0xQMXd4U25KZ2ZhTlExNEg4d1NuaFRUVEtyUjk5MXlqQmtRYnErMFlM?= =?utf-8?B?QW1aVjd2bnRZcGZ6OWtWaG1yNlZkM1NBWVgvcWZGc0FqMjYxN1VBajA4V3FE?= =?utf-8?B?T0U1bDVOOGJMTE5TcE5DVGZLalp2RWYxMThtRWVrUXQxV3ZRNUNVQmQ2b0dN?= =?utf-8?B?YWdqS0FnOEpNZnlnZUU2MjE0dUdBa1J3TXU3NUd2VEZhdW5aQ29uRWNpTm5i?= =?utf-8?B?d1hlUEVuR1YwNFNRaDFzQ3BRbkI0dG1wQkp2MEdZY1RJMnIrOUpYTy9XNysz?= =?utf-8?B?TkJBK1pmLzNRTTROck9TM1JISjJwU0EvVlN1dkhLczVOSHlSalR2cHNzc29R?= =?utf-8?B?c25LL0xSVHZ2c0o1TWhtdHVLWGpHMW5kNzFMSytpQlFVZThhQm1XQTJuT05z?= =?utf-8?B?RnJFMXB2ZlQ0TVFZdU5xeE9WZ2NHRUNEZmFOcUJ5TzlBeGJMckhmbmN6SWRW?= =?utf-8?B?WW9EemhqRHFZcGFpak84MWhtOGZFc29QSEhNblFPdlVLdjcwd2RUbE5Ed21V?= =?utf-8?B?YitwY010OHYyTTZnUVA0MVlsanZzSkJrK0UvemdyV3VGcmZQN0drRG94VnNu?= =?utf-8?B?YUZaMEdWdU9RZGlaN1hMSThlU3ZrTThBZ2U0TkhuWW1nYkJmN0R4N1NTU2pG?= =?utf-8?B?cWdndVNQTWxTUUliTkVOOS9iMjZxSTR4dHIxSkNvcFNTN1l1eldZREhWL0M3?= =?utf-8?B?YzVBMGtMamlnYmN1MXpRbU9pd0JkL0laZTNFb1k2L3lraW9UdzI4YkFNN2pi?= =?utf-8?B?c2dBSTlENlJMSHJ5T09GVjZET0Z5b3Y1UkJzUm1MR0dHTkFkS1NSSGM5N3Fk?= =?utf-8?B?TUYvK0N6Y2FzS0xsVkRQbHNHdzgzbkVPY2RiTlNiSVQrSlBSdXZkNEkzdTJr?= =?utf-8?B?c3hmZHdjdDJlTUZuLzR1MXBTZmlyd0E9PQ==?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA2MDg7NjpOOERJMUhYNEwvYUErWCtLMXBxTXZFRGJB?= =?utf-8?B?THY3SHdIMVl0K3llcXYxKzliTzd3RHZ3K01SNzZnTG1QbVZFd0JSN0dNOXFH?= =?utf-8?B?VUIrdjBDNU12TTlZT3dOREh4Qm1oNVpHTVlXT25DOWZkd2RJdGFEYXk1QS9D?= =?utf-8?B?MkJzcloxWlc2eFJabGhrMzRSL0pGWmRacXErSE9QWlB0UjZlNEZNa1N3OVlS?= =?utf-8?B?bnBycWFEQnhMWHNDaGFJUC9hZVJhLzFhSWwwT2hkM0lWVUR6THBzMEpBSUln?= =?utf-8?B?ZXd2NnFVeWVpY00vR3JOYVI0RndTR2hBZUN1TG1OU3lQOG9Cdlg0YXkzcVFu?= =?utf-8?B?ZDhvZ1gwTGpOZm9lN0ZUejRuejUrSytEUUpzNlRwbXZkM0Jsamd0VFNWNnZX?= =?utf-8?B?T01vb1p1Q0kyeEthUGRaUXJlSXZybG4yb01XOHUrbmQ2c0NDTzBwQi9KRWoy?= =?utf-8?B?Z1RhZWFuUWxldkxjQlpOWE9yeVl5YitwRWRqTmYxcjAvVzVOZTdmNVAyM2J4?= =?utf-8?B?Yjl4YytVblJGU1lGQytmTkNUUG1IRCtnQTJHRkpIeHI0WHA4Nklwb2JCT1Vj?= =?utf-8?B?UlZKd1NROUhGVmxnTUJaTlROYmd1SEErYWNuQ0pVTmNqRDB4eHBEV3lYU1dW?= =?utf-8?B?VWhGRWMrNVF0d1hJTFgwTUorVm56bWNvRTkyY01lMVU1WlhSOENCQ1ZlNXpY?= =?utf-8?B?MGM2SVo4cXNzZnM0WkNydFdSVmVZQytmaFdkUis3Q255aGJ0Z3MvdEJmQmVt?= =?utf-8?B?L2RHQVdjZjFCeDBFSHZ5VG9wejFNK0ZxSkR1Z3ZrME0xaEhub0t2ZkI3cHRF?= =?utf-8?B?VVJ0SCtBQzEvdDJONWlnbEUzQmlORi9NQklEUTA0VUxiRThaZ2NUb0gycTB0?= =?utf-8?B?ZVI4c1hhbno3bktBd2VaZTZjTitkZXprVDV2SXBHN0JIWDFTWDFrNFAzOEMr?= =?utf-8?B?aDlLRzVhbXhtS0paaDYrTC8ycjl2L1g0VGpZSXBOUURaT0xRKzZFNEVnakVS?= =?utf-8?B?d1l0V054NURsZUxVSzZQNWlMZnN6ME9iMVlkWVpxQkxpNk4rM2NTcGJDa3pR?= =?utf-8?B?d0MvK2pjeGdCT3ZCM0hEMy9WWFNMQU9xRjZTWVpWT2Z5WVMyczdUR2ovMlRK?= =?utf-8?B?am43QlE3QU1tZ0pPRDF5TmdGVzVyaXEwTTgwVlVBMGlxck1pN3F5L0pHbkpP?= =?utf-8?B?NHMwOSthQ1dhQjVRaDloTjBMcVNWTUY1ZEY2U05SOFJ3eEFiNTJvck40VVF6?= =?utf-8?B?cnZzd0YxWG91NnE0SFMzSHBQbCtCNnFlTEFKRVZWUUY1RkgvVmt0c29pSmFj?= =?utf-8?Q?BjWy5VkDGOm/w2Ma67Y0IN0nAalhyn5pw=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0608; 5:VJJ1wQUQpumkmEmg+RmD8y4F7YciLTdSfjZvZ/vCwv2nvr7hWxyFLh6jx2evHEkbxbF+we437HjFrhOvy2DrYC9ZDfxRhKWzbhzhcSOIjK6gWzg+UVlhIkyM5LmtACYms4V6oOxVoDVFxOd6ywyKT8Ix4fidhncSTiKhuoXrLyvl4rr2lEUizlsNTvYuPBxJI3C8DEFw9Lqse9Mc22qtty0a2AERO0Zq5b4KIxK8b5VvcBEEi5T5XuF0GQ+nwycFchTyFfFSE2OfSlTxQHShdJIGsbY6dTtFeqPSy9x5cblYw++ehLVuxzShpE8gnF4llrvyb4kfpXKH4IEoFDVYgm9PFUekbMyz7BpT4ZPMEL81MzXMWjAW9x+8LKthVCSgtO72+Oy1lyMZ+F16tSGEz2cmAL5RrZqfQ4JCo0JSJD6GX+1XUJPkcgjgg0tMzmczz++HHjPzTnHojYpNhM5KJaZVfVIzMsviku0bnmmYTSYYW2c1plUqg6jQw24XeMDxbpzT5+qS1+ypnZW/K1V8rA==; 24:2PfxcDrbUEwJxMn9a6qbw7cTGjNN5GUIoSMNUDFc0uJPlm42yJUAXupir203/UtGjnZVV5C8SGBasxLBLQtFTKuamJx2cGpUSREfYPSua4k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0301MB0608; 7:7W1IO6olFmyex1qND3WS33/0GTX3+AOnOvjhWABeLheC+FzA7GZVYVPoroBE1658hwYrEGHPpBbtt+pXABvxdeGinJV8ZsBkGJKmCSC3RH7azdGngEW+LOjevdiaGqRyYdTa9En0XhF4uWnYLzrWLu+NX1h8ZX3zjyEmYzB7f0mQTlxHRnKhs+ME5m/UtM2Cf8Ufu3ZV+Oo1OhehkdAklMtkgxefQJik31y0CKtf5lZ/hbwS3IQXmVJiuRub7/kIipWK+udQv6pGVWrjxugNXFGhRmlpPV5/ldrfOAm623b+gnmY/l8blS7vGthRy0h8PHQSD/VSD2BaVU3A5gQDS5IW44J1yHldu8eYOdbIkqfajRmI5O26VlYr12eC5qsvyl0Tp0Xe8Dxfxhdx+5c00URiizP1icLO/CkyHVBfucsxeqF4pB/MOP29sqmzhLeiAiSSH0Rdwocm+O+6YCT0eKj0hadK9q3LKNQeqBmv5E8XpGJ+wblWsW7Bh4rjqM86DgnHZ5daU6OwHFjtJe3phk3Q27qaIXBXuyhMtbIOUuVz+Vpn7Nej6rzENAjtFOR961a6VOBsZWK3ibkTfmbHwMhzoWPQKweHqBulYr41dIGVh4fVp01WmysokL7YRf1XTQD8nwyUx5zQrlrayriIUyc+CrxCwAmomG8f4OQKF8zH9LFNo6/ktsLrbGCljhsdKMe/GPIvc5fZ5rsCNK38ChiqgxCnCmfxJyp7kmltKILjHHgdQyhQaxYHcAu+o7XuqpLkktrFYhAZKQraFKSHmEyrP8u9HqNMqtr5f9RV+2U= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2017 14:03:34.4299 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0608 Subject: Re: [dpdk-dev] [PATCH v7 5/6] bus: add helper to find a bus from a device name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 14:03:37 -0000 On Wednesday 05 July 2017 07:15 PM, Gaëtan Rivet wrote: > Hi Shreyansh, > > On Wed, Jul 05, 2017 at 07:05:40PM +0530, Shreyansh Jain wrote: >> Hello Gaetan, >> >> Some comments inline: >> >> On Wednesday 05 July 2017 05:25 AM, Gaetan Rivet wrote: >>> Find which bus should be able to parse this device name into an internal >>> device representation. >>> >>> Signed-off-by: Gaetan Rivet >>> --- >>> lib/librte_eal/common/eal_common_bus.c | 21 +++++++++++++++++++++ >>> lib/librte_eal/common/eal_private.h | 12 ++++++++++++ >>> 2 files changed, 33 insertions(+) >>> >>> diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c >>> index 87b0c6e..34fcfa1 100644 >>> --- a/lib/librte_eal/common/eal_common_bus.c >>> +++ b/lib/librte_eal/common/eal_common_bus.c >>> @@ -204,3 +204,24 @@ rte_bus_find_by_name(const char *busname) >>> { >>> return rte_bus_find(NULL, cmp_bus_name, (const void *)busname); >>> } >>> + >>> +static int >>> +bus_can_parse(const struct rte_bus *bus, const void *_name) >>> +{ >>> + const char *name = _name; >>> + >>> + return !(bus->parse && bus->parse(name, NULL) == 0); >>> +} >>> + >>> +struct rte_bus * >>> +rte_bus_find_by_device_name(const char *str) >>> +{ >>> + char name[32]; >> >> It is possible to use a constant here? Basically, I am not sure why '32' has >> been chosen - or maybe, it might remind a reader in future the reason for >> this value. >> >> Just to clarify: is there any documented limit on bus name? Until this >> point, the name (and length) of bus was responsibility of bus driver >> implementation. eal_common_bus.c doesn't codify any limit - so, this may >> have to be advertised, even if just within the code. >> > > I agree that this is not clear. First thing however: this is a limit on > the device name length, not bus. Ah, yes, I see that now. I mixed up. > > This problem is fixed in [1], as a single common device name location is > defined. The problem is that it is in another patchset (even if both are > closely linked and were only separated to ease integration). Ok. I hadn't yet gone through it yet - so, didn't notice. I will look through that as well. But, if this is already taken care of in that series, consider my comment resolved. > > This limit was currently taken from the arbitrary limit of device in > name in the original rte_devargs for virtual devices. I think it could > be exported as a define by rte_dev.h, used there and reused in [1] to > define the new rte_devargs structure. > > Would that be ok with you? For the purpose of this patch, this is OK. I will read through that patch series and comment if there is something I have comments on. Thanks for highlighting. > > [1]: http://dpdk.org/ml/archives/dev/2017-July/070225.html > >>> + char *c; >>> + >>> + snprintf(name, sizeof(name), "%s", str); >>> + c = strchr(name, ','); >> >> I saw a lot of discussion on the naming assumptions/presumptions. Though, I >> am not sure I have an understood conclusion from that. >> So, this might be incorrect/ill-informed: >> >> Is it assumed that ',' is not present in device name? >> >> Do you think it would be better if this is documented that ',' in a device >> name is reserved (as per devargs)? (or, is this already known?) >> >> For example, in case of DPAA2 devices, I didn't consider this as a case >> while generating names while scanning the bus (though, I didn't have a ',' >> in the name). But, if a well known fact, bus drivers can normalize their >> device names before creating device names. >> > > For this release cycle the discussion was mostly about forbidding (or > not forbidding) characters in bus names. This character is one > limitation previously defined for device names, to separate the device > name from its kvargs. > > I am thus following the current rte_devargs API. > Not sure if that's documented. There are examples in doc, but maybe this > device name limitation is not explicitly said. I agree. There doesn't seem to be much devargs related documentation anyways. (is there?) If someone uses a ',' name (ignorantly), they would get a failure from this function because of partial name match. But its worth documenting - now that EAL (Bus scan) allows device an arbitrary naming (no more just PCI and VDEV). (I will try to write something and push as patch - that is, if I have enough understanding of devargs subsystem.) > >>> + if (c != NULL) >>> + c[0] = '\0'; >>> + return rte_bus_find(NULL, bus_can_parse, name); >>> +} >>> diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h >>> index 6cacce0..0836339 100644 >>> --- a/lib/librte_eal/common/eal_private.h >>> +++ b/lib/librte_eal/common/eal_private.h >>> @@ -338,4 +338,16 @@ int rte_eal_hugepage_attach(void); >>> */ >>> bool rte_eal_using_phys_addrs(void); >>> +/** >>> + * Find a bus capable of identifying a device. >>> + * >>> + * @param str >>> + * A device identifier (PCI address, virtual PMD name, ...). >>> + * >>> + * @return >>> + * A valid bus handle if found. >>> + * NULL if no bus is able to parse this device. >>> + */ >>> +struct rte_bus *rte_bus_find_by_device_name(const char *str); >>> + >>> #endif /* _EAL_PRIVATE_H_ */ >>> >> >> (Apologies for commenting so late in series - feel free to ignore if this >> disrupts your cycle or sounds out-of-context.) >> > > No problem, thanks for reviewing so quickly this patchset. > >> - >> Shreyansh > Other than the 'device name length issue', which would be revisited in other patch series: Acked-by: Shreyansh Jain