From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08E1DA0569; Thu, 12 Mar 2020 08:29:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B8FE1BFA5; Thu, 12 Mar 2020 08:29:32 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A1BFC2BE6 for ; Thu, 12 Mar 2020 08:29:30 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0317322299; Thu, 12 Mar 2020 03:29:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 12 Mar 2020 03:29:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=bJ16Y7NQBsRomGMiqHgMuyZeCHQv/VgyMAH7Z/BY7xc=; b=PlqN79LJcvcF mBG+ruIIwpntL4vMqJi2w7cETCRKUIW24XTSclKR3eD7wS9i8k3RlGEgqeSeVcsS J2CWGKqK1vqXBZR9u8qTj4408gGFzaea52KB6V6Ju9cL0Q1tmomcA+eSXlGLGdSk OQA7iTaImdmJnNSwsOYKD70ab6G/0aM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=bJ16Y7NQBsRomGMiqHgMuyZeCHQv/VgyMAH7Z/BY7 xc=; b=aSt5fz0yU1YzMouzDeAwzvPpbX/UFvq+Y5nmlelGs11d4BNGMeTStFLbk 7CWU+W2NZ/4RNIXIGx6c+cirZuglRBybOptN5Hp/PMj8fn4rXgdgZ0rHNxRZWRDG sNXOWGzHT+SWrEn8sAiqvbQBPVVmHP7lszo4iYp4T3pryEth+pJV54af3lgSSxIt nicu/+No1SO0GLPGrqJ6rz4e7asWo+8lEVacFv7OFRF7PGqvZTaAm2GkAvYf60Nn 8yQ1SBPBjDg3Cca4FUd0cUMWfU0YUGx9ySiBT0McCulmi3mlELP0fhgnkvTY6G2m cWdT6muZH+u647OPfhYtO7wDa5zcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvgedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EA7213061393; Thu, 12 Mar 2020 03:29:28 -0400 (EDT) From: Thomas Monjalon To: Kalesh Anakkur Purayil Cc: dev@dpdk.org, ferruh.yigit@intel.com, declan.doherty@intel.com, arybchenko@solarflare.com Date: Thu, 12 Mar 2020 08:29:26 +0100 Message-ID: <7201091.lvqk35OSZv@xps> In-Reply-To: References: <20200122101654.20824-1-kalesh-anakkur.purayil@broadcom.com> <1956572.bB369e8A3T@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH 1/3] librte_ethdev: support device recovery event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/03/2020 04:31, Kalesh Anakkur Purayil: > On Wed, Mar 11, 2020 at 6:50 PM Thomas Monjalon wrote: > > 22/01/2020 11:16, Kalesh A P: > > > From: Kalesh AP > > > > > > Adding support for recovery event in rte_eth_event framework. > > > FW error and FW reset conditions would be managed by PMD. > > > In such cases, PMD would need recovery events to notify application > > > about PMD has recovered from FW reset or FW error. > > > > > > Signed-off-by: Kalesh AP > > > Signed-off-by: Ajit Khaparde > > > Reviewed-by: Somnath Kotur > > > --- > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > @@ -3015,6 +3015,7 @@ enum rte_eth_event_type { > > > RTE_ETH_EVENT_NEW, /**< port is probed */ > > > RTE_ETH_EVENT_DESTROY, /**< port is released */ > > > RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ > > > + RTE_ETH_EVENT_RECOVERED, /**< port recovered from an error */ > > > > What the application is supposed to do when receiving such event? > > > [Kalesh]: RTE_ETH_EVENT_RECOVERED event is an indication to the > application that PMD has recovered from the reset and is functional > again(i.e control path and data path is up again). On receiving this event > from PMD, application has to re-create any flow rules created prior to the > reset. How the application knows that flow rules were resetted? Is there any other configuration resetted? These informations must be explicit in the doxygen comments.