From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 750BC42C61; Thu, 8 Jun 2023 16:50:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 522D5410D3; Thu, 8 Jun 2023 16:50:50 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2041.outbound.protection.outlook.com [40.107.223.41]) by mails.dpdk.org (Postfix) with ESMTP id 6DDEF40A84; Thu, 8 Jun 2023 16:50:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ByYJ6mq0p09iX4tPgBFukpHKeGwxzM16hcRCNCuezP4XvqKE52nQl86whTEUsD9lAdf5KL8RtXyRmJPK/FZb6NDaE6btKAMMDzoVsifMxx3tcBwbx8LFf6UXf7Hre9dR6AQiMQsI4WTPxkflNxT+HGMxQ2HRULNywwWdSlcGpJLiGxFnn/NjIzIDBiwdfIYMhQPumYz7JskdKnIwDT+UIxQuf24t9C8Mlz5xHkoHnq2vIUq9kG77FRKwSPxzd7y9WRloaro/DqR/ss87guCvuasNKKDxmvT3Z2HopCCOlpE7vDOs8qqidNwHXHAhJW5o36uqCsAh7xypF6Cd/vVxrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2aer+aGe+Vt6StScPqNO+1/5RxfywwTzJnZCbxePEeo=; b=hB005iWgKrrFWNhWrRQ43EuaBUQl/ILfP6Pgqw0fxF3Gl/oUwAVxhClraoA8TztPuEheLUalTDIxd3jDd6HrQKWo9kM1IEQbw1S9m/AjW+rQNgJpCU2206w+YPj0kfu+OFSDIjjOQ14UzLWuJieWP71sPmi9DE3uF7VOhYKi1bG3VwZGyE0xbC4j0DbGuU++KuqryQl5k0T31iw9e2bLUoK2mi8+L6H2O43+wgzdC/wFlaylwSIV/sxa1AVDokL9azUYM6rQ0S3GxB8DYnW5XAIHoBrYvu34iXHwpSXr1NtDr/MX7QzE0HDKzi+SSLSxClPmMAp0O0HOHDk49I4fhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2aer+aGe+Vt6StScPqNO+1/5RxfywwTzJnZCbxePEeo=; b=L74sdtVrScnvLGbF+R//Qoh8JiS/3g4FFaJ1DJKapJEZPNRar9SUyzzWT3VOgoW+PWn57qBsWTZijIdbqOUXIBuOWAkKLkPnK1poqOTPQSQ4kIcLt0nZs/E3TSf1JCwGzKkES+wUVVuc7iLzqNJWFPt43HohlmaS7avzXjrTQ20= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8104.namprd12.prod.outlook.com (2603:10b6:806:35a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 14:50:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Thu, 8 Jun 2023 14:50:47 +0000 Message-ID: <72048757-ef24-18f9-4629-774329314f2f@amd.com> Date: Thu, 8 Jun 2023 15:50:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] net/nfp: fix callback function pointer of disabling promisc Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Qin Ke , stable@dpdk.org References: <20230608030756.814540-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230608030756.814540-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8104:EE_ X-MS-Office365-Filtering-Correlation-Id: 72f2fecf-4ce0-4bae-ca2d-08db682fbe7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /tAb28+uHGzp1jvZOkUXm4OJw4Q9nZy1uVHc5H36+Oh7CU1LVlhrF1ckeXtIvaNBKSih2R6ZSQa3erQ+j+qgLPFODxYn9HZyyb3G78STuXcM6W1FkDcFJP7hux+2VsAfOpyRt92cqgfYgLt5beBeFFOQrQT3Fslmaio7PjMvmP5GodtFMz7KwZX3sBBYEyzL4lfhi8iFLYV0PJckoKrliKsC6zO/U2UBhd1ve33ZKorgz3Om+SpTJiYIa9AdSKb3ngeBjFX4tJZMGWmjmUfgPenOu+afu1VhUoepBTaGZexFpsYTixjFII/2xXDEIkuuXS8vqnZcErMNhUu7dipPErx4ZJPftUtWCRLSoFP9tkqToWprPnfZdehLyW8ETDlHALy3Flyf3hyxbCUEa1rEa0cOo1/1jTa5kYJRNOyeIVPQY2Zw1Q0e2V4WDY216GvqHTtbjqbaonrYmISxiLDjt6AvK1SoCKO1OANp9NwoGE+Vt+r/Y+C09u2Y37P1XD1DhIckmxzex9jLj9uVAjsMFIwgxXI1hwyFdfJqMXvA4nKAOxnVgkeZOA7kXjbaiPh6tt8L6wtG/jw4yambYClZPA0FoCQKSjwERGslpxUmDkiddyERHcDKNw3In1qkQFEUUYpC0xnq44siIn1bh09hug== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199021)(41300700001)(31686004)(6666004)(36756003)(8676002)(8936002)(5660300002)(44832011)(66476007)(66556008)(66946007)(4326008)(316002)(478600001)(2906002)(4744005)(38100700002)(6486002)(6506007)(53546011)(26005)(6512007)(186003)(31696002)(2616005)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1FFQVlMRWl4aDM4eFlJQWdrR1lrMkVjY2MxdHZQTmlzcjU3Vm1XQ2ltNzNZ?= =?utf-8?B?Q0FER0twZFluVGkyTVBDVUZ6UlIydjl5bkRqMTB5VTlodXNZdnN4Y2RLOTJD?= =?utf-8?B?SkJPL1p6RnMyQnFXTzR5ckd1MExLYkJucWVFaDZXclBBU0xvVGJaUE8rZ0c0?= =?utf-8?B?VG5KeUxnUit6SVMrL2t2UWM2REY0YnlZeTloem9jU21YOHVybzFyMThvVGhh?= =?utf-8?B?SHFvNms5QlBpSkZ1TmJKTHpkbDdwUnBVRlN2KzhpWWx2c3ZYY3ptdEJZYnVB?= =?utf-8?B?QjEvWTVhTzdSSjlsNEFRTWZsWWdPZ0V3VmhZQzFPSHRobGk4R3RiZDB1azQ5?= =?utf-8?B?K0psQ3RyMW5jZWJWR0dCeG5kZlFhSmNXTDhmN2U5eCt1MzY4SytTQy9nSFVz?= =?utf-8?B?OTdYUTdVd002clFsVENlQmF6TzRmWXR5OWM4c0tsdWJURVlVb1RSZll2RGFJ?= =?utf-8?B?MWRwUWVnZ2F3OTAxVEtEbjliSHlxaWJZbGxQS0ErRlA0WjZsd2JYVGhkQWU3?= =?utf-8?B?RUlFUzgxMXp4clV1YjZKUi9CZlBuMmtrekhkQlZPN2h6Qm1na0xaMTFldkh1?= =?utf-8?B?Wi82YzVQQkF4YmRHNXlQYlAxOXQ1NnREZkprY296c1dwUjZTd3F5elg1dS91?= =?utf-8?B?SGJ0UWRMLzJVeFdUR1dkdC9YRk04MG42dEgyNGNtczlBUk83RDJ1YzlHSldP?= =?utf-8?B?WlNtOUtDVXh3S3BZYmk1c003d1gzZGRYNmVOSlJCc2ZSUUVabk1UYXFnSCtR?= =?utf-8?B?RjBadGVTTXFzOUhFVnd1Y2dDQ0hud0p0aEMyZEdQc2Z2RW5EaVlOZkxhWjU4?= =?utf-8?B?L3RnTUtHR2pMd3k2Rjh0MWRyendLcElNekNSeEVjVGx2bktmREUvRWVkYXo4?= =?utf-8?B?cWgyM1J3NTRLQWJxWmI4QklQTnljcUtxTGZSSXNXSUduS1ZJMFY4dEpvbnEx?= =?utf-8?B?TUlYc0tPN3B4Tjl3WFRCWC9MS3o5NithUlo4UlhqT0RCVGUwWWNmREdRdlVY?= =?utf-8?B?am1RNW5LbDQ5V2tWQ0dJV05hS1BPRnp2Rzd1blBXYWhrRFVxNHNNbG0vN1oz?= =?utf-8?B?cFlDUVVVZ3Nnc1VyOUsvWUp0WGJWcWJvRlIrcm9FWFVHUzJURUJ2RDhLOW9o?= =?utf-8?B?blpZbVUxWHU0Qy9jK2l5WkhhRWl4dWYvZXNoT2lsUVJ0NFZKbVRoV1RsVFRI?= =?utf-8?B?RHRlYjRzellhMVhLOWRpdUx6eGFYVmpFMlp3eko5TXlTMGJrOENVSXZaWk1a?= =?utf-8?B?RnJXc1dpL1NkdXhtL2J0VHd2cjJYT3FxOEE0dVYyL3RUSnFSWFg0SkJlTFlI?= =?utf-8?B?VE9SZTdjMXFnWE1OcldnL3lwVGpRUkdLWm1sdTV4YnlGVnNXT1NiQ0VvQTh3?= =?utf-8?B?WisyVzdCRWcxS3VGTk1Fd3VpdXUxZGYxNUFIT05VZGl6U0Y2disvQXFkREJJ?= =?utf-8?B?cHRwTjhLelIrajFOdDJnaXE5QnJFS053cys0WUYrRnVLeGYyek92amFLWVE5?= =?utf-8?B?WXdyWkdxWmpHQjh4S1pZT0MyVXIvdkk1Q1pleVovTFBtcjNpTk1Tby9yejc1?= =?utf-8?B?bjJnV21XamhMMTU3Y1BvVUxBVmxnNUF0SEhKN21aakVXY1pURWdpNG4wbkhj?= =?utf-8?B?MTN6cnpQSnhPTVgwc0hJVjBheUhPL3c2OG9ZQlExYTNGQ3cxMXM4ZWE2ZW5F?= =?utf-8?B?VnhLYUF1ZGg4S2FhZU5OcnpHVzVVQXFuOWFjYUg0bnpRY092a2xrVWVCNHI3?= =?utf-8?B?QnNHQzJQU2E2VUVnQ2Rjd2pvZzIzZTViMWlZajVvUmE3SVorS3dpR0llY0RI?= =?utf-8?B?c2F5YjJFRmhMdmtkWFVIWktuL1p3K2NydzlmYVVVK0taSHNzQit5R1hxL0h0?= =?utf-8?B?NzBzTDlpN041ejRLUmt5WExXWi8wc1hSSTgwdEhRRzVlRlN1OHlUTjVHTlRa?= =?utf-8?B?WXhWYVhZWEtiZE5ydGxhNHY2aWVMMlI0ZFlvbHU3eGZzM1RyQkIvWitEQ0hp?= =?utf-8?B?NWZzMUprNTlhLzR0Si85V0E4QW4rUkVEZElsa2cycjlvbElWWkVETWdEWnBV?= =?utf-8?B?ZDNlbW51MTNORkdvcFR6SmtTQ3Y3SEk5cEx5eWFvNS9FRHdpelVkVERGSjZ3?= =?utf-8?Q?hF49jav8473upwiJArIYX4Y1c?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72f2fecf-4ce0-4bae-ca2d-08db682fbe7d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 14:50:47.4758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hb98nNRjIAWNLgdEVB1J03MHii6rm5E/mM9bfduzsvx1tc4dGze8Kny13EHyZnNZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8104 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/8/2023 4:07 AM, Chaoyong He wrote: > From: Qin Ke > > The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops > and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not > nfp_net_promisc_enable, fix it. > > Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port") > Cc: Chaoyong He > Cc: stable@dpdk.org > > Signed-off-by: Qin Ke > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.